mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-08-30 23:27:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

[ty] Add regression test for fixed pyvenv.cfg parsing bug (#18157)
Some checks failed
CI / Determine changes (push) Waiting to run
Details
CI / cargo fmt (push) Waiting to run
Details
CI / cargo clippy (push) Blocked by required conditions
Details
CI / cargo test (linux) (push) Blocked by required conditions
Details
CI / cargo test (linux, release) (push) Blocked by required conditions
Details
CI / cargo test (windows) (push) Blocked by required conditions
Details
CI / cargo test (wasm) (push) Blocked by required conditions
Details
CI / cargo build (release) (push) Waiting to run
Details
CI / cargo build (msrv) (push) Blocked by required conditions
Details
CI / cargo fuzz build (push) Blocked by required conditions
Details
CI / fuzz parser (push) Blocked by required conditions
Details
CI / test scripts (push) Blocked by required conditions
Details
CI / ecosystem (push) Blocked by required conditions
Details
CI / Fuzz for new ty panics (push) Blocked by required conditions
Details
CI / cargo shear (push) Blocked by required conditions
Details
CI / python package (push) Waiting to run
Details
CI / pre-commit (push) Waiting to run
Details
CI / mkdocs (push) Waiting to run
Details
CI / formatter instabilities and black similarity (push) Blocked by required conditions
Details
CI / test ruff-lsp (push) Blocked by required conditions
Details
CI / check playground (push) Blocked by required conditions
Details
CI / benchmarks (push) Blocked by required conditions
Details
[ty Playground] Release / publish (push) Has been cancelled
Details

Browse source
This commit is contained in:
Alex Waygood 2025-05-17 17:10:15 -04:00 • committed by GitHub
parent b86960f18c
commit dd04ca7f58
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 31 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

31
crates/ty_python_semantic/src/site_packages.rs
View file

@ -626,6 +626,7 @@ mod tests {
struct VirtualEnvironmentTestCase {
system_site_packages: bool,
pyvenv_cfg_version_field: Option<&'static str>,
command_field: Option<&'static str>,
}
struct PythonEnvironmentTestCase {
@ -677,6 +678,7 @@ mod tests {
let Some(VirtualEnvironmentTestCase {
pyvenv_cfg_version_field,
system_site_packages,
command_field,
}) = virtual_env
else {
return system_install_sys_prefix;
@ -703,6 +705,10 @@ mod tests {
pyvenv_cfg_contents.push_str(version_field);
pyvenv_cfg_contents.push('\n');
}
if let Some(command_field) = command_field {
pyvenv_cfg_contents.push_str(command_field);
pyvenv_cfg_contents.push('\n');
}
// Deliberately using weird casing here to test that our pyvenv.cfg parsing is case-insensitive:
if *system_site_packages {
pyvenv_cfg_contents.push_str("include-system-site-packages = TRuE\n");
@ -934,6 +940,7 @@ mod tests {
virtual_env: Some(VirtualEnvironmentTestCase {
system_site_packages: false,
pyvenv_cfg_version_field: None,
command_field: None,
}),
};
test.run();
@ -949,6 +956,7 @@ mod tests {
virtual_env: Some(VirtualEnvironmentTestCase {
system_site_packages: false,
pyvenv_cfg_version_field: Some("version = 3.12"),
command_field: None,
}),
};
test.run();
@ -964,6 +972,7 @@ mod tests {
virtual_env: Some(VirtualEnvironmentTestCase {
system_site_packages: false,
pyvenv_cfg_version_field: Some("version_info = 3.12"),
command_field: None,
}),
};
test.run();
@ -979,6 +988,7 @@ mod tests {
virtual_env: Some(VirtualEnvironmentTestCase {
system_site_packages: false,
pyvenv_cfg_version_field: Some("version_info = 3.12.0rc2"),
command_field: None,
}),
};
test.run();
@ -994,6 +1004,7 @@ mod tests {
virtual_env: Some(VirtualEnvironmentTestCase {
system_site_packages: false,
pyvenv_cfg_version_field: Some("version_info = 3.13"),
command_field: None,
}),
};
test.run();
@ -1009,6 +1020,7 @@ mod tests {
virtual_env: Some(VirtualEnvironmentTestCase {
system_site_packages: true,
pyvenv_cfg_version_field: Some("version_info = 3.13"),
command_field: None,
}),
};
test.run();
@ -1096,6 +1108,25 @@ mod tests {
);
}
/// See <https://github.com/astral-sh/ty/issues/430>
#[test]
fn parsing_pyvenv_cfg_with_equals_in_value() {
let test = PythonEnvironmentTestCase {
system: TestSystem::default(),
minor_version: 13,
free_threaded: true,
origin: SysPrefixPathOrigin::VirtualEnvVar,
virtual_env: Some(VirtualEnvironmentTestCase {
system_site_packages: true,
pyvenv_cfg_version_field: Some("version_info = 3.13"),
command_field: Some(
r#"command = /.pyenv/versions/3.13.3/bin/python3.13 -m venv --without-pip --prompt="python-default/3.13.3" /somewhere-else/python/virtualenvs/python-default/3.13.3"#,
),
}),
};
test.run();
}
#[test]
fn parsing_pyvenv_cfg_with_key_but_no_value_fails() {
let system = TestSystem::default();