From dd5d0d523c76e03158f20639c9f46dac13682a0d Mon Sep 17 00:00:00 2001 From: Luo Peng Date: Sun, 1 Sep 2024 19:13:22 +0800 Subject: [PATCH] Enrich messages of SARIF results (#13180) --- crates/ruff_linter/src/message/sarif.rs | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/crates/ruff_linter/src/message/sarif.rs b/crates/ruff_linter/src/message/sarif.rs index 0c53478425..9cc10caf91 100644 --- a/crates/ruff_linter/src/message/sarif.rs +++ b/crates/ruff_linter/src/message/sarif.rs @@ -121,7 +121,7 @@ impl SarifResult { Ok(Self { rule: message.rule(), level: "error".to_string(), - message: message.name().to_string(), + message: message.body().to_string(), uri: url::Url::from_file_path(&path) .map_err(|()| anyhow::anyhow!("Failed to convert path to URL: {}", path.display()))? .to_string(), @@ -141,7 +141,7 @@ impl SarifResult { Ok(Self { rule: message.rule(), level: "error".to_string(), - message: message.name().to_string(), + message: message.body().to_string(), uri: path.display().to_string(), start_line: start_location.row, start_column: start_location.column, @@ -215,6 +215,10 @@ mod tests { .unwrap(); let results = sarif["runs"][0]["results"].as_array().unwrap(); assert_eq!(results.len(), 3); + assert_eq!( + results[0]["message"]["text"].as_str().unwrap(), + "`os` imported but unused" + ); assert!(rules.len() > 3); } }