mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-08-02 18:02:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Add Fix::applicability to JSON output (#4341)

Browse source
This commit is contained in:
Micha Reiser 2023-05-10 16:34:53 +02:00 • committed by GitHub
parent 04097d194c
commit ddbe5a1243
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 7 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

5
crates/ruff/src/message/json.rs
View file

@ -39,8 +39,9 @@ impl Serialize for ExpandedMessages<'_> {
let fix = message.fix.as_ref().map(|fix| {
json!({
"message": message.kind.suggestion.as_deref(),
"edits": &ExpandedEdits { edits: fix.edits(), source_code: &source_code },
"applicability": fix.applicability(),
"message": message.kind.suggestion.as_deref(),
"edits": &ExpandedEdits { edits: fix.edits(), source_code: &source_code },
})
});

3
crates/ruff/src/message/mod.rs
View file

@ -189,14 +189,13 @@ def fibonacci(n):
let fib_source = SourceFileBuilder::new("fib.py", fib).finish();
#[allow(deprecated)]
let unused_variable = Diagnostic::new(
UnusedVariable {
name: "x".to_string(),
},
TextRange::new(TextSize::from(94), TextSize::from(95)),
)
.with_fix(Fix::unspecified(Edit::deletion(
.with_fix(Fix::suggested(Edit::deletion(
TextSize::from(94),
TextSize::from(99),
)));

2
crates/ruff/src/message/snapshots/ruff__message__json__tests__output.snap
View file

@ -7,6 +7,7 @@ expression: content
"code": "F401",
"message": "`os` imported but unused",
"fix": {
"applicability": "Suggested",
"message": "Remove unused import: `os`",
"edits": [
{
@ -37,6 +38,7 @@ expression: content
"code": "F841",
"message": "Local variable `x` is assigned to but never used",
"fix": {
"applicability": "Suggested",
"message": "Remove assignment to unused variable `x`",
"edits": [
{

1
crates/ruff_cli/tests/integration_test.rs
View file

@ -93,6 +93,7 @@ fn test_stdin_json() -> Result<()> {
"code": "F401",
"message": "`os` imported but unused",
"fix": {{
"applicability": "Unspecified",
"message": "Remove unused import: `os`",
"edits": [
{{