mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-08-04 02:38:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Rename SemanticModel::is_builtin to SemanticModel::has_builtin_binding (#10991)

Browse source
This commit is contained in:
Alex Waygood 2024-04-18 11:11:42 +01:00 • committed by GitHub
parent 2cc487eb22
commit e09180b1df
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
46 changed files with 74 additions and 67 deletions
Download patch file Download diff file Expand all files Collapse all files

6
crates/ruff_python_semantic/src/model.rs
View file

@ -255,7 +255,7 @@ impl<'a> SemanticModel<'a> {
/// Note that a "builtin binding" does *not* include explicit lookups via the `builtins`
/// module, e.g. `import builtins; builtins.open`. It *only* includes the bindings
/// that are pre-populated in Python's global scope before any imports have taken place.
pub fn is_builtin(&self, member: &str) -> bool {
pub fn has_builtin_binding(&self, member: &str) -> bool {
self.lookup_symbol(member)
.map(|binding_id| &self.bindings[binding_id])
.is_some_and(|binding| binding.kind.is_builtin())
@ -274,7 +274,7 @@ impl<'a> SemanticModel<'a> {
// Fast path: we only need to worry about name expressions
if !self.seen_module(Modules::BUILTINS) {
let name = &expr.as_name_expr()?.id;
return if self.is_builtin(name) {
return if self.has_builtin_binding(name) {
Some(name)
} else {
None
@ -299,7 +299,7 @@ impl<'a> SemanticModel<'a> {
let Expr::Name(ast::ExprName { id, .. }) = expr else {
return false;
};
return id == symbol && self.is_builtin(symbol);
return id == symbol && self.has_builtin_binding(symbol);
}
// slow path: we need to consider attribute accesses and aliased imports