From e5c1f955454c83f75df372553e9d4592fade83ef Mon Sep 17 00:00:00 2001 From: Charlie Marsh Date: Wed, 22 Feb 2023 22:42:27 -0500 Subject: [PATCH] Check-in updated snapshot (#3161) --- ...s__black_test__remove_for_brackets_py.snap | 11 +- ...lack_test__remove_for_brackets_py.snap.new | 111 ------------------ 2 files changed, 1 insertion(+), 121 deletions(-) delete mode 100644 crates/ruff_python_formatter/src/snapshots/ruff_python_formatter__tests__black_test__remove_for_brackets_py.snap.new diff --git a/crates/ruff_python_formatter/src/snapshots/ruff_python_formatter__tests__black_test__remove_for_brackets_py.snap b/crates/ruff_python_formatter/src/snapshots/ruff_python_formatter__tests__black_test__remove_for_brackets_py.snap index 1753040f6b..544ca7ed1f 100644 --- a/crates/ruff_python_formatter/src/snapshots/ruff_python_formatter__tests__black_test__remove_for_brackets_py.snap +++ b/crates/ruff_python_formatter/src/snapshots/ruff_python_formatter__tests__black_test__remove_for_brackets_py.snap @@ -32,15 +32,6 @@ for (((((k, v))))) in d.items(): ```diff --- Black +++ Ruff -@@ -3,7 +3,7 @@ - print(k, v) - - # Don't touch tuple brackets after `in` --for module in (core, _unicodefun): -+for module in core, _unicodefun: - if hasattr(module, "_verify_python3_env"): - module._verify_python3_env = lambda: None - @@ -17,9 +17,7 @@ for ( k, @@ -62,7 +53,7 @@ for k, v in d.items(): print(k, v) # Don't touch tuple brackets after `in` -for module in core, _unicodefun: +for module in (core, _unicodefun): if hasattr(module, "_verify_python3_env"): module._verify_python3_env = lambda: None diff --git a/crates/ruff_python_formatter/src/snapshots/ruff_python_formatter__tests__black_test__remove_for_brackets_py.snap.new b/crates/ruff_python_formatter/src/snapshots/ruff_python_formatter__tests__black_test__remove_for_brackets_py.snap.new deleted file mode 100644 index 51d74eea0f..0000000000 --- a/crates/ruff_python_formatter/src/snapshots/ruff_python_formatter__tests__black_test__remove_for_brackets_py.snap.new +++ /dev/null @@ -1,111 +0,0 @@ ---- -source: crates/ruff_python_formatter/src/lib.rs -assertion_line: 146 -expression: snapshot -input_file: crates/ruff_python_formatter/resources/test/fixtures/black/simple_cases/remove_for_brackets.py ---- -## Input - -```py -# Only remove tuple brackets after `for` -for (k, v) in d.items(): - print(k, v) - -# Don't touch tuple brackets after `in` -for module in (core, _unicodefun): - if hasattr(module, "_verify_python3_env"): - module._verify_python3_env = lambda: None - -# Brackets remain for long for loop lines -for (why_would_anyone_choose_to_name_a_loop_variable_with_a_name_this_long, i_dont_know_but_we_should_still_check_the_behaviour_if_they_do) in d.items(): - print(k, v) - -for (k, v) in dfkasdjfldsjflkdsjflkdsjfdslkfjldsjfgkjdshgkljjdsfldgkhsdofudsfudsofajdslkfjdslkfjldisfjdffjsdlkfjdlkjjkdflskadjldkfjsalkfjdasj.items(): - print(k, v) - -# Test deeply nested brackets -for (((((k, v))))) in d.items(): - print(k, v) -``` - -## Black Differences - -```diff ---- Black -+++ Ruff -@@ -17,9 +17,7 @@ - for ( - k, - v, --) in ( -- dfkasdjfldsjflkdsjflkdsjfdslkfjldsjfgkjdshgkljjdsfldgkhsdofudsfudsofajdslkfjdslkfjldisfjdffjsdlkfjdlkjjkdflskadjldkfjsalkfjdasj.items() --): -+) in dfkasdjfldsjflkdsjflkdsjfdslkfjldsjfgkjdshgkljjdsfldgkhsdofudsfudsofajdslkfjdslkfjldisfjdffjsdlkfjdlkjjkdflskadjldkfjsalkfjdasj.items(): - print(k, v) - - # Test deeply nested brackets -``` - -## Ruff Output - -```py -# Only remove tuple brackets after `for` -for k, v in d.items(): - print(k, v) - -# Don't touch tuple brackets after `in` -for module in (core, _unicodefun): - if hasattr(module, "_verify_python3_env"): - module._verify_python3_env = lambda: None - -# Brackets remain for long for loop lines -for ( - why_would_anyone_choose_to_name_a_loop_variable_with_a_name_this_long, - i_dont_know_but_we_should_still_check_the_behaviour_if_they_do, -) in d.items(): - print(k, v) - -for ( - k, - v, -) in dfkasdjfldsjflkdsjflkdsjfdslkfjldsjfgkjdshgkljjdsfldgkhsdofudsfudsofajdslkfjdslkfjldisfjdffjsdlkfjdlkjjkdflskadjldkfjsalkfjdasj.items(): - print(k, v) - -# Test deeply nested brackets -for k, v in d.items(): - print(k, v) -``` - -## Black Output - -```py -# Only remove tuple brackets after `for` -for k, v in d.items(): - print(k, v) - -# Don't touch tuple brackets after `in` -for module in (core, _unicodefun): - if hasattr(module, "_verify_python3_env"): - module._verify_python3_env = lambda: None - -# Brackets remain for long for loop lines -for ( - why_would_anyone_choose_to_name_a_loop_variable_with_a_name_this_long, - i_dont_know_but_we_should_still_check_the_behaviour_if_they_do, -) in d.items(): - print(k, v) - -for ( - k, - v, -) in ( - dfkasdjfldsjflkdsjflkdsjfdslkfjldsjfgkjdshgkljjdsfldgkhsdofudsfudsofajdslkfjdslkfjldisfjdffjsdlkfjdlkjjkdflskadjldkfjsalkfjdasj.items() -): - print(k, v) - -# Test deeply nested brackets -for k, v in d.items(): - print(k, v) -``` - -