mirror of
https://github.com/astral-sh/ruff.git
synced 2025-07-28 23:43:53 +00:00
fix(commented-out-code): mypy
and SPDX-License-Identifier
false positives (#2587)
https://mypy.readthedocs.io/en/stable/inline_config.html#configuration-comment-format https://spdx.github.io/spdx-spec/v2.3/using-SPDX-short-identifiers-in-source-files/#e2-format-for-spdx-license-identifier
This commit is contained in:
parent
452b5a4b79
commit
f03c8fff14
1 changed files with 6 additions and 1 deletions
|
@ -4,7 +4,7 @@ use regex::Regex;
|
|||
|
||||
static ALLOWLIST_REGEX: Lazy<Regex> = Lazy::new(|| {
|
||||
Regex::new(
|
||||
r"^(?i)(?:pylint|pyright|noqa|nosec|type:\s*ignore|fmt:\s*(on|off)|isort:\s*(on|off|skip|skip_file|split|dont-add-imports(:\s*\[.*?])?))"
|
||||
r"^(?i)(?:pylint|pyright|noqa|nosec|type:\s*ignore|fmt:\s*(on|off)|isort:\s*(on|off|skip|skip_file|split|dont-add-imports(:\s*\[.*?])?)|mypy:|SPDX-License-Identifier:)"
|
||||
).unwrap()
|
||||
});
|
||||
static BRACKET_REGEX: Lazy<Regex> = Lazy::new(|| Regex::new(r"^[()\[\]{}\s]+$").unwrap());
|
||||
|
@ -128,6 +128,11 @@ mod tests {
|
|||
"# Issue #999: This is not code",
|
||||
&[]
|
||||
));
|
||||
assert!(!comment_contains_code("# mypy: allow-untyped-calls", &[]));
|
||||
assert!(!comment_contains_code(
|
||||
"# SPDX-License-Identifier: MIT",
|
||||
&[]
|
||||
));
|
||||
|
||||
// TODO(charlie): This should be `true` under aggressive mode.
|
||||
assert!(!comment_contains_code("#},", &[]));
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue