heavy debugging, I think I found the root cause

missing the leading comments is causing the whole thing to get indented deep in
the if formatting

crates/ruff_formatter/src/builders.rs

@@ -1206,11 +1206,12 @@ enum IndentMode {
 
 impl<Context> Format<Context> for BlockIndent<'_, Context> {
     fn fmt(&self, f: &mut Formatter<Context>) -> FormatResult<()> {
+        token("<<>>").fmt(f)?;
         let snapshot = f.snapshot();
 
         f.write_element(FormatElement::Tag(StartIndent));
 
-        match self.mode {
+        match dbg!(self.mode) {
             IndentMode::Soft => write!(f, [soft_line_break()])?,
             IndentMode::Block => write!(f, [hard_line_break()])?,
             IndentMode::SoftLineOrSpace | IndentMode::SoftSpace => {

crates/ruff_python_formatter/src/comments/mod.rs

@@ -390,10 +390,10 @@ impl<'a> Comments<'a> {
             writeln!(output, "{:#?}", comment.debug(source_code)).unwrap();
         }
 
-        assert!(
-            output.is_empty(),
-            "The following comments have not been formatted.\n{output}"
-        );
+        // assert!(
+        //     output.is_empty(),
+        //     "The following comments have not been formatted.\n{output}"
+        // );
     }
 
     #[inline(always)]

crates/ruff_python_formatter/src/expression/expr_unary_op.rs

@@ -1,8 +1,7 @@
 use ruff_python_ast::AnyNodeRef;
 use ruff_python_ast::ExprUnaryOp;
 use ruff_python_ast::UnaryOp;
-use ruff_python_trivia::SimpleTokenKind;
-use ruff_python_trivia::SimpleTokenizer;
+use ruff_python_trivia::{SimpleTokenKind, SimpleTokenizer};
 use ruff_text_size::{Ranged, TextRange, TextSize};
 
 use crate::comments::leading_comments;
@@ -17,6 +16,8 @@ pub struct FormatExprUnaryOp;
 
 impl FormatNodeRule<ExprUnaryOp> for FormatExprUnaryOp {
     fn fmt_fields(&self, item: &ExprUnaryOp, f: &mut PyFormatter) -> FormatResult<()> {
+        token("<cursor>").fmt(f)?;
+        dbg!("unary op");
         let ExprUnaryOp {
             range: _,
             node_index: _,

crates/ruff_python_formatter/src/expression/mod.rs

@@ -14,6 +14,7 @@ use ruff_text_size::Ranged;
 use crate::builders::parenthesize_if_expands;
 use crate::comments::{LeadingDanglingTrailingComments, leading_comments, trailing_comments};
 use crate::context::{NodeLevel, WithNodeLevel};
+use crate::expression::expr_unary_op::operand_start;
 use crate::expression::parentheses::{
     NeedsParentheses, OptionalParentheses, Parentheses, Parenthesize, is_expression_parenthesized,
     optional_parentheses, parenthesized,
@@ -125,10 +126,12 @@ impl FormatRule<Expr, PyFormatContext<'_>> for FormatExpr {
             let comments = f.context().comments().clone();
             let node_comments = comments.leading_dangling_trailing(expression);
             if !node_comments.has_leading() && !node_comments.has_trailing() {
+                dbg!("okay");
                 parenthesized("(", &format_expr, ")")
                     .with_hugging(is_expression_huggable(expression, f.context()))
                     .fmt(f)
             } else {
+                dbg!("disaster");
                 format_with_parentheses_comments(expression, &node_comments, f)
             }
         } else {
@@ -373,11 +376,23 @@ impl Format<PyFormatContext<'_>> for MaybeParenthesizeExpression<'_> {
 
         let comments = f.context().comments().clone();
         let node_comments = comments.leading_dangling_trailing(*expression);
+        let up_to = expression
+            .as_unary_op_expr()
+            .map(|unary_op| operand_start(unary_op, f.context().source()));
 
         // If the expression has comments, we always want to preserve the parentheses. This also
         // ensures that we correctly handle parenthesized comments, and don't need to worry about
         // them in the implementation below.
-        if node_comments.has_leading() || node_comments.has_trailing_own_line() {
+        if node_comments.has_leading()
+            || node_comments.has_trailing_own_line()
+            || dbg!(up_to.is_some_and(|up_to| {
+                node_comments
+                    .dangling
+                    .iter()
+                    .any(|comment| comment.end() < up_to)
+            }))
+        {
+            token("<maybe cursor>").fmt(f)?;
             return expression.format().with_options(Parentheses::Always).fmt(f);
         }
 

crates/ruff_python_formatter/src/expression/parentheses.rs

@@ -179,12 +179,15 @@ impl<'ast> Format<PyFormatContext<'ast>> for FormatParenthesized<'_, 'ast> {
         let indented = format_with(|f| {
             let content = Arguments::from(&self.content);
             if self.comments.is_empty() {
+                dbg!("empty?");
                 if self.hug {
                     content.fmt(f)
                 } else {
+                    dbg!("no hug");
                     group(&soft_block_indent(&content)).fmt(f)
                 }
             } else {
+                dbg!("this is dangling");
                 group(&format_args![
                     dangling_open_parenthesis_comments(self.comments),
                     soft_block_indent(&content),

crates/ruff_python_formatter/src/statement/clause.rs

@@ -403,6 +403,7 @@ impl<'ast> Format<PyFormatContext<'ast>> for FormatClauseHeader<'_, 'ast> {
         if has_skip_comment(self.trailing_colon_comment, f.context().source()) {
             write_suppressed_clause_header(self.header, f)?;
         } else {
+            dbg!("last branch in clause header");
             // Write a source map entry for the colon for range formatting to support formatting the clause header without
             // the clause body. Avoid computing `self.header.range()` otherwise because it's somewhat involved.
             let clause_end = if f.options().source_map_generation().is_enabled() {

crates/ruff_python_formatter/src/statement/stmt_if.rs

@@ -22,7 +22,7 @@ impl FormatNodeRule<StmtIf> for FormatStmtIf {
         } = item;
 
         let comments = f.context().comments().clone();
-        let trailing_colon_comment = comments.dangling(item);
+        let trailing_colon_comment = dbg!(comments.dangling(item));
 
         write!(
             f,
@@ -33,6 +33,7 @@ impl FormatNodeRule<StmtIf> for FormatStmtIf {
                     &format_args![
                         token("if"),
                         space(),
+                        token("<cursor>"),
                         maybe_parenthesize_expression(test, item, Parenthesize::IfBreaks),
                     ],
                 ),