mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-11-01 12:25:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Avoid breaking call chains unnecessarily (#6488)

Browse source 
## Summary

This PR attempts to fix the formatting of the following expression:

```python
max_message_id = (
    Message.objects.filter(recipient=recipient).order_by("id").reverse()[0].id
)
```

Specifically, Black preserves _that_ formatting, while we do:

```python
max_message_id = (
    Message.objects.filter(recipient=recipient)
    .order_by("id")
    .reverse()[0]
    .id
)
```

The fix here is to add a group around the entire call chain.

## Test Plan

Before:

- `zulip`: 0.99702
- `django`: 0.99784
- `warehouse`: 0.99585
- `build`: 0.75623
- `transformers`: 0.99470
- `cpython`: 0.75989
- `typeshed`: 0.74853

After:

- `zulip`: 0.99703
- `django`: 0.99791
- `warehouse`: 0.99586
- `build`: 0.75623
- `transformers`: 0.99470
- `cpython`: 0.75989
- `typeshed`: 0.74853
This commit is contained in:
Charlie Marsh 2023-08-11 09:33:15 -04:00 • committed by GitHub
parent b05574babd
commit f2939c678b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 122 additions and 91 deletions
Download patch file Download diff file Expand all files Collapse all files

14
crates/ruff_python_formatter/tests/snapshots/format@parentheses__call_chains.py.snap
View file

@ -160,7 +160,13 @@ zero(
five,
)
max_message_id = (
Message.objects.filter(recipient=recipient).order_by("id").reverse()[0].id
)
max_message_id = (
Message.objects.filter(recipient=recipient).order_by("id").reverse()[0].id()
)
```
## Output
@ -334,6 +340,14 @@ zero(
).four(
five,
)
max_message_id = (
Message.objects.filter(recipient=recipient).order_by("id").reverse()[0].id
)
max_message_id = (
Message.objects.filter(recipient=recipient).order_by("id").reverse()[0].id()
)
```