mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-08-31 07:37:38 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

[ty] Fix ClassLiteral.into_callable for dataclasses (#19192)

Browse source 
## Summary

Change `ClassLiteral.into_callable` to also look for `__init__` functions
of type `Type::Callable` (such as synthesized `__init__` functions of
dataclasses).

Fixes https://github.com/astral-sh/ty/issues/760

## Test Plan

Add subtype test

---------

Co-authored-by: David Peter <mail@david-peter.de>
This commit is contained in:
Matthew Mckee 2025-07-09 09:04:55 +01:00 • committed by GitHub
parent 68106dd631
commit f32f7a3b48
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 44 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

44
crates/ty_python_semantic/src/types/class.rs
View file

@ -661,27 +661,33 @@ impl<'db> ClassType<'db> {
// same parameters as the `__init__` method after it is bound, and with the return type of
// the concrete type of `Self`.
let synthesized_dunder_init_callable =
if let Place::Type(Type::FunctionLiteral(dunder_init_function), _) =
dunder_init_function_symbol
{
let synthesized_signature = |signature: Signature<'db>| {
Signature::new(signature.parameters().clone(), Some(correct_return_type))
.bind_self()
if let Place::Type(ty, _) = dunder_init_function_symbol {
let signature = match ty {
Type::FunctionLiteral(dunder_init_function) => {
Some(dunder_init_function.signature(db))
}
Type::Callable(callable) => Some(callable.signatures(db)),
_ => None,
};
let synthesized_dunder_init_signature = CallableSignature::from_overloads(
dunder_init_function
.signature(db)
.overloads
.iter()
.cloned()
.map(synthesized_signature),
);
Some(Type::Callable(CallableType::new(
db,
synthesized_dunder_init_signature,
true,
)))
if let Some(signature) = signature {
let synthesized_signature = |signature: &Signature<'db>| {
Signature::new(signature.parameters().clone(), Some(correct_return_type))
.bind_self()
};
let synthesized_dunder_init_signature = CallableSignature::from_overloads(
signature.overloads.iter().map(synthesized_signature),
);
Some(Type::Callable(CallableType::new(
db,
synthesized_dunder_init_signature,
true,
)))
} else {
None
}
} else {
None
};