mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-09-30 22:01:18 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

[ty] Fix error message for invalidly providing type arguments to NamedTuple when it occurs in a type expression (#19940)

Browse source
This commit is contained in:
Alex Waygood 2025-08-16 18:45:15 +01:00 • committed by GitHub
parent 527a690a73
commit f4d8826428
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
crates/ty_python_semantic/resources/mdtest/named_tuple.md
View file

@ -312,6 +312,9 @@ def expects_named_tuple(x: typing.NamedTuple):
def _(y: type[typing.NamedTuple]): def _(y: type[typing.NamedTuple]):
reveal_type(y) # revealed: @Todo(unsupported type[X] special form) reveal_type(y) # revealed: @Todo(unsupported type[X] special form)
# error: [invalid-type-form] "Special form `typing.NamedTuple` expected no type parameter"
def _(z: typing.NamedTuple[int]): ...
``` ```
Any instance of a `NamedTuple` class can therefore be passed for a function parameter that is Any instance of a `NamedTuple` class can therefore be passed for a function parameter that is

5
crates/ty_python_semantic/src/types/infer.rs
View file

@ -10783,7 +10783,8 @@ impl<'db> TypeInferenceBuilder<'db, '_> {
SpecialFormType::TypingSelf SpecialFormType::TypingSelf
| SpecialFormType::TypeAlias | SpecialFormType::TypeAlias
| SpecialFormType::TypedDict | SpecialFormType::TypedDict
| SpecialFormType::Unknown => { | SpecialFormType::Unknown
| SpecialFormType::NamedTuple => {
self.infer_type_expression(arguments_slice); self.infer_type_expression(arguments_slice);
if let Some(builder) = self.context.report_lint(&INVALID_TYPE_FORM, subscript) { if let Some(builder) = self.context.report_lint(&INVALID_TYPE_FORM, subscript) {
@ -10808,7 +10809,7 @@ impl<'db> TypeInferenceBuilder<'db, '_> {
SpecialFormType::Tuple => { SpecialFormType::Tuple => {
Type::tuple(self.infer_tuple_type_expression(arguments_slice)) Type::tuple(self.infer_tuple_type_expression(arguments_slice))
} }
SpecialFormType::Generic | SpecialFormType::Protocol | SpecialFormType::NamedTuple => { SpecialFormType::Generic | SpecialFormType::Protocol => {
self.infer_expression(arguments_slice); self.infer_expression(arguments_slice);
if let Some(builder) = self.context.report_lint(&INVALID_TYPE_FORM, subscript) { if let Some(builder) = self.context.report_lint(&INVALID_TYPE_FORM, subscript) {
builder.into_diagnostic(format_args!( builder.into_diagnostic(format_args!(