9461 commits

This branch

This branch

All branches

Author	SHA1	Message	Date
renovate[bot]	7e1db01041	Update Rust crate indicatif to v0.17.11 (#15892) ... This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [indicatif](https://redirect.github.com/console-rs/indicatif) | workspace.dependencies | patch | `0.17.9` -> `0.17.11` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>console-rs/indicatif (indicatif)</summary> ### [`v0.17.11`](https://redirect.github.com/console-rs/indicatif/releases/tag/0.17.11) [Compare Source](https://redirect.github.com/console-rs/indicatif/compare/0.17.10...0.17.11) #### What's Changed - Change `OnceCell` to `OnceLock` in `TabExpandedString` by [@&#8203;tgross35](https://redirect.github.com/tgross35) in [https://github.com/console-rs/indicatif/pull/694](https://redirect.github.com/console-rs/indicatif/pull/694) ### [`v0.17.10`](https://redirect.github.com/console-rs/indicatif/releases/tag/0.17.10) [Compare Source](https://redirect.github.com/console-rs/indicatif/compare/0.17.9...0.17.10) #### What's Changed With some great performance improvements from [@&#8203;jaheba](https://redirect.github.com/jaheba). - Fix bar-less text output by [@&#8203;spoutn1k](https://redirect.github.com/spoutn1k) in [https://github.com/console-rs/indicatif/pull/659](https://redirect.github.com/console-rs/indicatif/pull/659) - add tracing-indicatif create to integration list by [@&#8203;emersonford](https://redirect.github.com/emersonford) in [https://github.com/console-rs/indicatif/pull/673](https://redirect.github.com/console-rs/indicatif/pull/673) - Fix double prints by [@&#8203;spoutn1k](https://redirect.github.com/spoutn1k) in [https://github.com/console-rs/indicatif/pull/671](https://redirect.github.com/console-rs/indicatif/pull/671) - Only get draw_target-width when we actually draw by [@&#8203;jaheba](https://redirect.github.com/jaheba) in [https://github.com/console-rs/indicatif/pull/683](https://redirect.github.com/console-rs/indicatif/pull/683) - Make tab extension lazy by [@&#8203;jaheba](https://redirect.github.com/jaheba) in [https://github.com/console-rs/indicatif/pull/684](https://redirect.github.com/console-rs/indicatif/pull/684) - Make `ProgressBar:set_tab_with` take `&self` by [@&#8203;jaheba](https://redirect.github.com/jaheba) in [https://github.com/console-rs/indicatif/pull/685](https://redirect.github.com/console-rs/indicatif/pull/685) - Remove unnecessary spinner display in multi examples by [@&#8203;shuntaka9576](https://redirect.github.com/shuntaka9576) in [https://github.com/console-rs/indicatif/pull/682](https://redirect.github.com/console-rs/indicatif/pull/682) - Add `dec` and `dec_length` to `ProgressBar` by [@&#8203;jaheba](https://redirect.github.com/jaheba) in [https://github.com/console-rs/indicatif/pull/690](https://redirect.github.com/console-rs/indicatif/pull/690) - Update rand requirement from 0.8 to 0.9 by [@&#8203;dependabot](https://redirect.github.com/dependabot) in [https://github.com/console-rs/indicatif/pull/693](https://redirect.github.com/console-rs/indicatif/pull/693) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/astral-sh/ruff). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xNDUuMCIsInVwZGF0ZWRJblZlciI6IjM5LjE0NS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJpbnRlcm5hbCJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>	2025-02-03 12:22:11 +05:30
renovate[bot]	6331dd6272	Update Rust crate syn to v2.0.98 (#15894) ... This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [syn](https://redirect.github.com/dtolnay/syn) | workspace.dependencies | patch | `2.0.96` -> `2.0.98` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>dtolnay/syn (syn)</summary> ### [`v2.0.98`](https://redirect.github.com/dtolnay/syn/releases/tag/2.0.98) [Compare Source](https://redirect.github.com/dtolnay/syn/compare/2.0.97...2.0.98) - Allow lifetimes in function pointer return values in `ParseStream::call` and `Punctuated` parsers ([#&#8203;1847](https://redirect.github.com/dtolnay/syn/issues/1847)) ### [`v2.0.97`](https://redirect.github.com/dtolnay/syn/releases/tag/2.0.97) [Compare Source](https://redirect.github.com/dtolnay/syn/compare/2.0.96...2.0.97) - Documentation improvements </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/astral-sh/ruff). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xNDUuMCIsInVwZGF0ZWRJblZlciI6IjM5LjE0NS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJpbnRlcm5hbCJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>	2025-02-03 12:19:48 +05:30
renovate[bot]	4fe78db16c	Update Rust crate unicode-ident to v1.0.16 (#15895) ... This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [unicode-ident](https://redirect.github.com/dtolnay/unicode-ident) | workspace.dependencies | patch | `1.0.15` -> `1.0.16` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>dtolnay/unicode-ident (unicode-ident)</summary> ### [`v1.0.16`](https://redirect.github.com/dtolnay/unicode-ident/releases/tag/1.0.16) [Compare Source](https://redirect.github.com/dtolnay/unicode-ident/compare/1.0.15...1.0.16) - Update `rand` dev dependency to 0.9 ([#&#8203;29](https://redirect.github.com/dtolnay/unicode-ident/issues/29)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/astral-sh/ruff). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xNDUuMCIsInVwZGF0ZWRJblZlciI6IjM5LjE0NS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJpbnRlcm5hbCJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>	2025-02-03 12:18:59 +05:30
renovate[bot]	f5f74c95c5	Update Rust crate tempfile to v3.16.0 (#15900) ... This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [tempfile](https://stebalien.com/projects/tempfile-rs/) ([source](https://redirect.github.com/Stebalien/tempfile)) | workspace.dependencies | minor | `3.15.0` -> `3.16.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>Stebalien/tempfile (tempfile)</summary> ### [`v3.16.0`](https://redirect.github.com/Stebalien/tempfile/blob/HEAD/CHANGELOG.md#3160) [Compare Source](https://redirect.github.com/Stebalien/tempfile/compare/v3.15.0...v3.16.0) - Update `getrandom` to `0.3.0` (thanks to [@&#8203;paolobarbolini](https://redirect.github.com/paolobarbolini)). - Allow `windows-sys` versions `0.59.x` in addition to `0.59.0` (thanks [@&#8203;ErichDonGubler](https://redirect.github.com/ErichDonGubler)). - Improved security documentation (thanks to [@&#8203;n0toose](https://redirect.github.com/n0toose) for collaborating with me on this). </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/astral-sh/ruff). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xNDUuMCIsInVwZGF0ZWRJblZlciI6IjM5LjE0NS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJpbnRlcm5hbCJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>	2025-02-03 12:17:44 +05:30
renovate[bot]	464a893f5d	Update pre-commit dependencies (#15898) ... This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [astral-sh/ruff-pre-commit](https://redirect.github.com/astral-sh/ruff-pre-commit) | repository | patch | `v0.9.3` -> `v0.9.4` | | [crate-ci/typos](https://redirect.github.com/crate-ci/typos) | repository | patch | `v1.29.4` -> `v1.29.5` | | [executablebooks/mdformat](https://redirect.github.com/executablebooks/mdformat) | repository | patch | `0.7.21` -> `0.7.22` | | [python-jsonschema/check-jsonschema](https://redirect.github.com/python-jsonschema/check-jsonschema) | repository | patch | `0.31.0` -> `0.31.1` | | [woodruffw/zizmor-pre-commit](https://redirect.github.com/woodruffw/zizmor-pre-commit) | repository | minor | `v1.2.2` -> `v1.3.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. Note: The `pre-commit` manager in Renovate is not supported by the `pre-commit` maintainers or community. Please do not report any problems there, instead [create a Discussion in the Renovate repository](https://redirect.github.com/renovatebot/renovate/discussions/new) if you have any questions. --- ### Release Notes <details> <summary>astral-sh/ruff-pre-commit (astral-sh/ruff-pre-commit)</summary> ### [`v0.9.4`](https://redirect.github.com/astral-sh/ruff-pre-commit/releases/tag/v0.9.4) [Compare Source](https://redirect.github.com/astral-sh/ruff-pre-commit/compare/v0.9.3...v0.9.4) See: https://github.com/astral-sh/ruff/releases/tag/0.9.4 </details> <details> <summary>crate-ci/typos (crate-ci/typos)</summary> ### [`v1.29.5`](https://redirect.github.com/crate-ci/typos/releases/tag/v1.29.5) [Compare Source](https://redirect.github.com/crate-ci/typos/compare/v1.29.4...v1.29.5) #### \[1.29.5] - 2025-01-30 ##### Internal - Update a dependency </details> <details> <summary>executablebooks/mdformat (executablebooks/mdformat)</summary> ### [`v0.7.22`](https://redirect.github.com/executablebooks/mdformat/compare/0.7.21...0.7.22) [Compare Source](https://redirect.github.com/executablebooks/mdformat/compare/0.7.21...0.7.22) </details> <details> <summary>python-jsonschema/check-jsonschema (python-jsonschema/check-jsonschema)</summary> ### [`v0.31.1`](https://redirect.github.com/python-jsonschema/check-jsonschema/blob/HEAD/CHANGELOG.rst#0311) [Compare Source](https://redirect.github.com/python-jsonschema/check-jsonschema/compare/0.31.0...0.31.1) - Update vendored schemas: buildkite, cloudbuild, compose-spec, mergify, renovate (2025-01-26) - Update the `gitlab` and `renovate` hooks to use `--regex-variant nonunicode`. Thanks :user:`quentin-ag` and :user:`Callek` for reporting! (:issue:`516`, :issue:`518`) - Update the required `ruamel.yaml` version to a range, `>=0.18.10,<0.19.0`. </details> <details> <summary>woodruffw/zizmor-pre-commit (woodruffw/zizmor-pre-commit)</summary> ### [`v1.3.0`](https://redirect.github.com/woodruffw/zizmor-pre-commit/releases/tag/v1.3.0) [Compare Source](https://redirect.github.com/woodruffw/zizmor-pre-commit/compare/v1.2.2...v1.3.0) See: https://github.com/woodruffw/zizmor/releases/tag/v1.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/astral-sh/ruff). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xNDUuMCIsInVwZGF0ZWRJblZlciI6IjM5LjE0NS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJpbnRlcm5hbCJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>	2025-02-03 00:32:32 +00:00
renovate[bot]	a53626a8b2	Update dependency ruff to v0.9.4 (#15897) ... This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://docs.astral.sh/ruff) ([source](https://redirect.github.com/astral-sh/ruff), [changelog](https://redirect.github.com/astral-sh/ruff/blob/main/CHANGELOG.md)) | `==0.9.3` -> `==0.9.4` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>astral-sh/ruff (ruff)</summary> ### [`v0.9.4`](https://redirect.github.com/astral-sh/ruff/blob/HEAD/CHANGELOG.md#094) [Compare Source](https://redirect.github.com/astral-sh/ruff/compare/0.9.3...0.9.4) ##### Preview features - \[`airflow`] Extend airflow context parameter check for `BaseOperator.execute` (`AIR302`) ([#&#8203;15713](https://redirect.github.com/astral-sh/ruff/pull/15713)) - \[`airflow`] Update `AIR302` to check for deprecated context keys ([#&#8203;15144](https://redirect.github.com/astral-sh/ruff/pull/15144)) - \[`flake8-bandit`] Permit suspicious imports within stub files (`S4`) ([#&#8203;15822](https://redirect.github.com/astral-sh/ruff/pull/15822)) - \[`pylint`] Do not trigger `PLR6201` on empty collections ([#&#8203;15732](https://redirect.github.com/astral-sh/ruff/pull/15732)) - \[`refurb`] Do not emit diagnostic when loop variables are used outside loop body (`FURB122`) ([#&#8203;15757](https://redirect.github.com/astral-sh/ruff/pull/15757)) - \[`ruff`] Add support for more `re` patterns (`RUF055`) ([#&#8203;15764](https://redirect.github.com/astral-sh/ruff/pull/15764)) - \[`ruff`] Check for shadowed `map` before suggesting fix (`RUF058`) ([#&#8203;15790](https://redirect.github.com/astral-sh/ruff/pull/15790)) - \[`ruff`] Do not emit diagnostic when all arguments to `zip()` are variadic (`RUF058`) ([#&#8203;15744](https://redirect.github.com/astral-sh/ruff/pull/15744)) - \[`ruff`] Parenthesize fix when argument spans multiple lines for `unnecessary-round` (`RUF057`) ([#&#8203;15703](https://redirect.github.com/astral-sh/ruff/pull/15703)) ##### Rule changes - Preserve quote style in generated code ([#&#8203;15726](https://redirect.github.com/astral-sh/ruff/pull/15726), [#&#8203;15778](https://redirect.github.com/astral-sh/ruff/pull/15778), [#&#8203;15794](https://redirect.github.com/astral-sh/ruff/pull/15794)) - \[`flake8-bugbear`] Exempt `NewType` calls where the original type is immutable (`B008`) ([#&#8203;15765](https://redirect.github.com/astral-sh/ruff/pull/15765)) - \[`pylint`] Honor banned top-level imports by `TID253` in `PLC0415`. ([#&#8203;15628](https://redirect.github.com/astral-sh/ruff/pull/15628)) - \[`pyupgrade`] Ignore `is_typeddict` and `TypedDict` for `deprecated-import` (`UP035`) ([#&#8203;15800](https://redirect.github.com/astral-sh/ruff/pull/15800)) ##### CLI - Fix formatter warning message for `flake8-quotes` option ([#&#8203;15788](https://redirect.github.com/astral-sh/ruff/pull/15788)) - Implement tab autocomplete for `ruff config` ([#&#8203;15603](https://redirect.github.com/astral-sh/ruff/pull/15603)) ##### Bug fixes - \[`flake8-comprehensions`] Do not emit `unnecessary-map` diagnostic when lambda has different arity (`C417`) ([#&#8203;15802](https://redirect.github.com/astral-sh/ruff/pull/15802)) - \[`flake8-comprehensions`] Parenthesize `sorted` when needed for `unnecessary-call-around-sorted` (`C413`) ([#&#8203;15825](https://redirect.github.com/astral-sh/ruff/pull/15825)) - \[`pyupgrade`] Handle end-of-line comments for `quoted-annotation` (`UP037`) ([#&#8203;15824](https://redirect.github.com/astral-sh/ruff/pull/15824)) ##### Documentation - Add missing config docstrings ([#&#8203;15803](https://redirect.github.com/astral-sh/ruff/pull/15803)) - Add references to `trio.run_process` and `anyio.run_process` ([#&#8203;15761](https://redirect.github.com/astral-sh/ruff/pull/15761)) - Use `uv init --lib` in tutorial ([#&#8203;15718](https://redirect.github.com/astral-sh/ruff/pull/15718)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/astral-sh/ruff). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xNDUuMCIsInVwZGF0ZWRJblZlciI6IjM5LjE0NS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJpbnRlcm5hbCJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>	2025-02-03 00:31:02 +00:00
Alex Waygood	b08ce5fb18	[flake8-pyi] Minor cosmetic changes to PYI019 (#15881)	2025-02-02 19:20:05 +00:00
Alex Waygood	418aa35041	[flake8-pyi] Avoid an unnecessary .unwrap() call in PYI019 autofix (#15880)	2025-02-02 19:04:41 +00:00
Tom Kuson	813a76e9e2	[red-knot] Add version command (#15823) ... Co-authored-by: Micha Reiser <micha@reiser.io>	2025-02-02 18:56:51 +00:00
InSync	3c09100484	[flake8-pyi] Fix more complex cases (PYI019) (#15821) ... Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>	2025-02-02 18:38:49 +00:00
Micha Reiser	770b7f3439	Vendor benchmark test files (#15878) ... Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>	2025-02-02 18:16:07 +00:00
Alex Waygood	d9a1034db0	Add convenience helper methods for AST nodes representing function parameters (#15871)	2025-02-01 17:16:32 +00:00
Alex Waygood	bcdb3f9840	Use Diagnostic::try_set_fix in bad-generator-return-type (#15873)	2025-02-01 15:44:42 +00:00
github-actions[bot]	942d7f395a	Sync vendored typeshed stubs (#15864) ... Close and reopen this PR to trigger CI Co-authored-by: typeshedbot <>	2025-02-01 01:01:58 +00:00
Andrew Gallant	b58f2c399e	[red-knot] ruff_db: make diagnostic rendering prettier (#15856) ... This change does a simple swap of the existing renderer for one that uses our vendored copy of `annotate-snippets`. We don't change anything about the diagnostic data model, but this alone already makes diagnostics look a lot nicer!	2025-01-31 16:37:02 -05:00
Douglas Creager	fab86de3ef	[red-knot] Should A ∧ !A always be false? (#15839) ... This mimics a simplification we have on the OR side, where we simplify `A ∨ !A` to true. This requires changes to how we add `while` statements to the semantic index, since we now need distinct `VisibilityConstraint`s if we need to model evaluating a `Constraint` multiple times at different points in the execution of the program.	2025-01-31 14:06:52 -05:00
Alex Waygood	c5c0b724fb	[flake8-pyi] Minor simplification for PYI019 (#15855)	2025-01-31 16:54:38 +00:00
Alex Waygood	0d191a13c1	[flake8-pyi] Fix incorrect behaviour of custom-typevar-return-type preview-mode autofix if typing was already imported (PYI019) (#15853)	2025-01-31 16:46:31 +00:00
InSync	b2cb757fa8	[flake8-pyi] Remove type parameter correctly when it is the last (PYI019) (#15854)	2025-01-31 16:22:54 +00:00
Carl Meyer	ce769f6ae2	[red-knot] gather type prevalence statistics (#15834) ... Something Alex and I threw together during our 1:1 this morning. Allows us to collect statistics on the prevalence of various types in a file, most usefully TODO types or other dynamic types.	2025-01-31 07:10:00 -08:00
Alex Waygood	44ac17b3ba	[flake8-pyi] Fix several correctness issues with custom-type-var-return-type (PYI019) (#15851)	2025-01-31 14:19:35 +00:00
Brent Westbrook	f1418be81c	[pyupgrade] Reuse replacement logic from UP046 and UP047 (UP040) (#15840) ... ## Summary This is a follow-up to #15565, tracked in #15642, to reuse the string replacement logic from the other PEP 695 rules instead of the `Generator`, which has the benefit of preserving more comments. However, comments in some places are still dropped, so I added a check for this and update the fix safety accordingly. I also added a `## Fix safety` section to the docs to reflect this and the existing `isinstance` caveat. ## Test Plan Existing UP040 tests, plus some new cases.	2025-01-31 08:10:53 -05:00
InSync	59be5f5278	[refurb] Avoid None | None as well as better detection and fix (FURB168) (#15779)	2025-01-31 11:34:57 +00:00
Dhruv Manilawala	4df0796d61	Remove non-existing lint.extendIgnore editor setting (#15844) ... This setting doesn't exist in the first place. I must've added it by mistake thinking that it exists similar to `extendSelect`. One reason to have auto-generated docs. 988be01fbe/crates/ruff_server/src/session/settings.rs (L124-L133) Closes: #14665	2025-01-31 06:00:17 +00:00
InSync	172f62d8f4	[refurb] Mark fix as unsafe if there are comments (FURB171) (#15832) ... ## Summary Resolves #10063 and follow-up to #15521. The fix is now marked as unsafe if there are any comments within its range. Tests are adapted from that of #15521. ## Test Plan `cargo nextest run` and `cargo insta test`.	2025-01-30 17:21:07 -06:00
Dylan	071862af5a	[flake8-comprehensions] Skip when TypeError present from too many (kw)args for C410,C411, and C418 (#15838) ... Both `list` and `dict` expect only a single positional argument. Giving more positional arguments, or a keyword argument, is a `TypeError` and neither the lint rule nor its fix make sense in that context. Closes #15810	2025-01-30 17:10:43 -06:00
Brent Westbrook	fe516e24f5	[pyflakes] Visit forward annotations in TypeAliasType as types (F401) (#15829) ... ## Summary Fixes https://github.com/astral-sh/ruff/issues/15812 by visiting the second argument as a type definition. ## Test Plan New F401 tests based on the report. --------- Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>	2025-01-30 18:06:38 -05:00
Dylan	4f2aea8d50	[flake8-comprehensions] Handle builtins at top of file correctly for unnecessary-dict-comprehension-for-iterable (C420) (#15837) ... Builtin bindings are given a range of `0..0`, which causes strange behavior when range checks are made at the top of the file. In this case, the logic of the rule demands that the value of the dict comprehension is not self-referential (i.e. it does not contain definitions for any of the variables used within it). This logic was confused by builtins which looked like they were defined "in the comprehension", if the comprehension appeared at the top of the file. Closes #15830	2025-01-30 15:49:13 -06:00
Dylan	5c77898693	Downgrade tailwind (#15835) ... The new version of tailwindcss [sounds very exciting](https://tailwindcss.com/blog/tailwindcss-v4), but upgrading will requite some refactoring. For now, let's revert.	2025-01-30 13:55:07 -06:00
Dylan	854ab03078	Bump version to 0.9.4 (#15831) ... Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>	2025-01-30 11:29:22 -06:00
Leo Gaskin	b0b8b06241	Remove semicolon after TypeScript interface definition (#15827) ... ## Summary This PR removes a trailing semicolon after an interface definition in the custom TypeScript section of `ruff_wasm`. Currently, this semicolon triggers the error "TS1036: Statements are not allowed in ambient contexts" when including the file and compiling with e.g `tsc`. ## Test Plan I made the change, ran `wasm-pack` and copied the generated directory manually to my `node_modules` folder. I then compiled a file importing `@astral-sh/ruff-wasm-web` again and confirmed that the compilation error was gone.	2025-01-30 20:40:16 +05:30
David Peter	451f251a31	[red-knot] Clarify behavior when redeclaring base class attributes (#15826) ... # Summary Clarify the behavior regarding re-declaration of attributes from base classes following [this discussion](https://github.com/astral-sh/ruff/pull/15808#discussion_r1934236095)	2025-01-30 14:49:23 +01:00
Dylan	13cf3e65f1	[flake8-comprehensions] Parenthesize sorted when needed for unnecessary-call-around-sorted (C413) (#15825) ... If there is any `ParenthesizedWhitespace` (in the sense of LibCST) after the function name `sorted` and before the arguments, then we must wrap `sorted` with parentheses after removing the surrounding function. Closes #15789	2025-01-30 07:10:56 -06:00
Dylan	56f956a238	[pyupgrade] Handle end-of-line comments for quoted-annotation (UP037) (#15824) ... This PR uses the tokens of the parsed annotation available in the `Checker`, instead of re-lexing (using `SimpleTokenizer`) the annotation. This avoids some limitations of the `SimpleTokenizer`, such as not being able to handle number and string literals. Closes #15816 .	2025-01-30 00:03:05 -06:00
Tom Kuson	7a10a40b0d	[flake8-bandit] Permit suspicious imports within stub files (S4) (#15822) ... ## Summary Permits suspicious imports (the `S4` namespaced diagnostics) from stub files. Closes #15207. ## Test Plan Added tests and ran `cargo nextest run`. The test files are copied from the `.py` variants.	2025-01-29 23:42:56 -06:00
Alex Waygood	3125332ec1	[red-knot] Format mdtest snippets with the latest version of black (#15819)	2025-01-29 23:05:43 +00:00
Douglas Creager	15d886a502	[red-knot] Consider all definitions after terminal statements unreachable (#15676) ... `FlowSnapshot` now tracks a `reachable` bool, which indicates whether we have encountered a terminal statement on that control flow path. When merging flow states together, we skip any that have been marked unreachable. This ensures that bindings that can only be reached through unreachable paths are not considered visible. ## Test Plan The new mdtests failed (with incorrect `reveal_type` results, and spurious `possibly-unresolved-reference` errors) before adding the new visibility constraints. --------- Co-authored-by: Carl Meyer <carl@astral.sh>	2025-01-29 14:06:57 -05:00
InSync	e1c9d10863	[flake8-comprehensions] Do not emit unnecessary-map diagnostic when lambda has different arity (C417) (#15802)	2025-01-29 18:45:55 +00:00
Brent Westbrook	23c98849fc	Preserve quotes in generated f-strings (#15794) ... ## Summary This is another follow-up to #15726 and #15778, extending the quote-preserving behavior to f-strings and deleting the now-unused `Generator::quote` field. ## Details I also made one unrelated change to `rules/flynt/helpers.rs` to remove a `to_string` call for making a `Box<str>` and tweaked some arguments to some of the `Generator::unparse_f_string` methods to make the code easier to follow, in my opinion. Happy to revert especially the latter of these if needed. Unfortunately this still does not fix the issue in #9660, which appears to be more of an escaping issue than a quote-preservation issue. After #15726, the result is now `a = f'# {"".join([])}' if 1 else ""` instead of `a = f"# {''.join([])}" if 1 else ""` (single quotes on the outside now), but we still don't have the desired behavior of double quotes everywhere on Python 3.12+. I added a test for this but split it off into another branch since it ended up being unaddressed here, but my `dbg!` statements showed the correct preferred quotes going into [`UnicodeEscape::with_preferred_quote`](https://github.com/astral-sh/ruff/blob/main/crates/ruff_python_literal/src/escape.rs#L54). ## Test Plan Existing rule and `Generator` tests. --------- Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>	2025-01-29 13:28:22 -05:00
InSync	d151ca85d3	[pyupgrade] Ignore is_typeddict and TypedDict for deprecated-import (UP035) (#15800)	2025-01-29 18:05:46 +00:00
Garrett Reynolds	6c1e19592e	[ruff] Add support for more re patterns (RUF055) (#15764) ... ## Summary Implements some of #14738, by adding support for 6 new patterns: ```py re.search("abc", s) is None # ⇒ "abc" not in s re.search("abc", s) is not None # ⇒ "abc" in s re.match("abc", s) is None # ⇒ not s.startswith("abc") re.match("abc", s) is not None # ⇒ s.startswith("abc") re.fullmatch("abc", s) is None # ⇒ s != "abc" re.fullmatch("abc", s) is not None # ⇒ s == "abc" ``` ## Test Plan ```shell cargo nextest run cargo insta review ``` And ran the fix on my startup's repo. ## Note One minor limitation here: ```py if not re.match('abc', s) is None: pass ``` will get fixed to this (technically correct, just not nice): ```py if not not s.startswith('abc'): pass ``` This seems fine given that Ruff has this covered: the initial code should be caught by [E714](https://docs.astral.sh/ruff/rules/not-is-test/) and the fixed code should be caught by [SIM208](https://docs.astral.sh/ruff/rules/double-negation/).	2025-01-29 10:14:44 -05:00
David Peter	0f1035b930	[red-knot] Extend instance-attribute tests (#15808) ... ## Summary When we discussed the plan on how to proceed with instance attributes, we said that we should first extend our research into the behavior of existing type checkers. The result of this research is summarized in the newly added / modified tests in this PR. The TODO comments align with existing behavior of other type checkers. If we deviate from the behavior, it is described in a comment.	2025-01-29 14:06:32 +01:00
Marek Hanuš	2c3d889dbb	Fix formatter warning message for flake8-quotes option (#15788) ... ## Summary Fix wrong option name in warning message about docstring quotes incompatibility. ## Test Plan Only in CI. No manual testing.	2025-01-29 16:30:28 +05:30
InSync	4bec8ba731	[flake8-bugbear] Exempt NewType calls where the original type is immutable (B008) (#15765) ... ## Summary Resolves #12717. This change incorporates the logic added in #15588. ## Test Plan `cargo nextest run` and `cargo insta test`. --------- Co-authored-by: Dhruv Manilawala <dhruvmanila@gmail.com>	2025-01-29 10:26:17 +00:00
Mike Perlov	6090408f65	Add missing config docstrings (#15803) ... ## Summary As promised in #15603 - the **highly** sophisticated change - adding missing config docstrings that are used in command completions. ## Test Plan I actually made a local change to emit all empty items and verified there are none now, before opening the PR.	2025-01-29 09:02:05 +05:30
InSync	72a4d343ff	[refurb] Do not emit diagnostic when loop variables are used outside loop body (FURB122) (#15757) ... Co-authored-by: Alex Waygood <alex.waygood@gmail.com>	2025-01-28 19:16:21 +00:00
Brent Westbrook	786099a872	[ruff] Check for shadowed map before suggesting fix (RUF058) (#15790) ... ## Summary Fixes #15786 by not suggesting a fix if `map` doesn't have its builtin binding. ## Test Plan New test taken from the report in #15786.	2025-01-28 14:15:37 -05:00
David Peter	ca53eefa6f	[red-knot] Do not use explicit knot_extensions.Unknown declaration (#15787) ... ## Summary Do not use an explict `knot_extensions.Unknown` declaration, as per [this comment](https://github.com/astral-sh/ruff/pull/15766#discussion_r1930997592). Instead, use an undefined name to achieve the same effect.	2025-01-28 17:18:22 +01:00
Brent Westbrook	98d20a8219	Preserve quotes in generated byte strings (#15778) ... ## Summary This is a very closely related follow-up to #15726, adding the same quote-preserving behavior to bytestrings. Only one rule (UP018) was affected this time, and it was easy to mirror the plain string changes. ## Test Plan Existing tests	2025-01-28 08:19:40 -05:00
Alex Waygood	9c938442e5	[minor] Simplify some ExprStringLiteral creation logic (#15775)	2025-01-27 18:51:13 +00:00