mirror of
https://github.com/astral-sh/ruff.git
synced 2025-10-01 22:31:23 +00:00
10111 commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
Alex Waygood
|
ca0cce3f9c
|
[red-knot] Fix more [redundant-cast] false positives (#17170)
Fixes #17164. Simply checking whether one type is gradually equivalent to another is too simplistic here: `Any` is gradually equivalent to `Todo`, but we should permit users to cast from `Todo` or `Unknown` to `Any` without complaining about it. This changes our logic so that we only complain about redundant casts if: - the two types are exactly equal (when normalized) OR they are equivalent (we'll still complain about `Any -> Any` casts, and about `Any | str | int` -> `str | int | Any` casts, since their normalized forms are exactly equal, even though the type is not fully static -- and therefore does not participate in equivalence relations) - AND the casted type does not contain `Todo` |
||
|
David Peter
|
3f00010a7a
|
[red-knot] Three-argument type-calls take 'str' as the first argument (#17168)
## Summary Similar to #17163, a minor fix in the signature of `type(…)`. ## Test Plan New MD tests |
||
|
Dylan
|
d401a5440e
|
Control flow: return and raise (#17121)
We add support for `return` and `raise` statements in the control flow graph: we simply add an edge to the terminal block, push the statements to the current block, and proceed. This implementation will have to be modified somewhat once we add support for `try` statements - then we will need to check whether to _defer_ the jump. But for now this will do! Also in this PR: We fix the `unreachable` diagnostic range so that it lumps together consecutive unreachable blocks. |
||
|
Brent Westbrook
|
755ece0c36
|
Bump 0.11.3 (#17173) | ||
|
Alex Waygood
|
62f8d855d2
|
[red-knot] Improve Debug implementation for semantic_index::SymbolTable (#17172)
## Summary
`dbg!`ing a `SymbolTable` is currently very noisy due to the
`symbols_by_name` field, which doesn't tell you very much at all. The
noisiness makes debugging difficult. This PR removes the
`symbols_by_name` field from the `Debug` implementation.
## Test Plan
`dbg!` output before of the `builtins.pyi` global-scope symbol table:
<details>
```
[crates/red_knot_python_semantic/src/symbol.rs:633:5] symbol_table(db, scope) = SymbolTable {
symbols: [
Symbol {
name: Name("_ast"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("_sitebuiltins"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("_typeshed"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("sys"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("types"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("dict_items"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("dict_keys"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("dict_values"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("AnyStr_co"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("ConvertibleToFloat"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("ConvertibleToInt"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("FileDescriptorOrPath"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("OpenBinaryMode"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("OpenBinaryModeReading"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("OpenBinaryModeUpdating"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("OpenBinaryModeWriting"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("OpenTextMode"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("ReadableBuffer"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("SupportsAdd"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("SupportsAiter"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("SupportsAnext"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("SupportsDivMod"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("SupportsFlush"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("SupportsIter"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("SupportsKeysAndGetItem"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("SupportsLenAndGetItem"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("SupportsNext"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("SupportsRAdd"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("SupportsRDivMod"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("SupportsRichComparison"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("SupportsRichComparisonT"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("SupportsWrite"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("Awaitable"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("Callable"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("Iterable"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("Iterator"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("MutableSet"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("Reversible"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("AbstractSet"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("Sized"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("BufferedRandom"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("BufferedReader"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("BufferedWriter"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("FileIO"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("TextIOWrapper"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("CellType"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("CodeType"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("TracebackType"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("IO"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("Any"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("BinaryIO"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("ClassVar"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("Generic"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("Mapping"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("MutableMapping"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("MutableSequence"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("Protocol"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("Sequence"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("SupportsAbs"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("SupportsBytes"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("SupportsComplex"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("SupportsFloat"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("SupportsIndex"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("TypeVar"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("final"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("overload"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("type_check_only"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("Concatenate"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("Literal"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("LiteralString"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("ParamSpec"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("Self"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("TypeAlias"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("TypeGuard"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("TypeIs"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("TypeVarTuple"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("deprecated"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("GenericAlias"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("_T"),
flags: SymbolFlags(
IS_USED | IS_BOUND,
),
},
Symbol {
name: Name("int"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("_I"),
flags: SymbolFlags(
IS_USED | IS_BOUND,
),
},
Symbol {
name: Name("_T_co"),
flags: SymbolFlags(
IS_USED | IS_BOUND,
),
},
Symbol {
name: Name("_T_contra"),
flags: SymbolFlags(
IS_USED | IS_BOUND,
),
},
Symbol {
name: Name("_R_co"),
flags: SymbolFlags(
IS_USED | IS_BOUND,
),
},
Symbol {
name: Name("_KT"),
flags: SymbolFlags(
IS_USED | IS_BOUND,
),
},
Symbol {
name: Name("_VT"),
flags: SymbolFlags(
IS_USED | IS_BOUND,
),
},
Symbol {
name: Name("_S"),
flags: SymbolFlags(
IS_USED | IS_BOUND,
),
},
Symbol {
name: Name("_T1"),
flags: SymbolFlags(
IS_USED | IS_BOUND,
),
},
Symbol {
name: Name("_T2"),
flags: SymbolFlags(
IS_USED | IS_BOUND,
),
},
Symbol {
name: Name("_T3"),
flags: SymbolFlags(
IS_BOUND,
),
},
Symbol {
name: Name("_T4"),
flags: SymbolFlags(
IS_BOUND,
),
},
Symbol {
name: Name("_T5"),
flags: SymbolFlags(
IS_BOUND,
),
},
Symbol {
name: Name("_SupportsNextT_co"),
flags: SymbolFlags(
IS_USED | IS_BOUND,
),
},
Symbol {
name: Name("_SupportsAnextT_co"),
flags: SymbolFlags(
IS_USED | IS_BOUND,
),
},
Symbol {
name: Name("_AwaitableT"),
flags: SymbolFlags(
IS_USED | IS_BOUND,
),
},
Symbol {
name: Name("_AwaitableT_co"),
flags: SymbolFlags(
IS_USED | IS_BOUND,
),
},
Symbol {
name: Name("_P"),
flags: SymbolFlags(
IS_USED | IS_BOUND,
),
},
Symbol {
name: Name("_StartT_co"),
flags: SymbolFlags(
IS_USED | IS_BOUND,
),
},
Symbol {
name: Name("_StopT_co"),
flags: SymbolFlags(
IS_USED | IS_BOUND,
),
},
Symbol {
name: Name("_StepT_co"),
flags: SymbolFlags(
IS_USED | IS_BOUND,
),
},
Symbol {
name: Name("object"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("staticmethod"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("classmethod"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("type"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("super"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("_PositiveInteger"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("_NegativeInteger"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("_LiteralInteger"),
flags: SymbolFlags(
IS_USED | IS_BOUND,
),
},
Symbol {
name: Name("float"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("complex"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("_FormatMapMapping"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("_TranslateTable"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("str"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("bytes"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("bytearray"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("_IntegerFormats"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("memoryview"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("bool"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("slice"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("tuple"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("function"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("list"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("dict"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("set"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("frozenset"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("enumerate"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("range"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("property"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("_NotImplementedType"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("NotImplemented"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("abs"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("all"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("any"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("ascii"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("bin"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("breakpoint"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("callable"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("chr"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("_PathLike"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("aiter"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("_SupportsSynchronousAnext"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("anext"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("compile"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("copyright"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("credits"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("delattr"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("dir"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("divmod"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("eval"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("exec"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("exit"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("filter"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("format"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("getattr"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("globals"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("hasattr"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("hash"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("help"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("hex"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("id"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("input"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("_GetItemIterable"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("iter"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("_ClassInfo"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("isinstance"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("issubclass"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("len"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("license"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("locals"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("map"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("max"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("min"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("next"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("oct"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("_Opener"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("open"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("ord"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("_SupportsWriteAndFlush"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("print"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("_E_contra"),
flags: SymbolFlags(
IS_USED | IS_BOUND,
),
},
Symbol {
name: Name("_M_contra"),
flags: SymbolFlags(
IS_USED | IS_BOUND,
),
},
Symbol {
name: Name("_SupportsPow2"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("_SupportsPow3NoneOnly"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("_SupportsPow3"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("_SupportsSomeKindOfPow"),
flags: SymbolFlags(
IS_USED | IS_BOUND,
),
},
Symbol {
name: Name("pow"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("quit"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("reversed"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("repr"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("_SupportsRound1"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("_SupportsRound2"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("round"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("setattr"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("sorted"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("_AddableT1"),
flags: SymbolFlags(
IS_USED | IS_BOUND,
),
},
Symbol {
name: Name("_AddableT2"),
flags: SymbolFlags(
IS_USED | IS_BOUND,
),
},
Symbol {
name: Name("_SupportsSumWithNoDefaultGiven"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("_SupportsSumNoDefaultT"),
flags: SymbolFlags(
IS_USED | IS_BOUND,
),
},
Symbol {
name: Name("sum"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("vars"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("zip"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("__import__"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("__build_class__"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("EllipsisType"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("ellipsis"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("Ellipsis"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("BaseException"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("GeneratorExit"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("KeyboardInterrupt"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("SystemExit"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("Exception"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("StopIteration"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("OSError"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("EnvironmentError"),
flags: SymbolFlags(
IS_BOUND,
),
},
Symbol {
name: Name("IOError"),
flags: SymbolFlags(
IS_BOUND,
),
},
Symbol {
name: Name("WindowsError"),
flags: SymbolFlags(
IS_BOUND,
),
},
Symbol {
name: Name("ArithmeticError"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("AssertionError"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("AttributeError"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("BufferError"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("EOFError"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("ImportError"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("LookupError"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("MemoryError"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("NameError"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("ReferenceError"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("RuntimeError"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("StopAsyncIteration"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("SyntaxError"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("SystemError"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("TypeError"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("ValueError"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("FloatingPointError"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("OverflowError"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("ZeroDivisionError"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("ModuleNotFoundError"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("IndexError"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("KeyError"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("UnboundLocalError"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("BlockingIOError"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("ChildProcessError"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("ConnectionError"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("BrokenPipeError"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("ConnectionAbortedError"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("ConnectionRefusedError"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("ConnectionResetError"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("FileExistsError"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("FileNotFoundError"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("InterruptedError"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("IsADirectoryError"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("NotADirectoryError"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("PermissionError"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("ProcessLookupError"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("TimeoutError"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("NotImplementedError"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("RecursionError"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("IndentationError"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("TabError"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("UnicodeError"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("UnicodeDecodeError"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("UnicodeEncodeError"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("UnicodeTranslateError"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("Warning"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("UserWarning"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("DeprecationWarning"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("SyntaxWarning"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("RuntimeWarning"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("FutureWarning"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("PendingDeprecationWarning"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("ImportWarning"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("UnicodeWarning"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("BytesWarning"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("ResourceWarning"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("EncodingWarning"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("_BaseExceptionT_co"),
flags: SymbolFlags(
IS_USED | IS_BOUND,
),
},
Symbol {
name: Name("_BaseExceptionT"),
flags: SymbolFlags(
IS_BOUND,
),
},
Symbol {
name: Name("_ExceptionT_co"),
flags: SymbolFlags(
IS_USED | IS_BOUND,
),
},
Symbol {
name: Name("_ExceptionT"),
flags: SymbolFlags(
IS_BOUND,
),
},
Symbol {
name: Name("BaseExceptionGroup"),
flags: SymbolFlags(
IS_USED | IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("ExceptionGroup"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
Symbol {
name: Name("PythonFinalizationError"),
flags: SymbolFlags(
IS_BOUND | IS_DECLARED,
),
},
],
symbols_by_name: {
ScopedSymbolId(
235,
): (),
ScopedSymbolId(
267,
): (),
ScopedSymbolId(
86,
): (),
ScopedSymbolId(
22,
): (),
ScopedSymbolId(
182,
): (),
ScopedSymbolId(
213,
): (),
ScopedSymbolId(
252,
): (),
ScopedSymbolId(
177,
): (),
ScopedSymbolId(
173,
): (),
ScopedSymbolId(
108,
): (),
ScopedSymbolId(
122,
): (),
ScopedSymbolId(
118,
): (),
ScopedSymbolId(
197,
): (),
ScopedSymbolId(
69,
): (),
ScopedSymbolId(
134,
): (),
ScopedSymbolId(
52,
): (),
ScopedSymbolId(
248,
): (),
ScopedSymbolId(
168,
): (),
ScopedSymbolId(
2,
): (),
ScopedSymbolId(
129,
): (),
ScopedSymbolId(
5,
): (),
ScopedSymbolId(
18,
): (),
ScopedSymbolId(
150,
): (),
ScopedSymbolId(
9,
): (),
ScopedSymbolId(
16,
): (),
ScopedSymbolId(
205,
): (),
ScopedSymbolId(
246,
): (),
ScopedSymbolId(
68,
): (),
ScopedSymbolId(
93,
): (),
ScopedSymbolId(
189,
): (),
ScopedSymbolId(
161,
): (),
ScopedSymbolId(
64,
): (),
ScopedSymbolId(
124,
): (),
ScopedSymbolId(
229,
): (),
ScopedSymbolId(
94,
): (),
ScopedSymbolId(
202,
): (),
ScopedSymbolId(
67,
): (),
ScopedSymbolId(
120,
): (),
ScopedSymbolId(
219,
): (),
ScopedSymbolId(
12,
): (),
ScopedSymbolId(
20,
): (),
ScopedSymbolId(
79,
): (),
ScopedSymbolId(
11,
): (),
ScopedSymbolId(
157,
): (),
ScopedSymbolId(
216,
): (),
ScopedSymbolId(
231,
): (),
ScopedSymbolId(
239,
): (),
ScopedSymbolId(
140,
): (),
ScopedSymbolId(
36,
): (),
ScopedSymbolId(
13,
): (),
ScopedSymbolId(
184,
): (),
ScopedSymbolId(
204,
): (),
ScopedSymbolId(
70,
): (),
ScopedSymbolId(
259,
): (),
ScopedSymbolId(
96,
): (),
ScopedSymbolId(
111,
): (),
ScopedSymbolId(
72,
): (),
ScopedSymbolId(
247,
): (),
ScopedSymbolId(
101,
): (),
ScopedSymbolId(
242,
): (),
ScopedSymbolId(
261,
): (),
ScopedSymbolId(
263,
): (),
ScopedSymbolId(
214,
): (),
ScopedSymbolId(
62,
): (),
ScopedSymbolId(
166,
): (),
ScopedSymbolId(
244,
): (),
ScopedSymbolId(
257,
): (),
ScopedSymbolId(
133,
): (),
ScopedSymbolId(
112,
): (),
ScopedSymbolId(
87,
): (),
ScopedSymbolId(
90,
): (),
ScopedSymbolId(
117,
): (),
ScopedSymbolId(
158,
): (),
ScopedSymbolId(
162,
): (),
ScopedSymbolId(
230,
): (),
ScopedSymbolId(
154,
): (),
ScopedSymbolId(
255,
): (),
ScopedSymbolId(
35,
): (),
ScopedSymbolId(
39,
): (),
ScopedSymbolId(
138,
): (),
ScopedSymbolId(
190,
): (),
ScopedSymbolId(
21,
): (),
ScopedSymbolId(
66,
): (),
ScopedSymbolId(
181,
): (),
ScopedSymbolId(
7,
): (),
ScopedSymbolId(
236,
): (),
ScopedSymbolId(
251,
): (),
ScopedSymbolId(
152,
): (),
ScopedSymbolId(
227,
): (),
ScopedSymbolId(
78,
): (),
ScopedSymbolId(
55,
): (),
ScopedSymbolId(
61,
): (),
ScopedSymbolId(
253,
): (),
ScopedSymbolId(
47,
): (),
ScopedSymbolId(
65,
): (),
ScopedSymbolId(
153,
): (),
ScopedSymbolId(
104,
): (),
ScopedSymbolId(
74,
): (),
ScopedSymbolId(
107,
): (),
ScopedSymbolId(
149,
): (),
ScopedSymbolId(
98,
): (),
ScopedSymbolId(
155,
): (),
ScopedSymbolId(
169,
): (),
ScopedSymbolId(
180,
): (),
ScopedSymbolId(
237,
): (),
ScopedSymbolId(
146,
): (),
ScopedSymbolId(
15,
): (),
ScopedSymbolId(
243,
): (),
ScopedSymbolId(
17,
): (),
ScopedSymbolId(
136,
): (),
ScopedSymbolId(
80,
): (),
ScopedSymbolId(
44,
): (),
ScopedSymbolId(
228,
): (),
ScopedSymbolId(
60,
): (),
ScopedSymbolId(
245,
): (),
ScopedSymbolId(
193,
): (),
ScopedSymbolId(
264,
): (),
ScopedSymbolId(
268,
): (),
ScopedSymbolId(
58,
): (),
ScopedSymbolId(
258,
): (),
ScopedSymbolId(
279,
): (),
ScopedSymbolId(
113,
): (),
ScopedSymbolId(
135,
): (),
ScopedSymbolId(
240,
): (),
ScopedSymbolId(
85,
): (),
ScopedSymbolId(
186,
): (),
ScopedSymbolId(
100,
): (),
ScopedSymbolId(
187,
): (),
ScopedSymbolId(
106,
): (),
ScopedSymbolId(
73,
): (),
ScopedSymbolId(
223,
): (),
ScopedSymbolId(
49,
): (),
ScopedSymbolId(
83,
): (),
ScopedSymbolId(
77,
): (),
ScopedSymbolId(
43,
): (),
ScopedSymbolId(
274,
): (),
ScopedSymbolId(
46,
): (),
ScopedSymbolId(
151,
): (),
ScopedSymbolId(
217,
): (),
ScopedSymbolId(
178,
): (),
ScopedSymbolId(
278,
): (),
ScopedSymbolId(
132,
): (),
ScopedSymbolId(
6,
): (),
ScopedSymbolId(
174,
): (),
ScopedSymbolId(
99,
): (),
ScopedSymbolId(
196,
): (),
ScopedSymbolId(
109,
): (),
ScopedSymbolId(
128,
): (),
ScopedSymbolId(
123,
): (),
ScopedSymbolId(
102,
): (),
ScopedSymbolId(
116,
): (),
ScopedSymbolId(
172,
): (),
ScopedSymbolId(
32,
): (),
ScopedSymbolId(
105,
): (),
ScopedSymbolId(
241,
): (),
ScopedSymbolId(
95,
): (),
ScopedSymbolId(
206,
): (),
ScopedSymbolId(
209,
): (),
ScopedSymbolId(
198,
): (),
ScopedSymbolId(
81,
): (),
ScopedSymbolId(
170,
): (),
ScopedSymbolId(
171,
): (),
ScopedSymbolId(
8,
): (),
ScopedSymbolId(
276,
): (),
ScopedSymbolId(
1,
): (),
ScopedSymbolId(
212,
): (),
ScopedSymbolId(
222,
): (),
ScopedSymbolId(
33,
): (),
ScopedSymbolId(
144,
): (),
ScopedSymbolId(
194,
): (),
ScopedSymbolId(
125,
): (),
ScopedSymbolId(
89,
): (),
ScopedSymbolId(
38,
): (),
ScopedSymbolId(
51,
): (),
ScopedSymbolId(
19,
): (),
ScopedSymbolId(
163,
): (),
ScopedSymbolId(
0,
): (),
ScopedSymbolId(
211,
): (),
ScopedSymbolId(
3,
): (),
ScopedSymbolId(
226,
): (),
ScopedSymbolId(
121,
): (),
ScopedSymbolId(
148,
): (),
ScopedSymbolId(
232,
): (),
ScopedSymbolId(
262,
): (),
ScopedSymbolId(
260,
): (),
ScopedSymbolId(
91,
): (),
ScopedSymbolId(
270,
): (),
ScopedSymbolId(
269,
): (),
ScopedSymbolId(
225,
): (),
ScopedSymbolId(
191,
): (),
ScopedSymbolId(
115,
): (),
ScopedSymbolId(
28,
): (),
ScopedSymbolId(
220,
): (),
ScopedSymbolId(
164,
): (),
ScopedSymbolId(
250,
): (),
ScopedSymbolId(
137,
): (),
ScopedSymbolId(
141,
): (),
ScopedSymbolId(
24,
): (),
ScopedSymbolId(
54,
): (),
ScopedSymbolId(
45,
): (),
ScopedSymbolId(
188,
): (),
ScopedSymbolId(
75,
): (),
ScopedSymbolId(
40,
): (),
ScopedSymbolId(
234,
): (),
ScopedSymbolId(
30,
): (),
ScopedSymbolId(
41,
): (),
ScopedSymbolId(
127,
): (),
ScopedSymbolId(
185,
): (),
ScopedSymbolId(
145,
): (),
ScopedSymbolId(
23,
): (),
ScopedSymbolId(
238,
): (),
ScopedSymbolId(
143,
): (),
ScopedSymbolId(
167,
): (),
ScopedSymbolId(
110,
): (),
ScopedSymbolId(
25,
): (),
ScopedSymbolId(
31,
): (),
ScopedSymbolId(
57,
): (),
ScopedSymbolId(
195,
): (),
ScopedSymbolId(
221,
): (),
ScopedSymbolId(
218,
): (),
ScopedSymbolId(
37,
): (),
ScopedSymbolId(
71,
): (),
ScopedSymbolId(
50,
): (),
ScopedSymbolId(
176,
): (),
ScopedSymbolId(
179,
): (),
ScopedSymbolId(
200,
): (),
ScopedSymbolId(
266,
): (),
ScopedSymbolId(
277,
): (),
ScopedSymbolId(
119,
): (),
ScopedSymbolId(
84,
): (),
ScopedSymbolId(
114,
): (),
ScopedSymbolId(
165,
): (),
ScopedSymbolId(
271,
): (),
ScopedSymbolId(
280,
): (),
ScopedSymbolId(
256,
): (),
ScopedSymbolId(
249,
): (),
ScopedSymbolId(
88,
): (),
ScopedSymbolId(
27,
): (),
ScopedSymbolId(
139,
): (),
ScopedSymbolId(
265,
): (),
ScopedSymbolId(
4,
): (),
ScopedSymbolId(
53,
): (),
ScopedSymbolId(
29,
): (),
ScopedSymbolId(
130,
): (),
ScopedSymbolId(
42,
): (),
ScopedSymbolId(
76,
): (),
ScopedSymbolId(
147,
): (),
ScopedSymbolId(
156,
): (),
ScopedSymbolId(
208,
): (),
ScopedSymbolId(
273,
): (),
ScopedSymbolId(
183,
): (),
ScopedSymbolId(
224,
): (),
ScopedSymbolId(
97,
): (),
ScopedSymbolId(
233,
): (),
ScopedSymbolId(
82,
): (),
ScopedSymbolId(
142,
): (),
ScopedSymbolId(
254,
): (),
ScopedSymbolId(
131,
): (),
ScopedSymbolId(
63,
): (),
ScopedSymbolId(
48,
): (),
ScopedSymbolId(
215,
): (),
ScopedSymbolId(
103,
): (),
ScopedSymbolId(
14,
): (),
ScopedSymbolId(
92,
): (),
ScopedSymbolId(
207,
): (),
ScopedSymbolId(
275,
): (),
ScopedSymbolId(
160,
): (),
ScopedSymbolId(
26,
): (),
ScopedSymbolId(
56,
): (),
ScopedSymbolId(
34,
): (),
ScopedSymbolId(
272,
): (),
ScopedSymbolId(
59,
): (),
ScopedSymbolId(
126,
): (),
ScopedSymbolId(
159,
): (),
ScopedSymbolId(
199,
): (),
ScopedSymbolId(
175,
): (),
ScopedSymbolId(
192,
): (),
ScopedSymbolId(
201,
): (),
ScopedSymbolId(
203,
): (),
ScopedSymbolId(
210,
): (),
ScopedSymbolId(
10,
): (),
},
}
```
</details>
I checked that with this PR, the second field is gone from the debug
output (I'd paste it in, but it goes over the GitHub comment length
maximum).
|
||
|
David Peter
|
130339f3d8
|
[red-knot] Fix str(…) calls (#17163)
## Summary The existing signature for `str` calls had various problems, one of which I noticed while looking at some ecosystem projects (`scrapy`, added as a project to mypy_primer in this PR). ## Test Plan - New tests for `str(…)` calls. - Observed reduction of false positives in ecosystem checks |
||
|
Eric Mark Martin
|
e50fc049ab
|
[red-knot] visibility_constraint analysis for match cases (#17077)
## Summary Add visibility constraint analysis for pattern predicate kinds `Singleton`, `Or`, and `Class`. ## Test Plan update conditional/match.md |
||
|
Micha Reiser
|
66355a6185
|
[red-knot] Fix playground crashes when diagnostics are stale (#17165)
Some checks are pending
CI / Determine changes (push) Waiting to run
CI / cargo fmt (push) Waiting to run
CI / cargo clippy (push) Blocked by required conditions
CI / cargo test (linux) (push) Blocked by required conditions
CI / cargo test (linux, release) (push) Blocked by required conditions
CI / cargo test (windows) (push) Blocked by required conditions
CI / cargo test (wasm) (push) Blocked by required conditions
CI / cargo build (release) (push) Waiting to run
CI / cargo build (msrv) (push) Blocked by required conditions
CI / cargo fuzz build (push) Blocked by required conditions
CI / fuzz parser (push) Blocked by required conditions
CI / test scripts (push) Blocked by required conditions
CI / ecosystem (push) Blocked by required conditions
CI / cargo shear (push) Blocked by required conditions
CI / python package (push) Waiting to run
CI / pre-commit (push) Waiting to run
CI / mkdocs (push) Waiting to run
CI / formatter instabilities and black similarity (push) Blocked by required conditions
CI / test ruff-lsp (push) Blocked by required conditions
CI / check playground (push) Blocked by required conditions
CI / benchmarks (push) Blocked by required conditions
[Knot Playground] Release / publish (push) Waiting to run
## Summary Fixes a crash in the playground where it crashed with an "index out of bounds" error in the `Diagnostic::to_range` call after deleting content at the end of the file. The root cause was that the playground uses `useDeferred` to avoid too frequent `checkFile` calls (to get a smoother UX). However, this has the problem that the rendered `diagnostics` can be stable (from before the last change). Rendering the diagnostics can then fail because the `toRange` call queries the latest content and not the content from when the diagnostics were created. The fix is "easy" in the sense that we now eagerly perform the `toRange` calls. This way, it doesn't matter when the diagnostics are stale for a few ms. This problem can only be observed on examples where Red Knot is "slow" (takes more than ~16ms to check) because only then does `useDeferred` "debounce" the `check` calls. |
||
|
Dhruv Manilawala
|
177afabe18
|
[red-knot] Callable types are disjoint from literals (#17160)
Some checks are pending
CI / Determine changes (push) Waiting to run
CI / cargo fmt (push) Waiting to run
CI / cargo clippy (push) Blocked by required conditions
CI / cargo test (linux) (push) Blocked by required conditions
CI / cargo test (linux, release) (push) Blocked by required conditions
CI / cargo test (windows) (push) Blocked by required conditions
CI / cargo test (wasm) (push) Blocked by required conditions
CI / cargo build (release) (push) Waiting to run
CI / cargo build (msrv) (push) Blocked by required conditions
CI / cargo fuzz build (push) Blocked by required conditions
CI / fuzz parser (push) Blocked by required conditions
CI / test scripts (push) Blocked by required conditions
CI / ecosystem (push) Blocked by required conditions
CI / cargo shear (push) Blocked by required conditions
CI / python package (push) Waiting to run
CI / pre-commit (push) Waiting to run
CI / mkdocs (push) Waiting to run
CI / formatter instabilities and black similarity (push) Blocked by required conditions
CI / test ruff-lsp (push) Blocked by required conditions
CI / check playground (push) Blocked by required conditions
CI / benchmarks (push) Blocked by required conditions
[Knot Playground] Release / publish (push) Waiting to run
## Summary A callable type is disjoint from other literal types. For example, `Type::StringLiteral` must be an instance of exactly `str`, not a subclass of `str`, and `str` is not callable. The same applies to other literal types. This should hopefully fix #17144, I couldn't produce any failures after running property tests multiple times. ## Test Plan Add test cases for disjointness check between callable and other literal types. Run property tests multiple times. |
||
|
Alex Waygood
|
28c68934a4
|
[red-knot] Fix inference for pow between two literal integers (#17161)
## Summary Python `**` works differently to Rust `**`! ## Test Plan Added an mdtest for various edge cases, and checked in the Python REPL that we infer the correct type in all the new cases tested. |
||
|
Alex Waygood
|
195bb433db
|
[red-knot] Add GitHub PR annotations when mdtests fail in CI (#17150)
## Summary This PR adds a CI job that causes GitHub to add annotations to a PR diff when mdtest assertions fail. For example: <details> <summary>Screenshot</summary>  </details> ## Motivation Debugging mdtest failures locally is currently a really nice experience: - Errors are displayed with pretty colours, which makes them much more readable - If you run the test from inside an IDE, you can CTRL-click on a path and jump directly to the line that had the failing assertion - If you use [`mdtest.py`](https://github.com/astral-sh/ruff/blob/main/crates/red_knot_python_semantic/mdtest.py), you don't even need to recompile anything after changing an assertion in an mdtest, amd the test results instantly live-update with each change to the MarkDown file Debugging mdtest failures in CI is much more unpleasant, however. Sometimes an error message is just > [static-assert-error] Argument evaluates to `False` ...which doesn't tell you very much unless you navigate to the line in question that has the failing mdtest assertion. The line in question might not even be touched by the PR, and even if it is, it can be hard to find the line if the PR touches many files. Unlike locally, you can't click on the error and jump straight to the line that contains the failing assertion. You also don't get colourised output in CI (https://github.com/astral-sh/ruff/issues/13939). GitHub PR annotations should make it really easy to debug why mdtests are failing on PRs, making PR review much easier. ## Test Plan I opened a PR to my fork [here](https://github.com/AlexWaygood/ruff/pull/11/files) with some bogus changes to an mdtest to show what it looks like when there are failures in CI and this job has been added. Scroll down to `crates/red_knot_python_semantic/resources/mdtest/type_properties/is_equivalent_to.md` on the "files changed" tab for that PR to see the annotations. |
||
|
Alex Waygood
|
c2bb5d5250
|
[red-knot] Fix equivalence of differently ordered unions that contain Callable types (#17145)
## Summary Fixes https://github.com/astral-sh/ruff/issues/17058. Equivalent callable types were not understood as equivalent when they appeared nested inside unions and intersections. This PR fixes that by ensuring that `Callable` elements nested inside unions, intersections and tuples have their representations normalized before one union type is compared with another for equivalence, or before one intersection type is compared with another for equivalence. The normalizations applied to a `Callable` type are: - the type of the default value is stripped from all parameters (only whether the parameter _has_ a default value is relevant to whether one `Callable` type is equivalent to another) - The names of the parameters are stripped from positional-only parameters, variadic parameters and keyword-variadic parameters - Unions and intersections that are present (top-level or nested) inside parameter annotations or return annotations are normalized. Adding a `CallableType::normalized()` method also allows us to simplify the implementation of `CallableType::is_equivalent_to()`. ### Should these normalizations be done eagerly as part of a `CallableType` constructor? I considered this. It's something that we could still consider doing in the future; this PR doesn't rule it out as a possibility. However, I didn't pursue it for now, for several reasons: 1. Our current `Display` implementation doesn't handle well the possibility that a parameter might not have a name or an annotated type. Callable types with parameters like this would be displayed as follows: ```py (, ,) -> None: ... ``` That's fixable! It could easily become something like `(Unknown, Unknown) -> None: ...`. But it also illustrates that we probably want to retain the parameter names when displaying the signature of a `lambda` function if you're hovering over a reference to the lambda in an IDE. Currently we don't have a `LambdaType` struct for representing `lambda` functions; if we wanted to eagerly normalize signatures when creating `CallableType`s, we'd probably have to add a `LambdaType` struct so that we would retain the full signature of a `lambda` function, rather than representing it as an eagerly simplified `CallableType`. 2. In order to ensure that it's impossible to create `CallableType`s without the parameters being normalized, I'd either have to create an alternative `SimplifiedSignature` struct (which would duplicate a lot of code), or move `CallableType` to a new module so that the only way of constructing a `CallableType` instance would be via a constructor method that performs the normalizations eagerly on the callable's signature. Again, this isn't a dealbreaker, and I think it's still an option, but it would be a lot of churn, and it didn't seem necessary for now. Doing it this way, at least to start with, felt like it would create a diff that's easier to review and felt like it would create fewer merge conflicts for others. ## Test Plan - Added a regression mdtest for https://github.com/astral-sh/ruff/issues/17058 - Ran `QUICKCHECK_TESTS=1000000 cargo test --release -p red_knot_python_semantic -- --ignored types::property_tests::stable` |
||
|
David Peter
|
cb7dae1e96
|
[red-knot] Add initial set of tests for unreachable code (#17159)
## Summary Add an initial set of tests that will eventually document our behavior around unreachable code. In the last section of this suite, I argue why we should never type check unreachable sections and never emit any diagnostics in these sections. |
||
|
Wei Lee
|
8833484b10
|
[airflow] Move AIR302 to AIR301 and AIR303 to AIR302 (#17151)
## Summary Following up the discussion in https://github.com/astral-sh/ruff/issues/14626#issuecomment-2766548545, we're to reorganize airflow rules. Before this discussion happens, we combine required changes and suggested changes in to one single error code. This PR first rename the original error code to the new error code as we discussed. We will gradually extract suggested changes out of AIR301 and AIR302 to AIR311 and AIR312 in the following PRs ## Test Plan Except for file, error code rename, the test case should work as it used to be. |
||
|
Andrew Gallant
|
adeba3dca7 |
ruff_db: simplify lifetimes on DiagnosticDisplay
I initially split the lifetime out into three distinct lifetimes on near-instinct because I moved the struct into the public API. But because they are all shared borrows, and because there are no other APIs on `DisplayDiagnostic` to access individual fields (and probably never will be), it's probably fine to just specify one lifetime. Because of subtyping, the one lifetime will be the shorter of the three. There's also the point that `ruff_db` isn't _really_ a public API, since it isn't a library that others depend on. So my instinct is probably a bit off there. |
||
|
David Peter
|
af988bf866
|
[red-knot] Detect division-by-zero in unions and intersections (#17157)
Some checks are pending
CI / Determine changes (push) Waiting to run
CI / cargo fmt (push) Waiting to run
CI / cargo clippy (push) Blocked by required conditions
CI / cargo test (linux) (push) Blocked by required conditions
CI / cargo test (linux, release) (push) Blocked by required conditions
CI / cargo test (windows) (push) Blocked by required conditions
CI / cargo test (wasm) (push) Blocked by required conditions
CI / cargo build (release) (push) Waiting to run
CI / cargo build (msrv) (push) Blocked by required conditions
CI / cargo fuzz build (push) Blocked by required conditions
CI / fuzz parser (push) Blocked by required conditions
CI / test scripts (push) Blocked by required conditions
CI / ecosystem (push) Blocked by required conditions
CI / cargo shear (push) Blocked by required conditions
CI / python package (push) Waiting to run
CI / pre-commit (push) Waiting to run
CI / mkdocs (push) Waiting to run
CI / formatter instabilities and black similarity (push) Blocked by required conditions
CI / test ruff-lsp (push) Blocked by required conditions
CI / check playground (push) Blocked by required conditions
CI / benchmarks (push) Blocked by required conditions
[Knot Playground] Release / publish (push) Waiting to run
## Summary
With this PR, we emit a diagnostic for this case where
previously didn't:
```py
from typing import Literal
def f(m: int, n: Literal[-1, 0, 1]):
# error: [division-by-zero] "Cannot divide object of type `int` by zero"
return m / n
```
## Test Plan
New Markdown test
|
||
|
Wei Lee
|
f989c2c3af
|
[airflow] Add autofix infrastructure to AIR302 name checks (#16965)
## Summary Add autofix infrastructure to `AIR302` name checks and use this logic to fix`"airflow", "api_connexion", "security", "requires_access_dataset"`, `"airflow", "Dataset"` and `"airflow", "datasets", "Dataset"` ## Test Plan The existing test fixture reflects the update |
||
|
trag1c
|
c2512b4c50
|
[flake8-bandit] Mark str and list[str] literals as trusted input (S603) (#17136)
## Summary Closes #17112. Allows passing in string and list-of-strings literals into `subprocess.run` (and related) calls without marking them as untrusted input: ```py import subprocess subprocess.run("true") # "instant" named expressions are also allowed subprocess.run(c := "ls") ``` ## Test Plan Added test cases covering new behavior, passed with `cargo nextest run`. |
||
|
Wei Lee
|
6bc2b04c49
|
[airflow] Add autofix for AIR302 attribute checks (#16977)
## Summary Add autofix logic to AIR302 check_method ## Test Plan test fixtures have been updated accordingly |
||
|
Wei Lee
|
fc2a0950eb
|
[airflow] Extend AIR302 with additional symbols (#17085)
## Summary
* ``airflow.auth.managers.base_auth_manager.is_authorized_dataset`` has
been moved to
``airflow.api_fastapi.auth.managers.base_auth_manager.is_authorized_asset``
in Airflow 3.0
* ``airflow.auth.managers.models.resource_details.DatasetDetails`` has
been moved to
``airflow.api_fastapi.auth.managers.models.resource_details.AssetDetails``
in Airflow 3.0
* Dag arguments `default_view` and `orientation` has been removed in
Airflow 3.0
* `airflow.models.baseoperatorlink.BaseOperatorLink` has been moved to
`airflow.sdk.definitions.baseoperatorlink.BaseOperatorLink` in Airflow
3.0
* ``airflow.notifications.basenotifier.BaseNotifier`` has been moved to
``airflow.sdk.BaseNotifier`` in Airflow 3.0
* ``airflow.utils.log.secrets_masker`` has been moved to
``airflow.sdk.execution_time.secrets_masker`` in Airflow 3.0
* ``airflow...DAG.allow_future_exec_dates`` has been removed in Airflow
3.0
* `airflow.utils.db.create_session` has een removed in Airflow 3.0
* `airflow.sensors.base_sensor_operator.BaseSensorOperator` has been
moved to `airflow.sdk.bases.sensor.BaseSensorOperator` removed Airflow
3.0
* `airflow.utils.file.TemporaryDirectory` has been removed in Airflow
3.0 and can be replaced by `tempfile.TemporaryDirectory`
* `airflow.utils.file.mkdirs` has been removed in Airflow 3.0 and can be
replaced by `pathlib.Path({path}).mkdir`
## Test Plan
Test fixture has been added for these changes
|
||
|
Wei Lee
|
33bd08f49b
|
[airflow] Move AIR301 to AIR002 (#16978)
## Summary Unlike other AIR3XX rules, this best practice can be applied to Airflow 1 and Airflow 2 as well. Thus, we think it might make sense for use to move it to AIR002 so that the first number of the error align to Airflow version as possible to reduce confusion ## Test Plan the test fixture has been updated |
||
|
Wei Lee
|
5d57788328
|
[airflow] Add autofix for AIR302 method checks (#16976)
## Summary Add autofix logic to `AIR302` method checks ## Test Plan Test fixtures have been updated accordingly |
||
|
Andrew Gallant
|
718b0cadf4 |
ruff_db: switch diagnostic rendering over to std::fmt::Display
It was already using this approach internally, so this is "just" a matter of rejiggering the public API of `Diagnostic`. We were previously writing directly to a `std::io::Write` since it was thought that this worked better with the linear typing fakery. Namely, it increased confidence that the diagnostic rendering was actually written somewhere useful, instead of just being converted to a string that could potentially get lost. For reasons discussed in #17130, the linear type fakery was removed. And so there is less of a reason to require a `std::io::Write` implementation for diagnostic rendering. Indeed, this would sometimes result in `unwrap()` calls when one wants to convert to a `String`. |
||
|
Micha Reiser
|
24498e383d
|
[red-knot] Add 'Goto type definition' to the playground (#17055)
## Summary This PR adds Goto type definition to the playground, using the same infrastructure as the LSP. The main *challenge* with implementing this feature was that the editor can now participate in which tab is open. ## Known limitations The same as for the LSP. Most notably, navigating to types defined in typeshed isn't supported. ## Test Plan https://github.com/user-attachments/assets/22dad7c8-7ac7-463f-b066-5d5b2c45d1fe |
||
|
Andrew Gallant
|
28c7e724e3 |
red_knot_ide: update snapshots
This just adds an extra blank line. I think these tests were written against the new renderer before it was used by Red Knot's `main` function. Once I did that, I saw that it was missing a blank line, and so I added it to match the status quo. But that means these snapshots have become stale. So this commit updates them. |
||
|
Andrew Gallant
|
185bcfef1a |
red_knot_python_semantic: remove comment about TypeCheckDiagnostic
I put this in its own commit in case all of the information removed here was controversial. But it *looks* stale to me. At the very least, `TypeCheckDiagnostic` no longer exists, so that would need to be fixed. And it doesn't really make sense to me (at this point) to make `Diagnostic` a Salsa struct, particularly since we are keen on using it in Ruff (at some point). |
||
|
Andrew Gallant
|
c30e80a3f4 |
ruff_db: delete most of the old diagnostic code
We do keep around `OldSecondaryDiagnosticMessage`, since that's part of the Red Knot `InferContext` API. But it's a rather simple type, and we'll be able to delete it entirely once `InferContext` exposes the new `Diagnostic` type directly. Since we aren't consuming `OldSecondaryDiagnosticMessage` any more, we can now accept a slice instead of a vec. (Thanks Clippy.) |
||
|
Andrew Gallant
|
4e169e5f6c |
red_knot: use Diagnostic inside of red knot
This replaces things like `TypeCheckDiagnostic` with the new Diagnostic` type. This is a "surgical" replacement where we retain the existing API of of diagnostic reporting such that _most_ of Red Knot doesn't need to be changed to support this update. But it will enable us to start using the new diagnostic renderer and to delete the old renderer. It also paves the path for exposing the new `Diagnostic` data model to the broader Red Knot codebase. |
||
|
Andrew Gallant
|
883b8e3870 |
ruff_db: port concise diagnostic rendering to new renderer
Previously, this was only available in the old renderer. To avoid regressions, we just copy it to the new renderer. We don't bother with DRY because the old renderer will be deleted very soon. |
||
|
Andrew Gallant
|
2ca2f73ba8 |
ruff_db: tweak line terminators emitted by diagnostic rendering
This change just brings diagnostic rendering into parity with the status quo. |
||
|
Andrew Gallant
|
90f0766210 |
ruff_db: make Diagnostic::print use a non-mutable borrow
Now that we don't need to update the `printed` flag, this can just be an immutable borrow. (Arguably this should have been an immutable borrow even initially, but I didn't want to introduce interior mutability without a more compelling justification.) |
||
|
Andrew Gallant
|
a9527edbbe |
ruff_db: switch Diagnostic to use Arc, drop linear type fakery
The switch to `Arc` was done because Salsa sometimes requires cloning a `Diagnostic` (or something that contains a `Diagnostic`). And so it probably makes sense to make this cheap. Since `Diagnostic` exposes a mutable API, we adopt "clone on write" semantics. Although, it's more like, "clone on write when the `Arc` has more than one reference." In the common case of creating a `Diagnostic` and then immediately mutating it, no additional copies should be made over the status quo. We also drop the linear type fakery. Its interaction with Salsa is somewhat awkward, and it has been suggested that there will be points where diagnostics will be dropped unceremoniously without an opportunity to tag them as having been ignored. Moreover, this machinery was added out of "good sense" and isn't actually motivated by real world problems with accidentally ignoring diagnostics. So that makes it easier, I think, to just kick this out entirely instead of trying to find a way to make it work. |
||
|
Andrew Gallant
|
57be814acb |
ruff_db: add method to create sub-diagnostics from old secondary messages
This is temporary to scaffold the refactor. The main idea is that we want to take the `InferContext` API, *as it is*, and migrate that to the new diagnostic data model *internally*. Then we can rip out the old stuff and iterate on the API. |
||
|
Andrew Gallant
|
a8a18e7171 |
red_knot_python_semantic: remove WithDiagnostic trait
I did this mostly because it wasn't buying us much, and I'm trying to simplify the public API of the types I'd like to refactor in order to make the refactor simpler. If we really want something like this, we can re-add it later. |
||
|
Andrew Gallant
|
a953373892 |
red_knot_python_semantic: remove Deref impl on TypeCheckDiagnostics
I removed this to see how much code was depending internally on the `&[Arc<TypeCheckDiagnostic>]` representation. Thankfully, it was just one place. So I just removed the `Deref` impl in favor of adding an explicit `iter` method. In general, I think using `Deref` for things like this is _somewhat_ of an abuse. The tip-off is if there are `&self` or `&mut self` methods on the type, then it's probably not a good candidate for `Deref`. |
||
|
Brent Westbrook
|
d382065f8a
|
[syntax-errors] Reimplement PLE0118 (#17135)
Summary -- This PR reimplements [load-before-global-declaration (PLE0118)](https://docs.astral.sh/ruff/rules/load-before-global-declaration/) as a semantic syntax error. I added a `global` method to the `SemanticSyntaxContext` trait to make this very easy, at least in ruff. Does red-knot have something similar? If this approach will also work in red-knot, I think some of the other PLE rules are also compile-time errors in CPython, PLE0117 in particular. 0115 and 0116 also mention `SyntaxError`s in their docs, but I haven't confirmed them in the REPL yet. Test Plan -- Existing linter tests for PLE0118. I think this actually can't be tested very easily in an inline test because the `TestContext` doesn't have a real way to track globals. --------- Co-authored-by: Micha Reiser <micha@reiser.io> |
||
|
Brent Westbrook
|
d45593288f
|
[syntax-errors] Starred expressions in return, yield, and for (#17134)
Summary -- Fixes https://github.com/astral-sh/ruff/issues/16520 by flagging single, starred expressions in `return`, `yield`, and `for` statements. I thought `yield from` would also be included here, but that error is emitted by the CPython parser: ```pycon >>> ast.parse("def f(): yield from *x") Traceback (most recent call last): File "<python-input-214>", line 1, in <module> ast.parse("def f(): yield from *x") ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.13/ast.py", line 54, in parse return compile(source, filename, mode, flags, _feature_version=feature_version, optimize=optimize) File "<unknown>", line 1 def f(): yield from *x ^ SyntaxError: invalid syntax ``` And we also already catch it in our parser. Test Plan -- New inline tests and updates to existing tests. |
||
|
Micha Reiser
|
2ae39edccf
|
[red-knot] Goto type definition (#16901)
## Summary Implement basic *Goto type definition* support for Red Knot's LSP. This PR also builds the foundation for other LSP operations. E.g., Goto definition, hover, etc., should be able to reuse some, if not most, logic introduced in this PR. The basic steps of resolving the type definitions are: 1. Find the closest token for the cursor offset. This is a bit more subtle than I first anticipated because the cursor could be positioned right between the callee and the `(` in `call(test)`, in which case we want to resolve the type for `call`. 2. Find the node with the minimal range that fully encloses the token found in 1. I somewhat suspect that 1 and 2 could be done at the same time but it complicated things because we also need to compute the spine (ancestor chain) for the node and there's no guarantee that the found nodes have the same ancestors 3. Reduce the node found in 2. to a node that is a valid goto target. This may require traversing upwards to e.g. find the closest expression. 4. Resolve the type for the goto target 5. Resolve the location for the type, return it to the LSP ## Design decisions The current implementation navigates to the inferred type. I think this is what we want because it means that it correctly accounts for narrowing (in which case we want to go to the narrowed type because that's the value's type at the given position). However, it does have the downside that Goto type definition doesn't work whenever we infer `T & Unknown` because intersection types aren't supported. I'm not sure what to do about this specific case, other than maybe ignoring `Unkown` in Goto type definition if the type is an intersection? ## Known limitations * Types defined in the vendored typeshed aren't supported because the client can't open files from the red knot binary (we can either implement our own file protocol and handler OR extract the typeshed files and point there). See https://github.com/astral-sh/ruff/issues/17041 * Red Knot only exposes an API to get types for expressions and definitions. However, there are many other nodes with identifiers that can have a type (e.g. go to type of a globals statement, match patterns, ...). We can add support for those in separate PRs (after we figure out how to query the types from the semantic model). See https://github.com/astral-sh/ruff/issues/17113 * We should have a higher-level API for the LSP that doesn't directly call semantic queries. I intentionally decided not to design that API just yet. ## Test plan https://github.com/user-attachments/assets/fa077297-a42d-4ec8-b71f-90c0802b4edb Goto type definition on a union <img width="1215" alt="Screenshot 2025-04-01 at 13 02 55" src="https://github.com/user-attachments/assets/689cabcc-4a86-4a18-b14a-c56f56868085" /> Note: I recorded this using a custom typeshed path so that navigating to builtins works. |
||
|
cake-monotone
|
7e97910704
|
[red-knot] Fix _NotImplementedType check for Python >=3.10 (#17143)
<!-- Thank you for contributing to Ruff! To help us out with reviewing, please consider the following: - Does this pull request include a summary of the change? (See below.) - Does this pull request include a descriptive title? - Does this pull request include references to any relevant issues? --> ## Summary from https://github.com/astral-sh/ruff/pull/17034#discussion_r2024222525 This is a simple PR to fix the invalid behavior of `NotImplemented` on Python >=3.10. ## Test Plan I think it would be better if we could run mdtest across multiple Python versions in GitHub Actions. <!-- How was it tested? --> --------- Co-authored-by: David Peter <sharkdp@users.noreply.github.com> |
||
|
David Peter
|
ae2cf91a36
|
[red-knot] Decorators and properties (#17017)
Some checks are pending
CI / Determine changes (push) Waiting to run
CI / cargo fmt (push) Waiting to run
CI / cargo clippy (push) Blocked by required conditions
CI / cargo test (linux) (push) Blocked by required conditions
CI / cargo test (linux, release) (push) Blocked by required conditions
CI / cargo test (windows) (push) Blocked by required conditions
CI / cargo test (wasm) (push) Blocked by required conditions
CI / cargo build (release) (push) Waiting to run
CI / cargo build (msrv) (push) Blocked by required conditions
CI / cargo fuzz build (push) Blocked by required conditions
CI / fuzz parser (push) Blocked by required conditions
CI / test scripts (push) Blocked by required conditions
CI / ecosystem (push) Blocked by required conditions
CI / cargo shear (push) Blocked by required conditions
CI / python package (push) Waiting to run
CI / pre-commit (push) Waiting to run
CI / mkdocs (push) Waiting to run
CI / formatter instabilities and black similarity (push) Blocked by required conditions
CI / test ruff-lsp (push) Blocked by required conditions
CI / check playground (push) Blocked by required conditions
CI / benchmarks (push) Blocked by required conditions
[Knot Playground] Release / publish (push) Waiting to run
## Summary Add support for decorators on function as well as support for properties by adding special handling for `@property` and `@<name of property>.setter`/`.getter` decorators. closes https://github.com/astral-sh/ruff/issues/16987 ## Ecosystem results - ✔️ A lot of false positives are fixed by our new understanding of properties - 🔴 A bunch of new false positives (typically `possibly-unbound-attribute` or `invalid-argument-type`) occur because we currently do not perform type narrowing on attributes. And with the new understanding of properties, this becomes even more relevant. In many cases, the narrowing occurs through an assertion, so this is also something that we need to implement to get rid of these false positives. - 🔴 A few new false positives occur because we do not understand generics, and therefore some calls to custom setters fail. - 🔴 Similarly, some false positives occur because we do not understand protocols yet. - ✔️ Seems like a true positive to me. [The setter]( |
||
|
Mohammad Amin Ghasemi
|
e1b5b0de71
|
[flake8-import-conventions] Add import numpy.typing as npt to default flake8-import-conventions.aliases (#17133)
## Summary Adds import `numpy.typing as npt` to `default in flake8-import-conventions.aliases` Resolves #17028 ## Test Plan Manually ran local ruff on the altered fixture and also ran `cargo test` |
||
|
Dhruv Manilawala
|
f63024843c
|
[red-knot] Move tuple containing Never tests (#17137)
Refer https://github.com/astral-sh/ruff/pull/17094#discussion_r2023682840 |
||
|
Matthew Mckee
|
eb3e176309
|
[red-knot] Add callable subtyping for callable instances and bound methods (#17105)
Some checks are pending
CI / Determine changes (push) Waiting to run
CI / cargo fmt (push) Waiting to run
CI / cargo clippy (push) Blocked by required conditions
CI / cargo test (linux) (push) Blocked by required conditions
CI / cargo test (linux, release) (push) Blocked by required conditions
CI / cargo test (windows) (push) Blocked by required conditions
CI / cargo test (wasm) (push) Blocked by required conditions
CI / cargo build (release) (push) Waiting to run
CI / cargo build (msrv) (push) Blocked by required conditions
CI / cargo fuzz build (push) Blocked by required conditions
CI / fuzz parser (push) Blocked by required conditions
CI / test scripts (push) Blocked by required conditions
CI / ecosystem (push) Blocked by required conditions
CI / cargo shear (push) Blocked by required conditions
CI / python package (push) Waiting to run
CI / pre-commit (push) Waiting to run
CI / mkdocs (push) Waiting to run
CI / formatter instabilities and black similarity (push) Blocked by required conditions
CI / test ruff-lsp (push) Blocked by required conditions
CI / check playground (push) Blocked by required conditions
CI / benchmarks (push) Blocked by required conditions
[Knot Playground] Release / publish (push) Waiting to run
## Summary Trying to improve #17005 Partially fixes #16953 ## Test Plan Update is_subtype_of.md --------- Co-authored-by: Carl Meyer <carl@astral.sh> |
||
|
Dhruv Manilawala
|
d38f6fcc55
|
[red-knot] Add property tests for callable types (#17006)
## Summary
Part of #15382, this PR adds property tests for callable types.
Specifically, this PR updates the property tests to generate an
arbitrary signature for a general callable type which includes:
* Arbitrary combination of parameter kinds in the correct order
* Arbitrary number of parameters
* Arbitrary optional types for annotation and return type
* Arbitrary parameter names (no duplicate names), optional for
positional-only parameters
## Test Plan
```
QUICKCHECK_TESTS=100000 cargo test -p red_knot_python_semantic -- --ignored types::property_tests::stable
```
Also, the commands in CI:
|
||
|
Dhruv Manilawala
|
6be0a5057d
|
[red-knot] Disjointness for callable types (#17094)
## Summary Part of #15382, this PR adds support for disjointness between two callable types. They are never disjoint because there exists a callable type that's a subtype of all other callable types: ```py (*args: object, **kwargs: object) -> Never ``` The `Never` is a subtype of every fully static type thus a callable type that has the return type of `Never` means that it is a subtype of every return type. ## Test Plan Add test cases related to mixed parameter kinds, gradual form (`...`) and `Never` type. |
||
|
Alex Waygood
|
d6dcc377f7
|
[red-knot] Flatten Type::Callable into four Type variants (#17126)
## Summary Currently our `Type::Callable` wraps a four-variant `CallableType` enum. But as time has gone on, I think we've found that the four variants in `CallableType` are really more different to each other than they are similar to each other: - `GeneralCallableType` is a structural type describing all callable types with a certain signature, but the other three types are "literal types", more similar to the `FunctionLiteral` variant - `GeneralCallableType` is not a singleton or a single-valued type, but the other three are all single-valued types (`WrapperDescriptorDunderGet` is even a singleton type) - `GeneralCallableType` has (or should have) ambiguous truthiness, but all possible inhabitants of the other three types are always truthy. - As a structural type, `GeneralCallableType` can contain inner unions and intersections that must be sorted in some contexts in our internal model, but this is not true for the other three variants. This PR flattens `Type::Callable` into four distinct `Type::` variants. In the process, it fixes a number of latent bugs that were concealed by the current architecture but are laid bare by the refactor. Unit tests for these bugs are included in the PR. |
||
|
Alex Waygood
|
a43b683d08
|
mdtest.py: do a full mdtest run immediately when the script is executed (#17128)
## Summary
Currently if I run `uv run crates/red_knot_python_semantic/mdtest.py`
from the Ruff repo root, I get this output:
```
~/dev/ruff (main)⚡ % uv run crates/red_knot_python_semantic/mdtest.py
Ready to watch for changes...
```
...And I then have to make some spurious whitespace changes or something
to a test file in order to get the script to actually run mdtest. This
PR changes mdtest.py so that it does an initial run of all mdtests when
you invoke the script, and _then_ starts watching for changes in test
files/Rust code.
|
||
|
Dhruv Manilawala
|
d29d4956de
|
[red-knot] Fix callable subtyping for standard parameters (#17125)
## Summary This PR fixes a bug in callable subtyping to consider both the positional and keyword form of the standard parameter in the supertype when matching against variadic, keyword-only and keyword-variadic parameter in the subtype. This is done by collecting the unmatched standard parameters and then checking them against the keyword-only / keyword-variadic parameters after the positional loop. ## Test Plan Add test cases. |
||
|
Alex Waygood
|
c74ba00219
|
[red-knot] Fix more redundant-cast false positives (#17119)
## Summary
There are quite a few places we infer `Todo` types currently, and some
of them are nested somewhat deeply in type expressions. These can cause
spurious issues for the new `redundant-cast` diagnostics. We fixed all
the false positives we saw in the mypy_primer report before merging
https://github.com/astral-sh/ruff/pull/17100, but I think there are
still lots of places where we'd emit false positives due to this check
-- we currently don't run on that many projects at all in our
mypy_primer check:
|
||
|
github-actions[bot]
|
a15404a5c1
|
Sync vendored typeshed stubs (#17106)
Close and reopen this PR to trigger CI Co-authored-by: typeshedbot <> |