//! Access to the Ruff linting API for the LSP use rustc_hash::FxHashMap; use serde::{Deserialize, Serialize}; use crate::{ DIAGNOSTIC_NAME, PositionEncoding, edit::{NotebookRange, ToRangeExt}, resolve::is_document_excluded_for_linting, session::DocumentQuery, }; use ruff_db::diagnostic::Diagnostic; use ruff_diagnostics::{Applicability, Edit, Fix}; use ruff_linter::{ Locator, directives::{Flags, extract_directives}, generate_noqa_edits, linter::check_path, package::PackageRoot, packaging::detect_package_root, settings::flags, source_kind::SourceKind, }; use ruff_notebook::Notebook; use ruff_python_codegen::Stylist; use ruff_python_index::Indexer; use ruff_python_parser::ParseOptions; use ruff_source_file::LineIndex; use ruff_text_size::{Ranged, TextRange}; /// This is serialized on the diagnostic `data` field. #[derive(Serialize, Deserialize, Debug, Clone)] pub(crate) struct AssociatedDiagnosticData { /// The message describing what the fix does, if it exists, or the diagnostic name otherwise. pub(crate) title: String, /// Edits to fix the diagnostic. If this is empty, a fix /// does not exist. pub(crate) edits: Vec, /// The NOQA code for the diagnostic. pub(crate) code: String, /// Possible edit to add a `noqa` comment which will disable this diagnostic. pub(crate) noqa_edit: Option, } /// Describes a fix for `fixed_diagnostic` that may have quick fix /// edits available, `noqa` comment edits, or both. #[derive(Clone, Debug)] pub(crate) struct DiagnosticFix { /// The original diagnostic to be fixed pub(crate) fixed_diagnostic: lsp_types::Diagnostic, /// The message describing what the fix does. pub(crate) title: String, /// The NOQA code for the diagnostic. pub(crate) code: String, /// Edits to fix the diagnostic. If this is empty, a fix /// does not exist. pub(crate) edits: Vec, /// Possible edit to add a `noqa` comment which will disable this diagnostic. pub(crate) noqa_edit: Option, } /// A series of diagnostics across a single text document or an arbitrary number of notebook cells. pub(crate) type DiagnosticsMap = FxHashMap>; pub(crate) fn check( query: &DocumentQuery, encoding: PositionEncoding, show_syntax_errors: bool, ) -> DiagnosticsMap { let source_kind = query.make_source_kind(); let settings = query.settings(); let document_path = query.virtual_file_path(); // If the document is excluded, return an empty list of diagnostics. if is_document_excluded_for_linting( &document_path, &settings.file_resolver, &settings.linter, query.text_document_language_id(), ) { return DiagnosticsMap::default(); } let file_path = query.file_path(); let package = if let Some(file_path) = &file_path { detect_package_root( file_path .parent() .expect("a path to a document should have a parent path"), &settings.linter.namespace_packages, ) .map(PackageRoot::root) } else { None }; let source_type = query.source_type(); let target_version = settings.linter.resolve_target_version(&document_path); let parse_options = ParseOptions::from(source_type).with_target_version(target_version.parser_version()); // Parse once. let parsed = ruff_python_parser::parse_unchecked(source_kind.source_code(), parse_options) .try_into_module() .expect("PySourceType always parses to a ModModule"); // Map row and column locations to byte slices (lazily). let locator = Locator::new(source_kind.source_code()); // Detect the current code style (lazily). let stylist = Stylist::from_tokens(parsed.tokens(), locator.contents()); // Extra indices from the code. let indexer = Indexer::from_tokens(parsed.tokens(), locator.contents()); // Extract the `# noqa` and `# isort: skip` directives from the source. let directives = extract_directives(parsed.tokens(), Flags::all(), &locator, &indexer); // Generate checks. let diagnostics = check_path( &document_path, package, &locator, &stylist, &indexer, &directives, &settings.linter, flags::Noqa::Enabled, &source_kind, source_type, &parsed, target_version, ); let noqa_edits = generate_noqa_edits( &document_path, &diagnostics, &locator, indexer.comment_ranges(), &settings.linter.external, &directives.noqa_line_for, stylist.line_ending(), ); let mut diagnostics_map = DiagnosticsMap::default(); // Populates all relevant URLs with an empty diagnostic list. // This ensures that documents without diagnostics still get updated. if let Some(notebook) = query.as_notebook() { for url in notebook.urls() { diagnostics_map.entry(url.clone()).or_default(); } } else { diagnostics_map .entry(query.make_key().into_url()) .or_default(); } let lsp_diagnostics = diagnostics .into_iter() .zip(noqa_edits) .filter_map(|(message, noqa_edit)| { if message.is_invalid_syntax() && !show_syntax_errors { None } else { Some(to_lsp_diagnostic( &message, noqa_edit, &source_kind, locator.to_index(), encoding, )) } }); if let Some(notebook) = query.as_notebook() { for (index, diagnostic) in lsp_diagnostics { let Some(uri) = notebook.cell_uri_by_index(index) else { tracing::warn!("Unable to find notebook cell at index {index}."); continue; }; diagnostics_map .entry(uri.clone()) .or_default() .push(diagnostic); } } else { diagnostics_map .entry(query.make_key().into_url()) .or_default() .extend(lsp_diagnostics.map(|(_, diagnostic)| diagnostic)); } diagnostics_map } /// Converts LSP diagnostics to a list of `DiagnosticFix`es by deserializing associated data on each diagnostic. pub(crate) fn fixes_for_diagnostics( diagnostics: Vec, ) -> crate::Result> { diagnostics .into_iter() .filter(|diagnostic| diagnostic.source.as_deref() == Some(DIAGNOSTIC_NAME)) .map(move |mut diagnostic| { let Some(data) = diagnostic.data.take() else { return Ok(None); }; let fixed_diagnostic = diagnostic; let associated_data: crate::lint::AssociatedDiagnosticData = serde_json::from_value(data).map_err(|err| { anyhow::anyhow!("failed to deserialize diagnostic data: {err}") })?; Ok(Some(DiagnosticFix { fixed_diagnostic, code: associated_data.code, title: associated_data.title, noqa_edit: associated_data.noqa_edit, edits: associated_data.edits, })) }) .filter_map(crate::Result::transpose) .collect() } /// Generates an LSP diagnostic with an associated cell index for the diagnostic to go in. /// If the source kind is a text document, the cell index will always be `0`. fn to_lsp_diagnostic( diagnostic: &Diagnostic, noqa_edit: Option, source_kind: &SourceKind, index: &LineIndex, encoding: PositionEncoding, ) -> (usize, lsp_types::Diagnostic) { let diagnostic_range = diagnostic.range().unwrap_or_default(); let name = diagnostic.name(); let body = diagnostic.body().to_string(); let fix = diagnostic.fix(); let suggestion = diagnostic.first_help_text(); let code = diagnostic.secondary_code(); let fix = fix.and_then(|fix| fix.applies(Applicability::Unsafe).then_some(fix)); let data = (fix.is_some() || noqa_edit.is_some()) .then(|| { let code = code?.to_string(); let edits = fix .into_iter() .flat_map(Fix::edits) .map(|edit| lsp_types::TextEdit { range: diagnostic_edit_range(edit.range(), source_kind, index, encoding), new_text: edit.content().unwrap_or_default().to_string(), }) .collect(); let noqa_edit = noqa_edit.map(|noqa_edit| lsp_types::TextEdit { range: diagnostic_edit_range(noqa_edit.range(), source_kind, index, encoding), new_text: noqa_edit.into_content().unwrap_or_default().into_string(), }); serde_json::to_value(AssociatedDiagnosticData { title: suggestion.unwrap_or(name).to_string(), noqa_edit, edits, code, }) .ok() }) .flatten(); let range: lsp_types::Range; let cell: usize; if let Some(notebook_index) = source_kind.as_ipy_notebook().map(Notebook::index) { NotebookRange { cell, range } = diagnostic_range.to_notebook_range( source_kind.source_code(), index, notebook_index, encoding, ); } else { cell = usize::default(); range = diagnostic_range.to_range(source_kind.source_code(), index, encoding); } let (severity, tags, code) = if let Some(code) = code { let code = code.to_string(); ( Some(severity(&code)), tags(diagnostic), Some(lsp_types::NumberOrString::String(code)), ) } else { (None, None, None) }; ( cell, lsp_types::Diagnostic { range, severity, tags, code, code_description: diagnostic.to_ruff_url().and_then(|url| { Some(lsp_types::CodeDescription { href: lsp_types::Url::parse(&url).ok()?, }) }), source: Some(DIAGNOSTIC_NAME.into()), message: body, related_information: None, data, }, ) } fn diagnostic_edit_range( range: TextRange, source_kind: &SourceKind, index: &LineIndex, encoding: PositionEncoding, ) -> lsp_types::Range { if let Some(notebook_index) = source_kind.as_ipy_notebook().map(Notebook::index) { range .to_notebook_range(source_kind.source_code(), index, notebook_index, encoding) .range } else { range.to_range(source_kind.source_code(), index, encoding) } } fn severity(code: &str) -> lsp_types::DiagnosticSeverity { match code { // F821: undefined name // E902: IOError "F821" | "E902" => lsp_types::DiagnosticSeverity::ERROR, _ => lsp_types::DiagnosticSeverity::WARNING, } } fn tags(diagnostic: &Diagnostic) -> Option> { diagnostic.primary_tags().map(|tags| { tags.iter() .map(|tag| match tag { ruff_db::diagnostic::DiagnosticTag::Unnecessary => { lsp_types::DiagnosticTag::UNNECESSARY } ruff_db::diagnostic::DiagnosticTag::Deprecated => { lsp_types::DiagnosticTag::DEPRECATED } }) .collect() }) }