mirror of
https://github.com/astral-sh/ruff.git
synced 2025-09-30 13:51:16 +00:00
44fc87f491
<!-- Thank you for contributing to Ruff/ty! To help us out with reviewing, please consider the following: - Does this pull request include a summary of the change? (See below.) - Does this pull request include a descriptive title? (Please prefix with `[ty]` for ty pull requests.) - Does this pull request include references to any relevant issues? --> ## Summary Fixes #12734 I have started with simply checking if any arguments that are providing extra values to the log message are calls to `str` or `repr`, as suggested in the linked issue. There was a concern that this could cause false positives and the check should be more explicit. I am happy to look into that if I have some further examples to work with. If this is the accepted solution then there are more cases to add to the test and it should possibly also do test for the same behavior via the `extra` keyword. <!-- What's the purpose of the change? What does it do, and why? --> ## Test Plan I have added a new test case and python file to flake8_logging_format with examples of this anti-pattern. <!-- How was it tested? --> |
||
|---|---|---|
| .. | ||
| fixtures | ||
| package | ||
| project | ||
| __init__.py | ||
| disallowed_rule_names.txt | ||