ruff/crates/ruff_diagnostics at david/allow-function-redefiniton - mirrors/ruff

mirror of https://github.com/astral-sh/ruff.git synced 2025-08-04 02:38:25 +00:00

History

Brent Westbrook e2c5b83fe1 Inline `DiagnosticKind` into other diagnostic types (#18074 ) ## Summary This PR deletes the `DiagnosticKind` type by inlining its three fields (`name`, `body`, and `suggestion`) into three other diagnostic types: `Diagnostic`, `DiagnosticMessage`, and `CacheMessage`. Instead of deferring to an internal `DiagnosticKind`, both `Diagnostic` and `DiagnosticMessage` now have their own macro-generated `AsRule` implementations. This should make both https://github.com/astral-sh/ruff/pull/18051 and another follow-up PR changing the type of `name` on `CacheMessage` easier since its type will be able to change separately from `Diagnostic` and `DiagnosticMessage`. ## Test Plan Existing tests	2025-05-15 10:27:21 -04:00
..
src	Inline `DiagnosticKind` into other diagnostic types (#18074 )	2025-05-15 10:27:21 -04:00
Cargo.toml	Move sub-crates to workspace dependencies (#11407 )	2024-05-13 14:37:50 +00:00

Brent Westbrook e2c5b83fe1

Inline DiagnosticKind into other diagnostic types (#18074 )

## Summary

This PR deletes the `DiagnosticKind` type by inlining its three fields
(`name`, `body`, and `suggestion`) into three other diagnostic types:
`Diagnostic`, `DiagnosticMessage`, and `CacheMessage`.

Instead of deferring to an internal `DiagnosticKind`, both `Diagnostic`
and `DiagnosticMessage` now have their own macro-generated `AsRule`
implementations.

This should make both https://github.com/astral-sh/ruff/pull/18051 and
another follow-up PR changing the type of `name` on `CacheMessage`
easier since its type will be able to change separately from
`Diagnostic` and `DiagnosticMessage`.

## Test Plan

Existing tests

2025-05-15 10:27:21 -04:00

src Inline DiagnosticKind into other diagnostic types (#18074 ) 2025-05-15 10:27:21 -04:00

Cargo.toml Move sub-crates to workspace dependencies (#11407 ) 2024-05-13 14:37:50 +00:00