ruff/crates/ruff_graph at dcreager/nested-generics - mirrors/ruff

mirror of https://github.com/astral-sh/ruff.git synced 2025-07-09 22:25:09 +00:00

History

Brent Westbrook 9c47b6dbb0 [red-knot] Detect version-related syntax errors (#16379 ) ## Summary This PR extends version-related syntax error detection to red-knot. The main changes here are: 1. Passing `ParseOptions` specifying a `PythonVersion` to parser calls 2. Adding a `python_version` method to the `Db` trait to make this possible 3. Converting `UnsupportedSyntaxError`s to `Diagnostic`s 4. Updating existing mdtests to avoid unrelated syntax errors My initial draft of (1) and (2) in #16090 instead tried passing a `PythonVersion` down to every parser call, but @MichaReiser suggested the `Db` approach instead [here](https://github.com/astral-sh/ruff/pull/16090#discussion_r1969198407), and I think it turned out much nicer. All of the new `python_version` methods look like this: ```rust fn python_version(&self) -> ruff_python_ast::PythonVersion { Program::get(self).python_version(self) } ``` with the exception of the `TestDb` in `ruff_db`, which hard-codes `PythonVersion::latest()`. ## Test Plan Existing mdtests, plus a new mdtest to see at least one of the new diagnostics.	2025-04-17 14:00:30 -04:00
..
src	[red-knot] Detect version-related syntax errors (#16379 )	2025-04-17 14:00:30 -04:00
Cargo.toml	Bump MSRV to Rust 1.80 (#13826 )	2024-10-20 10:55:36 +02:00

Brent Westbrook 9c47b6dbb0

[red-knot] Detect version-related syntax errors (#16379 )

## Summary
This PR extends version-related syntax error detection to red-knot. The
main changes here are:

1. Passing `ParseOptions` specifying a `PythonVersion` to parser calls
2. Adding a `python_version` method to the `Db` trait to make this
possible
3. Converting `UnsupportedSyntaxError`s to `Diagnostic`s
4. Updating existing mdtests  to avoid unrelated syntax errors

My initial draft of (1) and (2) in #16090 instead tried passing a
`PythonVersion` down to every parser call, but @MichaReiser suggested
the `Db` approach instead
[here](https://github.com/astral-sh/ruff/pull/16090#discussion_r1969198407),
and I think it turned out much nicer.

All of the new `python_version` methods look like this:

```rust
fn python_version(&self) -> ruff_python_ast::PythonVersion {
    Program::get(self).python_version(self)
}
```

with the exception of the `TestDb` in `ruff_db`, which hard-codes
`PythonVersion::latest()`.

## Test Plan

Existing mdtests, plus a new mdtest to see at least one of the new
diagnostics.

2025-04-17 14:00:30 -04:00

src

[red-knot] Detect version-related syntax errors (#16379 )

2025-04-17 14:00:30 -04:00

Cargo.toml

Bump MSRV to Rust 1.80 (#13826 )

2024-10-20 10:55:36 +02:00