ruff/crates/ty/tests at dcreager/ordering-bug - mirrors/ruff

mirror of https://github.com/astral-sh/ruff.git synced 2025-11-17 19:27:11 +00:00

History

Alex Waygood d63b4b0383 [ty] Improve diagnostic range for `non-subscriptable` diagnostics (#21461 ) ## Summary Currently our diagnostic only covers the range of the thing being subscripted: <img width="1702" height="312" alt="image" src="https://github.com/user-attachments/assets/7e630431-e846-46ca-93c1-139f11aaba11" /> But it should probably cover the _whole_ subscript expression (arguably the more "incorrect" bit is the `["foo"]` part of this expression, not the `x` part of this expression!) ## Test Plan Added a snapshot Co-authored-by: Brent Westbrook <36778786+ntBre@users.noreply.github.com>	2025-11-14 21:15:14 +00:00
..
cli	[ty] Improve diagnostic range for `non-subscriptable` diagnostics (#21461 )	2025-11-14 21:15:14 +00:00
file_watching.rs	[ty] Improve error messages for unresolved attribute diagnostics (#20963 )	2025-10-19 10:58:25 +01:00

[ty] Improve diagnostic range for non-subscriptable diagnostics (#21461 )

## Summary

Currently our diagnostic only covers the range of the thing being
subscripted:

<img width="1702" height="312" alt="image"
src="https://github.com/user-attachments/assets/7e630431-e846-46ca-93c1-139f11aaba11"
/>

But it should probably cover the _whole_ subscript expression (arguably
the more "incorrect" bit is the `["foo"]` part of this expression, not
the `x` part of this expression!)

## Test Plan

Added a snapshot

Co-authored-by: Brent Westbrook
<36778786+ntBre@users.noreply.github.com>

2025-11-14 21:15:14 +00:00

cli [ty] Improve diagnostic range for non-subscriptable diagnostics (#21461 ) 2025-11-14 21:15:14 +00:00

file_watching.rs [ty] Improve error messages for unresolved attribute diagnostics (#20963 ) 2025-10-19 10:58:25 +01:00