Dhruv Manilawala 978909fcf4 Raise syntax error for unparenthesized generator expr in multi-argument call (#12445) ... ## Summary This PR fixes a bug to raise a syntax error when an unparenthesized generator expression is used as an argument to a call when there are more than one argument. For reference, the grammar is: ``` primary: | ... | primary genexp | primary '(' [arguments] ')' | ... genexp: | '(' ( assignment_expression | expression !':=') for_if_clauses ')' ``` The `genexp` requires the parenthesis as mentioned in the grammar. So, the grammar for a call expression is either a name followed by a generator expression or a name followed by a list of argument. In the former case, the parenthesis are excluded because the generator expression provides them while in the later case, the parenthesis are explicitly provided for a list of arguments which means that the generator expression requires it's own parenthesis. This was discovered in https://github.com/astral-sh/ruff/issues/12420. ## Test Plan Add test cases for valid and invalid syntax. Make sure that the parser from CPython also raises this at the parsing step: ```console $ python3.13 -m ast parser/_.py File "parser/_.py", line 1 total(1, 2, x for x in range(5), 6) ^^^^^^^^^^^^^^^^^^^ SyntaxError: Generator expression must be parenthesized $ python3.13 -m ast parser/_.py File "parser/_.py", line 1 sum(x for x in range(10), 10) ^^^^^^^^^^^^^^^^^^^^ SyntaxError: Generator expression must be parenthesized ```		2024-07-22 14:44:20 +05:30
..
ambiguous_lpar_with_items_binary_expr.py	Consider binary expr for parenthesized with items parsing (#11012)	2024-04-18 21:39:30 +05:30
ambiguous_lpar_with_items_if_expr.py	Consider if expression for parenthesized with items parsing (#11010)	2024-04-18 14:30:15 +00:00
ann_assign_stmt_simple_target.py	Replace LALRPOP parser with hand-written parser (#10036)	2024-04-18 17:57:39 +05:30
args_unparenthesized_generator.py	Raise syntax error for unparenthesized generator expr in multi-argument call (#12445)	2024-07-22 14:44:20 +05:30
assign_targets_terminator.py	Replace LALRPOP parser with hand-written parser (#10036)	2024-04-18 17:57:39 +05:30
async_for_statement.py	Replace LALRPOP parser with hand-written parser (#10036)	2024-04-18 17:57:39 +05:30
async_function_definition.py	Replace LALRPOP parser with hand-written parser (#10036)	2024-04-18 17:57:39 +05:30
async_with_statement.py	Replace LALRPOP parser with hand-written parser (#10036)	2024-04-18 17:57:39 +05:30
class_def_arguments.py	Replace LALRPOP parser with hand-written parser (#10036)	2024-04-18 17:57:39 +05:30
comma_separated_regular_list_terminator.py	Implement re-lexing logic for better error recovery (#11845)	2024-06-17 06:47:00 +00:00
decorator_async_function.py	Replace LALRPOP parser with hand-written parser (#10036)	2024-04-18 17:57:39 +05:30
del_targets_terminator.py	Replace LALRPOP parser with hand-written parser (#10036)	2024-04-18 17:57:39 +05:30
dotted_name_normalized_spaces.py	Replace LALRPOP parser with hand-written parser (#10036)	2024-04-18 17:57:39 +05:30
except_stmt_as_name_soft_keyword.py	Maintain synchronicity between the lexer and the parser (#11457)	2024-06-03 18:23:50 +05:30
for_in_target_valid_expr.py	Add ExpressionContext for expression parsing (#11055)	2024-04-23 04:19:05 +00:00
from_import_no_space.py	Replace LALRPOP parser with hand-written parser (#10036)	2024-04-18 17:57:39 +05:30
from_import_soft_keyword_module_name.py	Maintain synchronicity between the lexer and the parser (#11457)	2024-06-03 18:23:50 +05:30
from_import_stmt_terminator.py	Replace LALRPOP parser with hand-written parser (#10036)	2024-04-18 17:57:39 +05:30
fstring_format_spec_terminator.py	Replace LALRPOP parser with hand-written parser (#10036)	2024-04-18 17:57:39 +05:30
function_def_parameter_range.py	Replace LALRPOP parser with hand-written parser (#10036)	2024-04-18 17:57:39 +05:30
function_def_parenthesized_return_types.py	Replace LALRPOP parser with hand-written parser (#10036)	2024-04-18 17:57:39 +05:30
function_def_valid_return_expr.py	Replace LALRPOP parser with hand-written parser (#10036)	2024-04-18 17:57:39 +05:30
global_stmt.py	Replace LALRPOP parser with hand-written parser (#10036)	2024-04-18 17:57:39 +05:30
import_as_name_soft_keyword.py	Maintain synchronicity between the lexer and the parser (#11457)	2024-06-03 18:23:50 +05:30
import_stmt_terminator.py	Replace LALRPOP parser with hand-written parser (#10036)	2024-04-18 17:57:39 +05:30
lambda_with_no_parameters.py	Replace LALRPOP parser with hand-written parser (#10036)	2024-04-18 17:57:39 +05:30
lambda_with_valid_body.py	Replace LALRPOP parser with hand-written parser (#10036)	2024-04-18 17:57:39 +05:30
match_as_pattern.py	Replace LALRPOP parser with hand-written parser (#10036)	2024-04-18 17:57:39 +05:30
match_as_pattern_soft_keyword.py	Maintain synchronicity between the lexer and the parser (#11457)	2024-06-03 18:23:50 +05:30
match_attr_pattern_soft_keyword.py	Maintain synchronicity between the lexer and the parser (#11457)	2024-06-03 18:23:50 +05:30
match_classify_as_identifier_1.py	Maintain synchronicity between the lexer and the parser (#11457)	2024-06-03 18:23:50 +05:30
match_classify_as_identifier_2.py	Maintain synchronicity between the lexer and the parser (#11457)	2024-06-03 18:23:50 +05:30
match_classify_as_keyword_1.py	Maintain synchronicity between the lexer and the parser (#11457)	2024-06-03 18:23:50 +05:30
match_classify_as_keyword_2.py	Maintain synchronicity between the lexer and the parser (#11457)	2024-06-03 18:23:50 +05:30
match_classify_as_keyword_or_identifier.py	Maintain synchronicity between the lexer and the parser (#11457)	2024-06-03 18:23:50 +05:30
match_sequence_pattern_parentheses_terminator.py	Replace LALRPOP parser with hand-written parser (#10036)	2024-04-18 17:57:39 +05:30
match_sequence_pattern_terminator.py	Replace LALRPOP parser with hand-written parser (#10036)	2024-04-18 17:57:39 +05:30
match_stmt_subject_expr.py	Replace LALRPOP parser with hand-written parser (#10036)	2024-04-18 17:57:39 +05:30
match_stmt_valid_guard_expr.py	Replace LALRPOP parser with hand-written parser (#10036)	2024-04-18 17:57:39 +05:30
nonlocal_stmt.py	Replace LALRPOP parser with hand-written parser (#10036)	2024-04-18 17:57:39 +05:30
param_with_annotation.py	Replace LALRPOP parser with hand-written parser (#10036)	2024-04-18 17:57:39 +05:30
param_with_default.py	Replace LALRPOP parser with hand-written parser (#10036)	2024-04-18 17:57:39 +05:30
param_with_star_annotation.py	Replace LALRPOP parser with hand-written parser (#10036)	2024-04-18 17:57:39 +05:30
params_non_default_after_star.py	Replace LALRPOP parser with hand-written parser (#10036)	2024-04-18 17:57:39 +05:30
params_seen_keyword_only_param_after_star.py	Replace LALRPOP parser with hand-written parser (#10036)	2024-04-18 17:57:39 +05:30
simple_stmts_in_block.py	Replace LALRPOP parser with hand-written parser (#10036)	2024-04-18 17:57:39 +05:30
simple_stmts_with_semicolons.py	Replace LALRPOP parser with hand-written parser (#10036)	2024-04-18 17:57:39 +05:30
type_param_param_spec.py	Add support for PEP 696 syntax (#11120)	2024-04-26 09:47:29 +02:00
type_param_type_var.py	Add support for PEP 696 syntax (#11120)	2024-04-26 09:47:29 +02:00
type_param_type_var_tuple.py	Add support for PEP 696 syntax (#11120)	2024-04-26 09:47:29 +02:00