ruff/crates/ruff_python_ast
Charlie Marsh 5df0326bc8
Treat parameters-with-newline as empty in function formatting (#7550)
## Summary

If a function has no parameters (and no comments within the parameters'
`()`), we're supposed to wrap the return annotation _whenever_ it
breaks. However, our `empty_parameters` test didn't properly account for
the case in which the parameters include a newline (but no other
content), like:

```python
def get_dashboards_hierarchy(
) -> Dict[Type['BaseDashboard'], List[Type['BaseDashboard']]]:
    """Get hierarchy of dashboards classes.

    Returns:
        Dict of dashboards classes.
    """
    dashboards_hierarchy = {}
```

This PR fixes that detection. Instead of lexing, it now checks if the
parameters itself is empty (or if it contains comments).

Closes https://github.com/astral-sh/ruff/issues/7457.
2023-09-20 16:20:22 -04:00
..
src Treat parameters-with-newline as empty in function formatting (#7550) 2023-09-20 16:20:22 -04:00
tests Use CommentRanges in backwards lexing (#7360) 2023-09-16 03:21:45 +00:00
Cargo.toml Introduce ArgOrKeyword to keep call parameter order (#7302) 2023-09-13 08:45:46 +00:00