mirror of
https://github.com/astral-sh/ruff.git
synced 2025-10-03 15:14:42 +00:00
5e943d3539
This change rejiggers how we register globs for file watching with the LSP client. Previously, we registered a few globs like `**/*.py`, `**/pyproject.toml` and more. There were two problems with this approach. Firstly, it only watches files within the project root. Search paths may be outside the project root. Such as virtualenv directory. Secondly, there is variation on how tools interact with virtual environments. In the case of uv, depending on its link mode, we might not get any file change notifications after running `uv add foo` or `uv remove foo`. To remedy this, we instead just list for file change notifications on all files for all search paths. This simplifies the globs we use, but does potentially increase the number of notifications we'll get. However, given the somewhat simplistic interface supported by the LSP protocol, I think this is unavoidable (unless we used our own file watcher, which has its own considerably downsides). Moreover, this is seemingly consistent with how `ty check --watch` works. This also required moving file watcher registration to *after* workspaces are initialized, or else we don't know what the right search paths are. This change is in service of #19883, which in order for cache invalidation to work right, the LSP client needs to send notifications whenever a dependency is added or removed. This change should make that possible. I tried this patch with #19883 in addition to my work to activate Salsa caching, and everything seems to work as I'd expect. That is, completions no longer show stale results after a dependency is added or removed. |
||
|---|---|---|
| .. | ||
| ruff | ||
| ruff_annotate_snippets | ||
| ruff_benchmark | ||
| ruff_cache | ||
| ruff_db | ||
| ruff_dev | ||
| ruff_diagnostics | ||
| ruff_formatter | ||
| ruff_graph | ||
| ruff_index | ||
| ruff_linter | ||
| ruff_macros | ||
| ruff_memory_usage | ||
| ruff_notebook | ||
| ruff_options_metadata | ||
| ruff_python_ast | ||
| ruff_python_ast_integration_tests | ||
| ruff_python_codegen | ||
| ruff_python_formatter | ||
| ruff_python_index | ||
| ruff_python_literal | ||
| ruff_python_parser | ||
| ruff_python_semantic | ||
| ruff_python_stdlib | ||
| ruff_python_trivia | ||
| ruff_python_trivia_integration_tests | ||
| ruff_server | ||
| ruff_source_file | ||
| ruff_text_size | ||
| ruff_wasm | ||
| ruff_workspace | ||
| ty | ||
| ty_combine | ||
| ty_ide | ||
| ty_project | ||
| ty_python_semantic | ||
| ty_server | ||
| ty_static | ||
| ty_test | ||
| ty_vendored | ||
| ty_wasm | ||