Brent Westbrook 6d3b1d13d6 [pylint] Detect global declarations in module scope (PLE0118) (#17411) ... Summary -- While going through the syntax errors in [this comment], I was surprised to see the error `name 'x' is assigned to before global declaration`, which corresponds to [load-before-global-declaration (PLE0118)] and has also been reimplemented as a syntax error (#17135). However, it looks like neither of the implementations consider `global` declarations in the top-level module scope, which is a syntax error in CPython: ```python # try.py x = None global x ``` ```shell > python -m compileall -f try.py Compiling 'try.py'... *** File "try.py", line 2 global x ^^^^^^^^ SyntaxError: name 'x' is assigned to before global declaration ``` I'm not sure this is the best or most elegant solution, but it was a quick fix that passed all of our tests. Test Plan -- New PLE0118 test case. [this comment]: https://github.com/astral-sh/ruff/issues/7633#issuecomment-1740424031 [load-before-global-declaration (PLE0118)]: https://docs.astral.sh/ruff/rules/load-before-global-declaration/#load-before-global-declaration-ple0118		2025-04-25 08:37:16 -04:00
..
resources/test/fixtures/cfg	Control flow: return and raise (#17121)	2025-04-03 08:30:29 -05:00
src	[pylint] Detect global declarations in module scope (PLE0118) (#17411)	2025-04-25 08:37:16 -04:00
Cargo.toml	Control flow graph: setup (#17064)	2025-04-01 05:53:42 -05:00