mirror of
https://github.com/astral-sh/ruff.git
synced 2025-11-25 22:29:02 +00:00
8230b79829
Some checks are pending
CI / mkdocs (push) Waiting to run
CI / Determine changes (push) Waiting to run
CI / cargo fmt (push) Waiting to run
CI / cargo clippy (push) Blocked by required conditions
CI / cargo test (linux) (push) Blocked by required conditions
CI / cargo test (linux, release) (push) Blocked by required conditions
CI / cargo test (windows) (push) Blocked by required conditions
CI / cargo test (wasm) (push) Blocked by required conditions
CI / cargo build (release) (push) Waiting to run
CI / formatter instabilities and black similarity (push) Blocked by required conditions
CI / cargo build (msrv) (push) Blocked by required conditions
CI / cargo fuzz build (push) Blocked by required conditions
CI / fuzz parser (push) Blocked by required conditions
CI / test scripts (push) Blocked by required conditions
CI / test ruff-lsp (push) Blocked by required conditions
CI / ecosystem (push) Blocked by required conditions
CI / Fuzz for new ty panics (push) Blocked by required conditions
CI / cargo shear (push) Blocked by required conditions
CI / python package (push) Waiting to run
CI / pre-commit (push) Waiting to run
CI / check playground (push) Blocked by required conditions
CI / benchmarks-instrumented (push) Blocked by required conditions
CI / benchmarks-walltime (push) Blocked by required conditions
## Summary This is a follow-up to https://github.com/astral-sh/ruff/pull/19415#discussion_r2263456740 to remove some unused code. As Micha noticed, `GroupedEmitter::with_show_source` was only used in local unit tests[^1] and was safe to remove. This allowed deleting `MessageCodeFrame` and a lot more helper code previously shared with the `full` output format. I also moved some other code from `text.rs` and `message/mod.rs` into `grouped.rs` that is now only used for the `grouped` format. With a little refactoring of the `concise` rendering logic in `ruff_db`, we could probably remove `RuleCodeAndBody` too. The only difference I see from the `concise` output is whether we print the filename next to the row and column or not: ```shell > ruff check --output-format concise try.py:1:8: F401 [*] `math` imported but unused > ruff check --output-format grouped try.py: 1:8 F401 [*] `math` imported but unused ``` But I didn't try to do that here. ## Test Plan Existing tests, with the source code no longer displayed. I also deleted one test, as it was now a duplicate of the `default` test. [^1]: "Local unit tests" as opposed to all of our linter snapshot tests, as is the case for `TextEmitter::with_show_fix_diff`. We also want to expose that to users eventually (https://github.com/astral-sh/ruff/issues/7352), which I don't believe is the case for the `grouped` format. |
||
|---|---|---|
| .. | ||
| resources | ||
| src | ||
| Cargo.toml | ||