mirror of
https://github.com/astral-sh/ruff.git
synced 2025-10-07 00:50:37 +00:00
a6d892b1f4
## Summary Charlie can probably explain this better than I but it turns out, `CallPath` is used for two different things: * To represent unqualified names like `version` where `version` can be a local variable or imported (e.g. `from sys import version` where the full qualified name is `sys.version`) * To represent resolved, full qualified names This PR splits `CallPath` into two types to make this destinction clear. > Note: I haven't renamed all `call_path` variables to `qualified_name` or `unqualified_name`. I can do that if that's welcomed but I first want to get feedback on the approach and naming overall. ## Test Plan `cargo test`
104 lines
3.7 KiB
Rust
104 lines
3.7 KiB
Rust
use ruff_python_ast::helpers::map_subscript;
|
|
use ruff_python_ast::{self as ast, Expr, Stmt};
|
|
|
|
use crate::SemanticModel;
|
|
|
|
/// Returns `true` if a [`Stmt`] is a `sys.path` modification, as in:
|
|
/// ```python
|
|
/// import sys
|
|
///
|
|
/// sys.path.append("../")
|
|
/// ```
|
|
pub fn is_sys_path_modification(stmt: &Stmt, semantic: &SemanticModel) -> bool {
|
|
let Stmt::Expr(ast::StmtExpr { value, range: _ }) = stmt else {
|
|
return false;
|
|
};
|
|
let Expr::Call(ast::ExprCall { func, .. }) = value.as_ref() else {
|
|
return false;
|
|
};
|
|
semantic
|
|
.resolve_qualified_name(func.as_ref())
|
|
.is_some_and(|qualified_name| {
|
|
matches!(
|
|
qualified_name.segments(),
|
|
[
|
|
"sys",
|
|
"path",
|
|
"append"
|
|
| "insert"
|
|
| "extend"
|
|
| "remove"
|
|
| "pop"
|
|
| "clear"
|
|
| "reverse"
|
|
| "sort"
|
|
]
|
|
)
|
|
})
|
|
}
|
|
|
|
/// Returns `true` if a [`Stmt`] is an `os.environ` modification, as in:
|
|
/// ```python
|
|
/// import os
|
|
///
|
|
/// os.environ["CUDA_VISIBLE_DEVICES"] = "4"
|
|
/// ```
|
|
pub fn is_os_environ_modification(stmt: &Stmt, semantic: &SemanticModel) -> bool {
|
|
match stmt {
|
|
Stmt::Expr(ast::StmtExpr { value, .. }) => match value.as_ref() {
|
|
Expr::Call(ast::ExprCall { func, .. }) => semantic
|
|
.resolve_qualified_name(func.as_ref())
|
|
.is_some_and(|qualified_name| {
|
|
matches!(
|
|
qualified_name.segments(),
|
|
["os", "putenv" | "unsetenv"]
|
|
| [
|
|
"os",
|
|
"environ",
|
|
"update" | "pop" | "clear" | "setdefault" | "popitem"
|
|
]
|
|
)
|
|
}),
|
|
_ => false,
|
|
},
|
|
Stmt::Delete(ast::StmtDelete { targets, .. }) => targets.iter().any(|target| {
|
|
semantic
|
|
.resolve_qualified_name(map_subscript(target))
|
|
.is_some_and(|qualified_name| {
|
|
matches!(qualified_name.segments(), ["os", "environ"])
|
|
})
|
|
}),
|
|
Stmt::Assign(ast::StmtAssign { targets, .. }) => targets.iter().any(|target| {
|
|
semantic
|
|
.resolve_qualified_name(map_subscript(target))
|
|
.is_some_and(|qualified_name| {
|
|
matches!(qualified_name.segments(), ["os", "environ"])
|
|
})
|
|
}),
|
|
Stmt::AnnAssign(ast::StmtAnnAssign { target, .. }) => semantic
|
|
.resolve_qualified_name(map_subscript(target))
|
|
.is_some_and(|qualified_name| matches!(qualified_name.segments(), ["os", "environ"])),
|
|
Stmt::AugAssign(ast::StmtAugAssign { target, .. }) => semantic
|
|
.resolve_qualified_name(map_subscript(target))
|
|
.is_some_and(|qualified_name| matches!(qualified_name.segments(), ["os", "environ"])),
|
|
_ => false,
|
|
}
|
|
}
|
|
|
|
/// Returns `true` if a [`Stmt`] is a `matplotlib.use` activation, as in:
|
|
/// ```python
|
|
/// import matplotlib
|
|
///
|
|
/// matplotlib.use("Agg")
|
|
/// ```
|
|
pub fn is_matplotlib_activation(stmt: &Stmt, semantic: &SemanticModel) -> bool {
|
|
let Stmt::Expr(ast::StmtExpr { value, range: _ }) = stmt else {
|
|
return false;
|
|
};
|
|
let Expr::Call(ast::ExprCall { func, .. }) = value.as_ref() else {
|
|
return false;
|
|
};
|
|
semantic
|
|
.resolve_qualified_name(func.as_ref())
|
|
.is_some_and(|qualified_name| matches!(qualified_name.segments(), ["matplotlib", "use"]))
|
|
}
|