konsti 90ba40c23c Fix zulip unstable formatting with end-of-line comments (#6386) ... ## Bug Given ```python x = () - (# ) ``` the comment is a dangling comment of the empty tuple. This is an end-of-line comment so it may move after the expression. It still expands the parent, so the operator breaks: ```python x = ( () - () # ) ``` In the next formatting pass, the comment is not a trailing tuple but a trailing bin op comment, so the bin op doesn't break anymore. The comment again expands the parent, so we still add the superfluous parentheses ```python x = ( () - () # ) ``` ## Fix The new formatting is to keep the comment on the empty tuple. This is a log uglier and again has additional outer parentheses, but it's stable: ```python x = ( () - ( # ) ) ``` ## Alternatives Black formats all the examples above as ```python x = () - () # ``` which i find better. I would be happy about any suggestions for better solutions than the current one. I'd mainly need a workaround for expand parent having an effect on the bin op instead of first moving the comment to the end and then applying expand parent to the assign statement.		2023-08-08 09:15:35 +00:00
..
snapshots	Fix zulip unstable formatting with end-of-line comments (#6386)	2023-08-08 09:15:35 +00:00
fixtures.rs	Formatter: Add SourceType to context to enable special formatting for stub files (#6331)	2023-08-04 11:52:26 +00:00