mirror of
https://github.com/astral-sh/ruff.git
synced 2025-10-03 15:14:42 +00:00
92ecfc908b
## Summary While adding semantic error support to red-knot, I noticed duplicate diagnostics for code like this: ```py # error: [invalid-syntax] "cannot use an asynchronous comprehension outside of an asynchronous function on Python 3.9 (syntax was added in 3.11)" # error: [invalid-syntax] "`asynchronous comprehension` outside of an asynchronous function" [reveal_type(x) async for x in AsyncIterable()] ``` Beyond the duplication, the first error message doesn't make much sense because this syntax is _not_ allowed on Python 3.11 either. To fix this, this PR renames the `async-comprehension-outside-async-function` semantic syntax error to `async-comprehension-in-sync-comprehension` and fixes the rule to avoid applying outside of sync comprehensions at all. ## Test Plan New linter test demonstrating the false positive. The mdtests from my red-knot PR also reflect this change. |
||
|---|---|---|
| .. | ||
| checkers | ||
| comments | ||
| cst | ||
| docstrings | ||
| fix | ||
| importer | ||
| message | ||
| registry | ||
| rules | ||
| settings | ||
| snapshots | ||
| codes.rs | ||
| directives.rs | ||
| doc_lines.rs | ||
| fs.rs | ||
| lib.rs | ||
| line_width.rs | ||
| linter.rs | ||
| locator.rs | ||
| logging.rs | ||
| noqa.rs | ||
| package.rs | ||
| packaging.rs | ||
| pyproject_toml.rs | ||
| registry.rs | ||
| renamer.rs | ||
| rule_redirects.rs | ||
| rule_selector.rs | ||
| source_kind.rs | ||
| test.rs | ||
| text_helpers.rs | ||
| upstream_categories.rs | ||