Dhruv Manilawala 97ae617fac Introduce LiteralExpressionRef for all literals (#8339) ... ## Summary This PR adds a new `LiteralExpressionRef` which wraps all of the literal expression nodes in a single enum. This allows for a narrow type when working exclusively with a literal node. Additionally, it also implements a `Expr::as_literal_expr` method to return the new enum if the expression is indeed a literal one. A few rules have been updated to account for the new enum: 1. `redundant_literal_union` 2. `if_else_block_instead_of_dict_lookup` 3. `magic_value_comparison` To account for the change in (2), a new `ComparableLiteral` has been added which can be constructed from the new enum (`ComparableLiteral::from(<LiteralExpressionRef>)`). ### Open Questions 1. The new `ComparableLiteral` can be exclusively used via the `LiteralExpressionRef` enum. Should we remove all of the literal variants from `ComparableExpr` and instead have a single `ComparableExpr::Literal(ComparableLiteral)` variant instead? ## Test Plan `cargo test`		2023-10-31 12:56:11 +00:00
..
src	Introduce LiteralExpressionRef for all literals (#8339)	2023-10-31 12:56:11 +00:00
tests	Split Constant to individual literal nodes (#8064)	2023-10-30 12:13:23 +05:30
Cargo.toml	Implement our own small-integer optimization (#7584)	2023-09-25 15:13:21 +00:00