mirror of
https://github.com/astral-sh/ruff.git
synced 2025-10-08 01:20:29 +00:00
5a876ed25e
Some checks are pending
CI / Determine changes (push) Waiting to run
CI / cargo fmt (push) Waiting to run
CI / cargo clippy (push) Blocked by required conditions
CI / cargo test (linux) (push) Blocked by required conditions
CI / cargo test (linux, release) (push) Blocked by required conditions
CI / cargo test (windows) (push) Blocked by required conditions
CI / cargo test (wasm) (push) Blocked by required conditions
CI / cargo build (release) (push) Waiting to run
CI / cargo build (msrv) (push) Blocked by required conditions
CI / cargo fuzz build (push) Blocked by required conditions
CI / fuzz parser (push) Blocked by required conditions
CI / test scripts (push) Blocked by required conditions
CI / ecosystem (push) Blocked by required conditions
CI / cargo shear (push) Blocked by required conditions
CI / python package (push) Waiting to run
CI / pre-commit (push) Waiting to run
CI / mkdocs (push) Waiting to run
CI / formatter instabilities and black similarity (push) Blocked by required conditions
CI / test ruff-lsp (push) Blocked by required conditions
CI / check playground (push) Blocked by required conditions
CI / benchmarks (push) Blocked by required conditions
[Knot Playground] Release / publish (push) Waiting to run
## Summary I don't remember exactly when we made `Identifier` a node but it is now considered a node (it implements `AnyNodeRef`, it has a range). However, we never updated the `SourceOrderVisitor` to visit identifiers because we never had a use case for it and visiting new nodes can change how the formatter associates comments (breaking change!). This PR updates the `SourceOrderVisitor` to visit identifiers and changes the formatter comment visitor to skip identifiers (updating the visitor might be desired because it could help simplifying some comment placement logic but this is out of scope for this PR). ## Test Plan Tests, updated snapshot tests |
||
|---|---|---|
| .. | ||
| source_order__bytes_literals.snap | ||
| source_order__class_type_parameters.snap | ||
| source_order__compare.snap | ||
| source_order__decorators.snap | ||
| source_order__dict_comprehension.snap | ||
| source_order__f_strings.snap | ||
| source_order__function_arguments.snap | ||
| source_order__function_positional_only_with_default.snap | ||
| source_order__function_type_parameters.snap | ||
| source_order__list_comprehension.snap | ||
| source_order__match_class_pattern.snap | ||
| source_order__set_comprehension.snap | ||
| source_order__string_literals.snap | ||
| source_order__type_aliases.snap | ||
| visitor__bytes_literals.snap | ||
| visitor__class_type_parameters.snap | ||
| visitor__compare.snap | ||
| visitor__decorators.snap | ||
| visitor__dict_comprehension.snap | ||
| visitor__f_strings.snap | ||
| visitor__function_arguments.snap | ||
| visitor__function_positional_only_with_default.snap | ||
| visitor__function_type_parameters.snap | ||
| visitor__list_comprehension.snap | ||
| visitor__match_class_pattern.snap | ||
| visitor__set_comprehension.snap | ||
| visitor__string_literals.snap | ||
| visitor__type_aliases.snap | ||