ruff/crates/red_knot_python_semantic/resources at f85ea1bf460d1c1aa11b99aa7aa72789e80f6ad8 - mirrors/ruff

mirror of https://github.com/astral-sh/ruff.git synced 2025-08-19 01:50:38 +00:00

History

Alex Waygood f85ea1bf46 [red-knot] Ensure differently ordered unions and intersections are understood as equivalent even inside arbitrarily nested tuples (#15740 ) ## Summary On `main`, red-knot: - Considers `P \| Q` equivalent to `Q \| P` - Considered `tuple[P \| Q]` equivalent to `tuple[Q \| P]` - Considers `tuple[P \| tuple[P \| Q]]` equivalent to `tuple[tuple[Q \| P] \| P]` - ‼️ Does _not_ consider `tuple[tuple[P \| Q]]` equivalent to `tuple[tuple[Q \| P]]` The key difference for the last one of these is that the union appears inside a tuple that is directly nested inside another tuple. This PR fixes this so that differently ordered unions are considered equivalent even when they appear inside arbitrarily nested tuple types. ## Test Plan - Added mdtests that fails on `main` - Checked that all property tests continue to pass with this PR	2025-01-25 16:39:07 +00:00
..
mdtest	[red-knot] Ensure differently ordered unions and intersections are understood as equivalent even inside arbitrarily nested tuples (#15740 )	2025-01-25 16:39:07 +00:00
README.md

[red-knot] Ensure differently ordered unions and intersections are understood as equivalent even inside arbitrarily nested tuples (#15740 )

## Summary

On `main`, red-knot:
- Considers `P | Q` equivalent to `Q | P`
- Considered `tuple[P | Q]` equivalent to `tuple[Q | P]`
- Considers `tuple[P | tuple[P | Q]]` equivalent to `tuple[tuple[Q | P]
| P]`
- ‼️ Does _not_ consider `tuple[tuple[P | Q]]` equivalent to
`tuple[tuple[Q | P]]`

The key difference for the last one of these is that the union appears
inside a tuple that is directly nested inside another tuple.

This PR fixes this so that differently ordered unions are considered
equivalent even when they appear inside arbitrarily nested tuple types.

## Test Plan

- Added mdtests that fails on `main`
- Checked that all property tests continue to pass with this PR

2025-01-25 16:39:07 +00:00

mdtest

[red-knot] Ensure differently ordered unions and intersections are understood as equivalent even inside arbitrarily nested tuples (#15740 )

2025-01-25 16:39:07 +00:00

README.md

Markdown files within the mdtest/ subdirectory are tests of type inference and type checking; executed by the tests/mdtest.rs integration test.

See crates/red_knot_test/README.md for documentation of this test format.