salsa/tests/parallel/parallel_join.rs
Lukas Wirth 2c57c5628b
Some checks are pending
Book / Book (push) Waiting to run
Book / Deploy (push) Blocked by required conditions
Release-plz / Release-plz release (push) Waiting to run
Release-plz / Release-plz PR (push) Waiting to run
Test / Test (push) Waiting to run
Test / Miri (push) Waiting to run
Test / Shuttle (push) Waiting to run
Test / Benchmarks (push) Waiting to run
Fix flaky parallel_join test (#900)
2025-06-04 12:24:15 +00:00

176 lines
4 KiB
Rust

#![cfg(all(feature = "rayon", not(feature = "shuttle")))]
// test for rayon-like join interactions.
use std::sync::{
atomic::{AtomicUsize, Ordering},
Arc,
};
use salsa::{Cancelled, Database, Setter, Storage};
use crate::signal::Signal;
#[salsa::input]
struct ParallelInput {
a: u32,
b: u32,
}
#[salsa::tracked]
fn tracked_fn(db: &dyn salsa::Database, input: ParallelInput) -> (u32, u32) {
salsa::join(db, |db| input.a(db) + 1, |db| input.b(db) - 1)
}
#[salsa::tracked]
fn a1(db: &dyn KnobsDatabase, input: ParallelInput) -> (u32, u32) {
db.signal(1);
salsa::join(
db,
|db| {
db.wait_for(2);
input.a(db) + dummy(db)
},
|db| {
db.wait_for(2);
input.b(db) + dummy(db)
},
)
}
#[salsa::tracked]
fn dummy(_db: &dyn KnobsDatabase) -> u32 {
panic!("should never get here!")
}
#[test]
#[cfg_attr(miri, ignore)]
fn execute() {
let db = salsa::DatabaseImpl::new();
let input = ParallelInput::new(&db, 10, 20);
tracked_fn(&db, input);
}
// we expect this to panic, as `salsa::par_map` needs to be called from a query.
#[test]
#[cfg_attr(miri, ignore)]
#[should_panic]
fn direct_calls_panic() {
let db = salsa::DatabaseImpl::new();
let input = ParallelInput::new(&db, 10, 20);
let (_, _) = salsa::join(&db, |db| input.a(db) + 1, |db| input.b(db) - 1);
}
// Cancellation signalling test
//
// The pattern is as follows.
//
// Thread A Thread B
// -------- --------
// a1
// | wait for stage 1
// signal stage 1 set input, triggers cancellation
// wait for stage 2 (blocks) triggering cancellation sends stage 2
// |
// (unblocked)
// dummy
// panics
#[test]
#[cfg_attr(miri, ignore)]
fn execute_cancellation() {
let mut db = Knobs::default();
let input = ParallelInput::new(&db, 10, 20);
let thread_a = std::thread::spawn({
let db = db.clone();
move || a1(&db, input)
});
db.signal_on_did_cancel(2);
input.set_a(&mut db).to(30);
// Assert thread A was cancelled
let cancelled = thread_a
.join()
.unwrap_err()
.downcast::<Cancelled>()
.unwrap();
// and inspect the output
expect_test::expect![[r#"
PendingWrite
"#]]
.assert_debug_eq(&cancelled);
}
#[salsa::db]
trait KnobsDatabase: Database {
fn signal(&self, stage: usize);
fn wait_for(&self, stage: usize);
}
/// A copy of `tests\parallel\setup.rs` that does not assert, as the assert is incorrect for the
/// purposes of this test.
#[salsa::db]
struct Knobs {
storage: salsa::Storage<Self>,
signal: Arc<Signal>,
signal_on_did_cancel: Arc<AtomicUsize>,
}
impl Knobs {
pub fn signal_on_did_cancel(&self, stage: usize) {
self.signal_on_did_cancel.store(stage, Ordering::Release);
}
}
impl Clone for Knobs {
#[track_caller]
fn clone(&self) -> Self {
Self {
storage: self.storage.clone(),
signal: self.signal.clone(),
signal_on_did_cancel: self.signal_on_did_cancel.clone(),
}
}
}
impl Default for Knobs {
fn default() -> Self {
let signal = <Arc<Signal>>::default();
let signal_on_did_cancel = Arc::new(AtomicUsize::new(0));
Self {
storage: Storage::new(Some(Box::new({
let signal = signal.clone();
let signal_on_did_cancel = signal_on_did_cancel.clone();
move |event| {
if let salsa::EventKind::DidSetCancellationFlag = event.kind {
signal.signal(signal_on_did_cancel.load(Ordering::Acquire));
}
}
}))),
signal,
signal_on_did_cancel,
}
}
}
#[salsa::db]
impl salsa::Database for Knobs {}
#[salsa::db]
impl KnobsDatabase for Knobs {
fn signal(&self, stage: usize) {
self.signal.signal(stage);
}
fn wait_for(&self, stage: usize) {
self.signal.wait_for(stage);
}
}