mirrors/uv
1
0
Fork 0
mirror of https://github.com/astral-sh/uv.git synced 2025-08-04 19:08:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Add warning when target version does not match build version (#1072)

Browse source 
Follow-up to https://github.com/astral-sh/puffin/pull/1040 adding a
user-facing warning when we cannot build with their requested version.

e.g.

```
❯ cargo run -- pip compile requirements.in --python-version 3.11.4 --no-build
Resolved 8 packages in 483ms
❯ cargo run -- pip compile requirements.in --python-version 3.11.4
warning: The requested Python version 3.11.4 is not available; 3.11.7 will be used to build dependencies instead.
Resolved 8 packages in 71ms
❯ cargo run -- pip compile requirements.in --python-version 3.11
Resolved 8 packages in 71ms
```
This commit is contained in:
Zanie Blue 2024-01-24 13:42:19 -06:00 • committed by GitHub
parent 738e8341e2
commit 0019fe71f6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 20 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

20
crates/puffin/src/commands/pip_compile.rs
View file

@ -11,6 +11,7 @@ use anyhow::{anyhow, Context, Result};
use chrono::{DateTime, Utc};
use itertools::Itertools;
use owo_colors::OwoColorize;
use puffin_warnings::warn_user;
use rustc_hash::FxHashSet;
use tempfile::tempdir_in;
use tracing::debug;
@ -130,6 +131,25 @@ pub(crate) async fn pip_compile(
interpreter.python_version(),
interpreter.sys_executable().display().cyan()
);
if let Some(python_version) = python_version.as_ref() {
// If the requested version does not match the version we're using warn the user
// _unless_ they have not specified a patch version and that is the only difference
// _or_ if builds are disabled
let matches_without_patch = {
python_version.major() == interpreter.python_major()
&& python_version.minor() == interpreter.python_minor()
};
if !no_build
&& python_version.version() != interpreter.python_version()
&& (python_version.patch().is_some() || !matches_without_patch)
{
warn_user!(
"The requested Python version {} is not available; {} will be used to build dependencies instead.",
python_version.version(),
interpreter.python_version(),
);
}
}
// Create a shared in-memory index.
let source_index = InMemoryIndex::default();