mirrors/uv
1
0
Fork 0
mirror of https://github.com/astral-sh/uv.git synced 2025-11-23 12:56:47 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

uv-client: switch to RFC 9110 compatible format (#8752)

Browse source 
This still utilizes the RFC 2822 datetime formatter, but utilizes new
methods [added in jiff 0.1.14] to emit timestamps in a format strictly
compatible with RFC 9110.

It seems like most HTTP servers were pretty flexible and supported RFC
2822 datetime formats, but #8747 shows at least one case where that
isn't true. Given that the [MDN docs prescribe RFC 9110], we defer to
them.

Fixes #8747

[added in jiff 0.1.14]: https://github.com/BurntSushi/jiff/pull/154
[MDN docs prescribe RFC 9110]:
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/If-Modified-Since
This commit is contained in:
Andrew Gallant 2024-11-01 09:46:24 -04:00 • committed by GitHub
parent f8291144c0
commit 049ccf7d77
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 5 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Cargo.lock generated
View file

@ -1710,9 +1710,9 @@ checksum = "49f1f14873335454500d59611f1cf4a4b0f786f9ac11f4312a78e4cf2566695b"
[[package]] [[package]]
name = "jiff" name = "jiff"
version = "0.1.13" version = "0.1.14"
source = "registry+https://github.com/rust-lang/crates.io-index" source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "8a45489186a6123c128fdf6016183fcfab7113e1820eb813127e036e287233fb" checksum = "b9d9d414fc817d3e3d62b2598616733f76c4cc74fbac96069674739b881295c8"
dependencies = [ dependencies = [
"jiff-tzdb-platform", "jiff-tzdb-platform",
"serde", "serde",

2
Cargo.toml
View file

@ -112,7 +112,7 @@ indexmap = { version = "2.5.0" }
indicatif = { version = "0.17.8" } indicatif = { version = "0.17.8" }
indoc = { version = "2.0.5" } indoc = { version = "2.0.5" }
itertools = { version = "0.13.0" } itertools = { version = "0.13.0" }
jiff = { version = "0.1.13", features = ["serde"] } jiff = { version = "0.1.14", features = ["serde"] }
junction = { version = "1.2.0" } junction = { version = "1.2.0" }
krata-tokio-tar = { version = "0.4.2" } krata-tokio-tar = { version = "0.4.2" }
mailparse = { version = "0.15.0" } mailparse = { version = "0.15.0" }

6
crates/uv-client/src/httpcache/mod.rs
View file

@ -1381,11 +1381,9 @@ fn unix_timestamp_to_rfc2822(seconds: u64) -> Option<String> {
use jiff::fmt::rfc2822::DateTimePrinter; use jiff::fmt::rfc2822::DateTimePrinter;
unix_timestamp_to_datetime(seconds).and_then(|timestamp| { unix_timestamp_to_datetime(seconds).and_then(|timestamp| {
let mut buf = String::new();
DateTimePrinter::new() DateTimePrinter::new()
.print_timestamp(&timestamp, &mut buf) .timestamp_to_rfc9110_string(&timestamp)
.ok()?; .ok()
Some(buf)
}) })
} }