mirrors/uv
1
0
Fork 0
mirror of https://github.com/astral-sh/uv.git synced 2025-07-16 01:35:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

make the error message clearer when running distroless containers (#13549)

Browse source 
Previously you could get a confusing error message like this:

```
$ docker run ghcr.io/astral-sh/uv run python
error: Could not read ELF interpreter from any of the following paths: /bin/sh, /usr/bin/env, /bin/dash, /bin/ls
```

Now the error message is better:

```
error: Failed to discover managed Python installations
  Caused by: Failed to determine the libc used on the current platform
  Caused by: Failed to find any common binaries to determine libc from: /bin/sh, /usr/bin/env, /bin/dash, /bin/ls
```

See https://github.com/astral-sh/uv/issues/8635.

---------

Co-authored-by: konsti <konstin@mailbox.org>
Co-authored-by: Zanie Blue <contact@zanie.dev>
This commit is contained in:
Jack O'Connor 2025-05-29 10:29:01 -07:00 • committed by GitHub
parent 72e2821d26
commit 08f2fa48ff
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 22 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

20
crates/uv-python/src/libc.rs
View file

@ -37,6 +37,8 @@ pub enum LibcDetectionError {
InvalidLdSoOutputMusl(PathBuf),
#[error("Could not read ELF interpreter from any of the following paths: {0}")]
CoreBinaryParsing(String),
#[error("Failed to find any common binaries to determine libc from: {0}")]
NoCommonBinariesFound(String),
#[error("Failed to determine libc")]
Io(#[from] io::Error),
}
@ -207,12 +209,24 @@ fn find_ld_path() -> Result<PathBuf, LibcDetectionError> {
// See: https://github.com/astral-sh/uv/issues/1810
// See: https://github.com/astral-sh/uv/issues/4242#issuecomment-2306164449
let attempts = ["/bin/sh", "/usr/bin/env", "/bin/dash", "/bin/ls"];
let mut found_anything = false;
for path in attempts {
if let Some(ld_path) = find_ld_path_at(path) {
return Ok(ld_path);
if std::fs::exists(path).ok() == Some(true) {
found_anything = true;
if let Some(ld_path) = find_ld_path_at(path) {
return Ok(ld_path);
}
}
}
Err(LibcDetectionError::CoreBinaryParsing(attempts.join(", ")))
let attempts_string = attempts.join(", ");
if !found_anything {
// Known failure cases here include running the distroless Docker images directly
// (depending on what subcommand you use) and certain Nix setups. See:
// https://github.com/astral-sh/uv/issues/8635
Err(LibcDetectionError::NoCommonBinariesFound(attempts_string))
} else {
Err(LibcDetectionError::CoreBinaryParsing(attempts_string))
}
}
/// Attempt to find the path to the `ld` executable by