Silence log message to debug for uv run (#10588)

## Summary

This log message is shown every time a script including a uv
shebang is run. After installing all dependencies, printing this log
message every time does not add any relevant information for the user. I
would say it could even be misleading and motivate the user to debug his
own program searching for this log message.

As a consequence, reduce the log level of this message to debug.

## Test Plan

uv run was called with default settings and the log message didn't show
up.
cargo test was run and I tried to fix the issues.
This commit is contained in:
Stefan Tatschner 2025-01-15 20:04:51 +01:00 committed by GitHub
parent ea0ae5e1c6
commit 1480f28f93
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 5 additions and 44 deletions

View file

@ -172,28 +172,19 @@ pub(crate) async fn run(
let script_interpreter = if let Some(script) = script { let script_interpreter = if let Some(script) = script {
match &script { match &script {
Pep723Item::Script(script) => { Pep723Item::Script(script) => {
writeln!( debug!(
printer.stderr(),
"Reading inline script metadata from `{}`", "Reading inline script metadata from `{}`",
script.path.user_display().cyan() script.path.user_display()
)?; );
} }
Pep723Item::Stdin(_) => { Pep723Item::Stdin(_) => {
if requirements_from_stdin { if requirements_from_stdin {
bail!("Cannot read both requirements file and script from stdin"); bail!("Cannot read both requirements file and script from stdin");
} }
writeln!( debug!("Reading inline script metadata from `{}`", "stdin");
printer.stderr(),
"Reading inline script metadata from `{}`",
"stdin".cyan()
)?;
} }
Pep723Item::Remote(_) => { Pep723Item::Remote(_) => {
writeln!( debug!("Reading inline script metadata from `{}`", "remote URL");
printer.stderr(),
"Reading inline script metadata from {}",
"remote URL".cyan()
)?;
} }
} }

View file

@ -306,7 +306,6 @@ fn run_pep723_script() -> Result<()> {
----- stdout ----- ----- stdout -----
----- stderr ----- ----- stderr -----
Reading inline script metadata from `main.py`
Resolved 1 package in [TIME] Resolved 1 package in [TIME]
Prepared 1 package in [TIME] Prepared 1 package in [TIME]
Installed 1 package in [TIME] Installed 1 package in [TIME]
@ -320,7 +319,6 @@ fn run_pep723_script() -> Result<()> {
----- stdout ----- ----- stdout -----
----- stderr ----- ----- stderr -----
Reading inline script metadata from `main.py`
Resolved 1 package in [TIME] Resolved 1 package in [TIME]
"###); "###);
@ -393,7 +391,6 @@ fn run_pep723_script() -> Result<()> {
Hello, world! Hello, world!
----- stderr ----- ----- stderr -----
Reading inline script metadata from `main.py`
"###); "###);
// Running a script with `--locked` should warn. // Running a script with `--locked` should warn.
@ -404,7 +401,6 @@ fn run_pep723_script() -> Result<()> {
Hello, world! Hello, world!
----- stderr ----- ----- stderr -----
Reading inline script metadata from `main.py`
warning: `--locked` is a no-op for Python scripts with inline metadata, which always run in isolation warning: `--locked` is a no-op for Python scripts with inline metadata, which always run in isolation
"###); "###);
@ -427,7 +423,6 @@ fn run_pep723_script() -> Result<()> {
----- stdout ----- ----- stdout -----
----- stderr ----- ----- stderr -----
Reading inline script metadata from `main.py`
× No solution found when resolving script dependencies: × No solution found when resolving script dependencies:
Because there are no versions of add and you require add, we can conclude that your requirements are unsatisfiable. Because there are no versions of add and you require add, we can conclude that your requirements are unsatisfiable.
"###); "###);
@ -450,7 +445,6 @@ fn run_pep723_script() -> Result<()> {
----- stdout ----- ----- stdout -----
----- stderr ----- ----- stderr -----
Reading inline script metadata from `main.py`
× No solution found when resolving script dependencies: × No solution found when resolving script dependencies:
Because there are no versions of add and you require add, we can conclude that your requirements are unsatisfiable. Because there are no versions of add and you require add, we can conclude that your requirements are unsatisfiable.
"###); "###);
@ -513,7 +507,6 @@ fn run_pep723_script_requires_python() -> Result<()> {
----- stdout ----- ----- stdout -----
----- stderr ----- ----- stderr -----
Reading inline script metadata from `main.py`
warning: The Python request from `.python-version` resolved to Python 3.8.[X], which is incompatible with the script's Python requirement: `>=3.11` warning: The Python request from `.python-version` resolved to Python 3.8.[X], which is incompatible with the script's Python requirement: `>=3.11`
Resolved 1 package in [TIME] Resolved 1 package in [TIME]
Prepared 1 package in [TIME] Prepared 1 package in [TIME]
@ -535,7 +528,6 @@ fn run_pep723_script_requires_python() -> Result<()> {
hello hello
----- stderr ----- ----- stderr -----
Reading inline script metadata from `main.py`
Resolved 1 package in [TIME] Resolved 1 package in [TIME]
Installed 1 package in [TIME] Installed 1 package in [TIME]
+ iniconfig==2.0.0 + iniconfig==2.0.0
@ -616,7 +608,6 @@ fn run_pep723_script_metadata() -> Result<()> {
----- stdout ----- ----- stdout -----
----- stderr ----- ----- stderr -----
Reading inline script metadata from `main.py`
Resolved 1 package in [TIME] Resolved 1 package in [TIME]
Prepared 1 package in [TIME] Prepared 1 package in [TIME]
Installed 1 package in [TIME] Installed 1 package in [TIME]
@ -647,7 +638,6 @@ fn run_pep723_script_metadata() -> Result<()> {
----- stdout ----- ----- stdout -----
----- stderr ----- ----- stderr -----
Reading inline script metadata from `main.py`
Resolved 1 package in [TIME] Resolved 1 package in [TIME]
Prepared 1 package in [TIME] Prepared 1 package in [TIME]
Installed 1 package in [TIME] Installed 1 package in [TIME]
@ -689,7 +679,6 @@ fn run_pep723_script_index() -> Result<()> {
----- stdout ----- ----- stdout -----
----- stderr ----- ----- stderr -----
Reading inline script metadata from `main.py`
Resolved 1 package in [TIME] Resolved 1 package in [TIME]
Prepared 1 package in [TIME] Prepared 1 package in [TIME]
Installed 1 package in [TIME] Installed 1 package in [TIME]
@ -726,7 +715,6 @@ fn run_pep723_script_constraints() -> Result<()> {
----- stdout ----- ----- stdout -----
----- stderr ----- ----- stderr -----
Reading inline script metadata from `main.py`
Resolved 3 packages in [TIME] Resolved 3 packages in [TIME]
Prepared 3 packages in [TIME] Prepared 3 packages in [TIME]
Installed 3 packages in [TIME] Installed 3 packages in [TIME]
@ -765,7 +753,6 @@ fn run_pep723_script_overrides() -> Result<()> {
----- stdout ----- ----- stdout -----
----- stderr ----- ----- stderr -----
Reading inline script metadata from `main.py`
Resolved 3 packages in [TIME] Resolved 3 packages in [TIME]
Prepared 3 packages in [TIME] Prepared 3 packages in [TIME]
Installed 3 packages in [TIME] Installed 3 packages in [TIME]
@ -842,7 +829,6 @@ fn run_pep723_script_lock() -> Result<()> {
Hello, world! Hello, world!
----- stderr ----- ----- stderr -----
Reading inline script metadata from `main.py`
Resolved 1 package in [TIME] Resolved 1 package in [TIME]
Prepared 1 package in [TIME] Prepared 1 package in [TIME]
Installed 1 package in [TIME] Installed 1 package in [TIME]
@ -871,7 +857,6 @@ fn run_pep723_script_lock() -> Result<()> {
----- stdout ----- ----- stdout -----
----- stderr ----- ----- stderr -----
Reading inline script metadata from `main.py`
Resolved 3 packages in [TIME] Resolved 3 packages in [TIME]
error: The lockfile at `uv.lock` needs to be updated, but `--locked` was provided. To update the lockfile, run `uv lock`. error: The lockfile at `uv.lock` needs to be updated, but `--locked` was provided. To update the lockfile, run `uv lock`.
"###); "###);
@ -883,7 +868,6 @@ fn run_pep723_script_lock() -> Result<()> {
----- stdout ----- ----- stdout -----
----- stderr ----- ----- stderr -----
Reading inline script metadata from `main.py`
warning: `--frozen` is a no-op for Python scripts with inline metadata, which always run in isolation warning: `--frozen` is a no-op for Python scripts with inline metadata, which always run in isolation
Traceback (most recent call last): Traceback (most recent call last):
File "[TEMP_DIR]/main.py", line 8, in <module> File "[TEMP_DIR]/main.py", line 8, in <module>
@ -899,7 +883,6 @@ fn run_pep723_script_lock() -> Result<()> {
Hello, world! Hello, world!
----- stderr ----- ----- stderr -----
Reading inline script metadata from `main.py`
Resolved 3 packages in [TIME] Resolved 3 packages in [TIME]
Prepared 3 packages in [TIME] Prepared 3 packages in [TIME]
Installed 3 packages in [TIME] Installed 3 packages in [TIME]
@ -3006,7 +2989,6 @@ fn run_compiled_python_file() -> Result<()> {
----- stdout ----- ----- stdout -----
----- stderr ----- ----- stderr -----
Reading inline script metadata from `script.py`
Resolved 1 package in [TIME] Resolved 1 package in [TIME]
Prepared 1 package in [TIME] Prepared 1 package in [TIME]
Installed 1 package in [TIME] Installed 1 package in [TIME]
@ -3167,7 +3149,6 @@ fn run_script_explicit() -> Result<()> {
Hello, world! Hello, world!
----- stderr ----- ----- stderr -----
Reading inline script metadata from `script`
Resolved 1 package in [TIME] Resolved 1 package in [TIME]
Prepared 1 package in [TIME] Prepared 1 package in [TIME]
Installed 1 package in [TIME] Installed 1 package in [TIME]
@ -3201,7 +3182,6 @@ fn run_script_explicit_stdin() -> Result<()> {
Hello, world! Hello, world!
----- stderr ----- ----- stderr -----
Reading inline script metadata from `stdin`
Resolved 1 package in [TIME] Resolved 1 package in [TIME]
Prepared 1 package in [TIME] Prepared 1 package in [TIME]
Installed 1 package in [TIME] Installed 1 package in [TIME]
@ -3270,7 +3250,6 @@ fn run_gui_script_explicit_windows() -> Result<()> {
----- stdout ----- ----- stdout -----
----- stderr ----- ----- stderr -----
Reading inline script metadata from `script`
Resolved in [TIME] Resolved in [TIME]
Audited in [TIME] Audited in [TIME]
Using executable: pythonw.exe Using executable: pythonw.exe
@ -3304,7 +3283,6 @@ fn run_gui_script_explicit_stdin_windows() -> Result<()> {
Hello, world! Hello, world!
----- stderr ----- ----- stderr -----
Reading inline script metadata from `stdin`
Resolved 1 package in [TIME] Resolved 1 package in [TIME]
Prepared 1 package in [TIME] Prepared 1 package in [TIME]
Installed 1 package in [TIME] Installed 1 package in [TIME]
@ -3337,7 +3315,6 @@ fn run_gui_script_explicit_unix() -> Result<()> {
----- stdout ----- ----- stdout -----
----- stderr ----- ----- stderr -----
Reading inline script metadata from `script`
Resolved in [TIME] Resolved in [TIME]
Audited in [TIME] Audited in [TIME]
Using executable: python3 Using executable: python3
@ -3371,7 +3348,6 @@ fn run_gui_script_explicit_stdin_unix() -> Result<()> {
Hello, world! Hello, world!
----- stderr ----- ----- stderr -----
Reading inline script metadata from `stdin`
Resolved 1 package in [TIME] Resolved 1 package in [TIME]
Prepared 1 package in [TIME] Prepared 1 package in [TIME]
Installed 1 package in [TIME] Installed 1 package in [TIME]
@ -3385,10 +3361,6 @@ fn run_gui_script_explicit_stdin_unix() -> Result<()> {
fn run_remote_pep723_script() { fn run_remote_pep723_script() {
let context = TestContext::new("3.12").with_filtered_python_names(); let context = TestContext::new("3.12").with_filtered_python_names();
let mut filters = context.filters(); let mut filters = context.filters();
filters.push((
r"(?m)^Reading inline script metadata from:.*\.py$",
"Reading inline script metadata from: [TEMP_PATH].py",
));
filters.push(( filters.push((
r"(?m)^Downloaded remote script to:.*\.py$", r"(?m)^Downloaded remote script to:.*\.py$",
"Downloaded remote script to: [TEMP_PATH].py", "Downloaded remote script to: [TEMP_PATH].py",
@ -3400,7 +3372,6 @@ fn run_remote_pep723_script() {
Hello CI, from uv! Hello CI, from uv!
----- stderr ----- ----- stderr -----
Reading inline script metadata from remote URL
Resolved 4 packages in [TIME] Resolved 4 packages in [TIME]
Prepared 4 packages in [TIME] Prepared 4 packages in [TIME]
Installed 4 packages in [TIME] Installed 4 packages in [TIME]
@ -3464,7 +3435,6 @@ fn run_stdin_with_pep723() -> Result<()> {
Hello, world! Hello, world!
----- stderr ----- ----- stderr -----
Reading inline script metadata from `stdin`
Resolved 1 package in [TIME] Resolved 1 package in [TIME]
Prepared 1 package in [TIME] Prepared 1 package in [TIME]
Installed 1 package in [TIME] Installed 1 package in [TIME]