From 2c98154934e55ea56c3ec83c07760ce168b1a171 Mon Sep 17 00:00:00 2001 From: Charlie Marsh Date: Mon, 18 Mar 2024 11:47:20 -0700 Subject: [PATCH] Fix wheel builds and uploads for musl ARM (#2518) If you look at https://pypi.org/project/uv/0.1.22/#files... - We didn't upload the ARMv6 wheel (I thought I had removed the `# Skip for `arm`, which is not supported by PyPI.`), it must've gotten re-added in a rebase or something. - We lost the musllinux builds for ARM. I think this is because I built them as manylinux. --- .github/workflows/build-binaries.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build-binaries.yml b/.github/workflows/build-binaries.yml index 5ae9852a5..97f72fbee 100644 --- a/.github/workflows/build-binaries.yml +++ b/.github/workflows/build-binaries.yml @@ -272,8 +272,6 @@ jobs: maturin_docker_options: -e JEMALLOC_SYS_WITH_LG_PAGE=16 - target: armv7-unknown-linux-gnueabihf arch: armv7 - - target: armv7-unknown-linux-musleabihf - arch: armv7 - target: arm-unknown-linux-musleabihf arch: arm @@ -306,8 +304,6 @@ jobs: pip3 install ${{ env.PACKAGE_NAME }} --no-index --find-links dist/ --force-reinstall ${{ env.MODULE_NAME }} --help - name: "Upload wheels" - # Skip for `arm`, which is not supported by PyPI. - if: ${{ matrix.platform.arch != 'arm' }} uses: actions/upload-artifact@v4 with: name: wheels-${{ matrix.platform.target }} @@ -540,6 +536,8 @@ jobs: - target: aarch64-unknown-linux-musl arch: aarch64 maturin_docker_options: -e JEMALLOC_SYS_WITH_LG_PAGE=16 + - target: armv7-unknown-linux-musleabihf + arch: armv7 steps: - uses: actions/checkout@v4