mirrors/uv
1
0
Fork 0
mirror of https://github.com/astral-sh/uv.git synced 2025-09-26 12:09:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

uv-pep508: add a clarifying test

Browse source 
This test demonstrates the difference between `extra != "foo"` and
`sys_platform != "foo"`.

I wrote this test down to test the extra simplification logic was
correct. And I also wanted to test whether we could somehow hackily
encode `group` (as opposed to just `extra`) logic into marker
expressions by reusing another field. But I don't think we can.
This commit is contained in:
Andrew Gallant 2024-11-21 08:26:55 -05:00 • committed by Andrew Gallant
parent a513301b7a
commit 42da99ff92
1 changed files with 33 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

33
crates/uv-pep508/src/marker/tree.rs
View file

@ -2451,6 +2451,39 @@ mod test {
assert!(m("sys_platform == 'win32' and sys_platform != 'win32'").is_false());
}
/// This tests the difference between simplifying extras and simplifying
/// other stringly-valued marker attributes.
///
/// In particular, this demonstrates that `extra != "foo"` would actually
/// be more clearly written as `"foo" not in extras`. And similarly, `extra
/// == "foo"` would be written as `"foo" in extras`. This is different from
/// other attributes, like `sys_platform`, where the test is just string
/// equality. That is, `extra` is a set where as `sys_platform` is just a
/// single value.
#[test]
fn test_simplification_extra_versus_other() {
// Here, the `extra != 'foo'` cannot be simplified out, because
// `extra == 'foo'` can be true even when `extra == 'bar`' is true.
assert_simplifies(
r#"extra != "foo" and (extra == "bar" or extra == "baz")"#,
"(extra == 'bar' and extra != 'foo') or (extra == 'baz' and extra != 'foo')",
);
// But here, the `sys_platform != 'foo'` can be simplified out, because
// it is strictly disjoint with
// `sys_platform == "bar" or sys_platform == "baz"`.
assert_simplifies(
r#"sys_platform != "foo" and (sys_platform == "bar" or sys_platform == "baz")"#,
"sys_platform == 'bar' or sys_platform == 'baz'",
);
// Another case I experimented with and wanted to verify.
assert_simplifies(
r#"(extra != "bar" and (extra == "foo" or extra == "baz"))
or ((extra != "foo" and extra != "bar") and extra == "baz")"#,
"(extra != 'bar' and extra == 'baz') or (extra != 'bar' and extra == 'foo')",
);
}
#[test]
fn test_marker_negation() {
assert_eq!(