From 4be9ba483ff94bd7345d021276876473927745ee Mon Sep 17 00:00:00 2001
From: Zanie Blue <contact@zanie.dev>
Date: Tue, 31 Oct 2023 15:24:27 -0500
Subject: [PATCH] Remove implicit clone from `ExtraName` and document
 requirement in `PackageName` (#262)

per discussion in #137


https://discord.com/channels/1039017663004942429/1148719284013510676/1169000261746962473
---
 crates/puffin-package/src/extra_name.rs   | 6 ------
 crates/puffin-package/src/package_name.rs | 1 +
 2 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/crates/puffin-package/src/extra_name.rs b/crates/puffin-package/src/extra_name.rs
index 3c3a38510..9d128f476 100644
--- a/crates/puffin-package/src/extra_name.rs
+++ b/crates/puffin-package/src/extra_name.rs
@@ -7,12 +7,6 @@ use regex::Regex;
 #[derive(Debug, Clone, PartialEq, Eq, Hash, PartialOrd, Ord)]
 pub struct ExtraName(String);
 
-impl From<&ExtraName> for ExtraName {
-    fn from(extra_name: &ExtraName) -> Self {
-        extra_name.clone()
-    }
-}
-
 impl Display for ExtraName {
     fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result {
         self.0.fmt(f)
diff --git a/crates/puffin-package/src/package_name.rs b/crates/puffin-package/src/package_name.rs
index 2b2e22b5a..f13c8e92a 100644
--- a/crates/puffin-package/src/package_name.rs
+++ b/crates/puffin-package/src/package_name.rs
@@ -10,6 +10,7 @@ use crate::dist_info_name::DistInfoName;
 pub struct PackageName(String);
 
 impl From<&PackageName> for PackageName {
+    /// Required for `WaitMap::wait`
     fn from(package_name: &PackageName) -> Self {
         package_name.clone()
     }