mirrors/uv
1
0
Fork 0
mirror of https://github.com/astral-sh/uv.git synced 2025-08-04 10:58:28 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Ignore tags in universal resolution (#4174)

Browse source 
## Summary

If a package lacks a source distribution, and we can't find a compatible
wheel for the current platform, we need to just _assume_ that the
package will have a valid wheel on all platforms on which it's
requested; if not, we raise an error at install time.

It's possible that we can be smarter about this over time. For example,
if the package was requested _only_ for macOS, we could verify that
there's at least one macOS-compatible wheel. See the linked issue for
more details.

Closes https://github.com/astral-sh/uv/issues/4139.
This commit is contained in:
Charlie Marsh 2024-06-10 05:38:21 -07:00 • committed by GitHub
parent bbd961c251
commit 5269a0dba8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
14 changed files with 42 additions and 40 deletions
Download patch file Download diff file Expand all files Collapse all files

8
crates/uv-resolver/src/resolver/provider.rs
View file

@ -74,7 +74,7 @@ pub struct DefaultResolverProvider<'a, Context: BuildContext> {
fetcher: DistributionDatabase<'a, Context>,
/// These are the entries from `--find-links` that act as overrides for index responses.
flat_index: FlatIndex,
tags: Tags,
tags: Option<Tags>,
python_requirement: PythonRequirement,
allowed_yanks: AllowedYanks,
hasher: HashStrategy,
@ -89,7 +89,7 @@ impl<'a, Context: BuildContext> DefaultResolverProvider<'a, Context> {
pub fn new(
fetcher: DistributionDatabase<'a, Context>,
flat_index: &'a FlatIndex,
tags: &'a Tags,
tags: Option<&'a Tags>,
python_requirement: PythonRequirement,
allowed_yanks: AllowedYanks,
hasher: &'a HashStrategy,
@ -100,7 +100,7 @@ impl<'a, Context: BuildContext> DefaultResolverProvider<'a, Context> {
Self {
fetcher,
flat_index: flat_index.clone(),
tags: tags.clone(),
tags: tags.cloned(),
python_requirement,
allowed_yanks,
hasher: hasher.clone(),
@ -132,7 +132,7 @@ impl<'a, Context: BuildContext> ResolverProvider for DefaultResolverProvider<'a,
metadata,
package_name,
&index,
&self.tags,
self.tags.as_ref(),
&self.python_requirement,
&self.allowed_yanks,
&self.hasher,