mirrors/uv
1
0
Fork 0
mirror of https://github.com/astral-sh/uv.git synced 2025-11-20 20:06:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Fix typo in MissingTopLevel warning (#16351)

Browse source 
<!--
Thank you for contributing to uv! To help us out with reviewing, please
consider the following:

- Does this pull request include a summary of the change? (See below.)
- Does this pull request include a descriptive title?
- Does this pull request include references to any relevant issues?
-->

## Summary

<!-- What's the purpose of the change? What does it do, and why? -->
The warning shown when `egg-info` lacks `top_level.txt` incorrectly
warns about missing `top-level.txt`

ee2649feaa/crates/uv-install-wheel/src/uninstall.rs (L179-L188)

ee2649feaa/crates/uv/src/commands/pip/operations.rs (L687-L693)

The non fatal warning with incorrect filename was introduced in
https://github.com/astral-sh/uv/pull/6881 which changed previous fatal
error https://github.com/astral-sh/uv/issues/6872 with correct
`top_level.txt` output.

## Test Plan

<!-- How was it tested? -->
Updated unit test to reflect change in warning
This commit is contained in:
Björn Dahlgren 2025-10-19 11:32:50 +02:00 • committed by GitHub
parent 88f519a3bf
commit 57f56467d9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
crates/uv/src/commands/pip/operations.rs
View file

@ -688,7 +688,7 @@ async fn execute_plan(
uv_install_wheel::Error::MissingTopLevel(_), uv_install_wheel::Error::MissingTopLevel(_),
)) => { )) => {
warn_user!( warn_user!(
"Failed to uninstall package at {} due to missing `top-level.txt` file. Installation may result in an incomplete environment.", "Failed to uninstall package at {} due to missing `top_level.txt` file. Installation may result in an incomplete environment.",
dist_info.install_path().user_display().cyan(), dist_info.install_path().user_display().cyan(),
); );
} }

2
crates/uv/tests/it/pip_install.rs
View file

@ -9019,7 +9019,7 @@ fn missing_top_level() {
----- stderr ----- ----- stderr -----
Resolved 1 package in [TIME] Resolved 1 package in [TIME]
warning: Failed to uninstall package at [SITE_PACKAGES]/suds_community.egg-info due to missing `top-level.txt` file. Installation may result in an incomplete environment. warning: Failed to uninstall package at [SITE_PACKAGES]/suds_community.egg-info due to missing `top_level.txt` file. Installation may result in an incomplete environment.
Uninstalled 2 packages in [TIME] Uninstalled 2 packages in [TIME]
Installed 1 package in [TIME] Installed 1 package in [TIME]
~ suds-community==0.8.5 ~ suds-community==0.8.5