mirrors/uv
1
0
Fork 0
mirror of https://github.com/astral-sh/uv.git synced 2025-08-04 10:58:28 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Skip submodule update for fresh clones (#4482)

Browse source 
## Summary

We unconditionally update the submodules in our Git code, but AFAICT it
shouldn't be necessary if we already have a complete, up-to-date fetch
available.
This commit is contained in:
Charlie Marsh 2024-06-25 00:09:14 +03:00 • committed by GitHub
parent 01515c1332
commit 7d3fb4330f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 5 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

13
crates/uv-git/src/git.rs
View file

@ -278,7 +278,6 @@ impl GitDatabase {
Some(co) => co,
None => GitCheckout::clone_into(destination, self, rev)?,
};
checkout.update_submodules()?;
Ok(checkout)
}
@ -414,12 +413,7 @@ impl GitCheckout {
.cwd(&self.repo.path)
.exec_with_output()?;
paths::create(ok_file)?;
Ok(())
}
/// Runs `git submodule update --recursive` on this git checkout.
fn update_submodules(&self) -> Result<()> {
// Update submodules (`git submodule update --recursive`).
ProcessBuilder::new("git")
.arg("submodule")
.arg("update")
@ -427,7 +421,10 @@ impl GitCheckout {
.arg("--init")
.cwd(&self.repo.path)
.exec_with_output()
.map(drop)
.map(drop)?;
paths::create(ok_file)?;
Ok(())
}
}