mirror of
https://github.com/astral-sh/uv.git
synced 2025-08-04 02:48:17 +00:00
Remove outdated todos (#476)
This commit is contained in:
parent
17228ba04e
commit
934e32ea98
2 changed files with 1 additions and 4 deletions
|
@ -227,7 +227,6 @@ impl SourceBuild {
|
|||
) -> Result<SourceBuild, Error> {
|
||||
let temp_dir = tempdir()?;
|
||||
|
||||
// TODO(konstin): Parse and verify filenames
|
||||
let source_root = if fs::metadata(source)?.is_dir() {
|
||||
source.to_path_buf()
|
||||
} else {
|
||||
|
@ -563,7 +562,6 @@ async fn create_pep517_build_environment(
|
|||
.all(|req| pep517_backend.requirements.contains(req))
|
||||
{
|
||||
debug!("Installing extra requirements for build backend");
|
||||
// TODO(konstin): Do we need to resolve them together?
|
||||
let requirements: Vec<Requirement> = pep517_backend
|
||||
.requirements
|
||||
.iter()
|
||||
|
@ -585,7 +583,6 @@ async fn create_pep517_build_environment(
|
|||
/// Returns the directory with the `pyproject.toml`/`setup.py`
|
||||
#[instrument(skip_all, fields(path))]
|
||||
fn extract_archive(sdist: &Path, extracted: &PathBuf) -> Result<PathBuf, Error> {
|
||||
// TODO(konstin): Simplify this with camino paths?
|
||||
if sdist
|
||||
.extension()
|
||||
.is_some_and(|extension| extension == "zip")
|
||||
|
|
|
@ -287,7 +287,7 @@ impl RegistryClient {
|
|||
// TODO(konstin): Download the wheel into a cache shared with the installer instead
|
||||
// Note that this branch is only hit when you're not using and the server where
|
||||
// you host your wheels for some reasons doesn't support range requests
|
||||
// (tbh we should probably warn here and tekk users to get a better registry because
|
||||
// (tbh we should probably warn here and tell users to get a better registry because
|
||||
// their current one makes resolution unnecessary slow)
|
||||
let temp_download = tempfile()?;
|
||||
let mut writer = BufWriter::new(tokio::fs::File::from_std(temp_download));
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue