mirrors/uv
1
0
Fork 0
mirror of https://github.com/astral-sh/uv.git synced 2025-11-23 12:56:47 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fallback to non-range requests when HEAD returns 404 (#2186)

Browse source 
## Summary

We have at least one reported case of this happening. It's preferable
IMO to move on rather than fail hard despite sub-pbar registry behavior.

Closes https://github.com/astral-sh/uv/issues/2099.
This commit is contained in:
Charlie Marsh 2024-03-04 19:18:49 -08:00 • committed by GitHub
parent 60a78812f9
commit 93b1395daa
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 9 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

9
crates/uv-client/src/error.rs
View file

@ -170,9 +170,18 @@ impl ErrorKind {
// HEAD requests, so we can't check for range requests. // HEAD requests, so we can't check for range requests.
Self::ReqwestError(err) => { Self::ReqwestError(err) => {
if let Some(status) = err.status() { if let Some(status) = err.status() {
// If the server doesn't support HEAD requests, we can't check for range
// requests.
if status == reqwest::StatusCode::METHOD_NOT_ALLOWED { if status == reqwest::StatusCode::METHOD_NOT_ALLOWED {
return true; return true;
} }
// In some cases, registries return a 404 for HEAD requests when they're not
// supported. In the worst case, we'll now just proceed to attempt to stream the
// entire file, so it's fine to be somewhat lenient here.
if status == reqwest::StatusCode::NOT_FOUND {
return true;
}
} }
} }