mirrors/uv
1
0
Fork 0
mirror of https://github.com/astral-sh/uv.git synced 2025-11-03 05:03:46 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

auth: allow insecure http only on localhost (#15755)

Browse source 
## Summary

This is useful for testing purposes.

## Test Plan

I tested using testing purposes.
This commit is contained in:
Zsolt Dollenstein 2025-09-09 17:21:14 +01:00 • committed by GitHub
parent 5494645fba
commit ae2dce6d25
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 19 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
crates/uv-auth/src/service.rs
View file

@ -8,7 +8,7 @@ use uv_redacted::DisplaySafeUrl;
pub enum ServiceParseError {
#[error(transparent)]
InvalidUrl(#[from] url::ParseError),
#[error("only HTTPS is supported")]
#[error("only HTTPS (or HTTP on localhost) is supported")]
UnsupportedScheme,
}
@ -35,6 +35,7 @@ impl Service {
fn check_scheme(url: &Url) -> Result<(), ServiceParseError> {
match url.scheme() {
"https" => Ok(()),
"http" if matches!(url.host_str(), Some("localhost" | "127.0.0.1")) => Ok(()),
#[cfg(test)]
"http" => Ok(()),
_ => Err(ServiceParseError::UnsupportedScheme),

18
crates/uv/tests/it/auth.rs
View file

@ -616,11 +616,27 @@ fn login_native_auth_url() {
----- stdout -----
----- stderr -----
error: invalid value 'http://example.com' for '<SERVICE>': only HTTPS is supported
error: invalid value 'http://example.com' for '<SERVICE>': only HTTPS (or HTTP on localhost) is supported
For more information, try '--help'.
");
// HTTP URLs are fine for localhost
uv_snapshot!(context.auth_login()
.arg("http://localhost:1324")
.arg("--username")
.arg("test")
.arg("--password")
.arg("test")
.env(EnvVars::UV_PREVIEW_FEATURES, "native-auth"), @r"
success: true
exit_code: 0
----- stdout -----
----- stderr -----
Stored credentials for test@http://localhost:1324/
");
uv_snapshot!(context.auth_login()
.arg("https://example.com")
.arg("--username")