mirrors/uv
1
0
Fork 0
mirror of https://github.com/astral-sh/uv.git synced 2025-08-04 19:08:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Include path or URL when failing to convert in lockfile (#14292)

Browse source 
## Summary

E.g., in #14227, we now get:

```
error: Failed to convert URL to path: https://cdn.jsdelivr.net/pyodide/v0.27.7/full/sniffio-1.3.1-py3-none-any.whl
```
This commit is contained in:
Charlie Marsh 2025-06-26 15:42:04 -04:00 • committed by GitHub
parent d4d6ede23b
commit c291d4329a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 32 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

54
crates/uv-resolver/src/lock/mod.rs
View file

@ -2545,9 +2545,12 @@ impl Package {
name: name.clone(), name: name.clone(),
version: version.clone(), version: version.clone(),
})?; })?;
let file_url = let file_path = workspace_root.join(path).join(file_path);
DisplaySafeUrl::from_file_path(workspace_root.join(path).join(file_path)) let file_url = DisplaySafeUrl::from_file_path(&file_path).map_err(|()| {
.map_err(|()| LockErrorKind::PathToUrl)?; LockErrorKind::PathToUrl {
path: file_path.into_boxed_path(),
}
})?;
let filename = sdist let filename = sdist
.filename() .filename()
.ok_or_else(|| LockErrorKind::MissingFilename { .ok_or_else(|| LockErrorKind::MissingFilename {
@ -3250,7 +3253,9 @@ impl Source {
Ok(Source::Registry(source)) Ok(Source::Registry(source))
} }
IndexUrl::Path(url) => { IndexUrl::Path(url) => {
let path = url.to_file_path().map_err(|()| LockErrorKind::UrlToPath)?; let path = url
.to_file_path()
.map_err(|()| LockErrorKind::UrlToPath { url: url.to_url() })?;
let path = relative_to(&path, root) let path = relative_to(&path, root)
.or_else(|_| std::path::absolute(&path)) .or_else(|_| std::path::absolute(&path))
.map_err(LockErrorKind::IndexRelativePath)?; .map_err(LockErrorKind::IndexRelativePath)?;
@ -3810,14 +3815,17 @@ impl SourceDist {
})) }))
} }
IndexUrl::Path(path) => { IndexUrl::Path(path) => {
let index_path = path.to_file_path().map_err(|()| LockErrorKind::UrlToPath)?; let index_path = path
let reg_dist_path = reg_dist .to_file_path()
.map_err(|()| LockErrorKind::UrlToPath { url: path.to_url() })?;
let reg_dist_url = reg_dist
.file .file
.url .url
.to_url() .to_url()
.map_err(LockErrorKind::InvalidUrl)? .map_err(LockErrorKind::InvalidUrl)?;
let reg_dist_path = reg_dist_url
.to_file_path() .to_file_path()
.map_err(|()| LockErrorKind::UrlToPath)?; .map_err(|()| LockErrorKind::UrlToPath { url: reg_dist_url })?;
let path = relative_to(&reg_dist_path, index_path) let path = relative_to(&reg_dist_path, index_path)
.or_else(|_| std::path::absolute(&reg_dist_path)) .or_else(|_| std::path::absolute(&reg_dist_path))
.map_err(LockErrorKind::DistributionRelativePath)? .map_err(LockErrorKind::DistributionRelativePath)?
@ -4140,14 +4148,13 @@ impl Wheel {
}) })
} }
IndexUrl::Path(path) => { IndexUrl::Path(path) => {
let index_path = path.to_file_path().map_err(|()| LockErrorKind::UrlToPath)?; let index_path = path
let wheel_path = wheel
.file
.url
.to_url()
.map_err(LockErrorKind::InvalidUrl)?
.to_file_path() .to_file_path()
.map_err(|()| LockErrorKind::UrlToPath)?; .map_err(|()| LockErrorKind::UrlToPath { url: path.to_url() })?;
let wheel_url = wheel.file.url.to_url().map_err(LockErrorKind::InvalidUrl)?;
let wheel_path = wheel_url
.to_file_path()
.map_err(|()| LockErrorKind::UrlToPath { url: wheel_url })?;
let path = relative_to(&wheel_path, index_path) let path = relative_to(&wheel_path, index_path)
.or_else(|_| std::path::absolute(&wheel_path)) .or_else(|_| std::path::absolute(&wheel_path))
.map_err(LockErrorKind::DistributionRelativePath)? .map_err(LockErrorKind::DistributionRelativePath)?
@ -4236,9 +4243,12 @@ impl Wheel {
.into()); .into());
} }
}; };
let file_url = let file_path = root.join(index_path).join(file_path);
DisplaySafeUrl::from_file_path(root.join(index_path).join(file_path)) let file_url = DisplaySafeUrl::from_file_path(&file_path).map_err(|()| {
.map_err(|()| LockErrorKind::PathToUrl)?; LockErrorKind::PathToUrl {
path: file_path.into_boxed_path(),
}
})?;
let file = Box::new(uv_distribution_types::File { let file = Box::new(uv_distribution_types::File {
dist_info_metadata: false, dist_info_metadata: false,
filename: SmallString::from(filename.to_string()), filename: SmallString::from(filename.to_string()),
@ -5449,11 +5459,11 @@ enum LockErrorKind {
VerbatimUrlError, VerbatimUrlError,
), ),
/// An error that occurs when converting a path to a URL. /// An error that occurs when converting a path to a URL.
#[error("Failed to convert path to URL")] #[error("Failed to convert path to URL: {path}", path = path.display().cyan())]
PathToUrl, PathToUrl { path: Box<Path> },
/// An error that occurs when converting a URL to a path /// An error that occurs when converting a URL to a path
#[error("Failed to convert URL to path")] #[error("Failed to convert URL to path: {url}", url = url.cyan())]
UrlToPath, UrlToPath { url: DisplaySafeUrl },
/// An error that occurs when multiple packages with the same /// An error that occurs when multiple packages with the same
/// name were found when identifying the root packages. /// name were found when identifying the root packages.
#[error("Found multiple packages matching `{name}`", name = name.cyan())] #[error("Found multiple packages matching `{name}`", name = name.cyan())]