mirrors/uv
1
0
Fork 0
mirror of https://github.com/astral-sh/uv.git synced 2025-10-29 03:02:55 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Log hardlink failures (#3015)

Browse source 
Inspired by https://github.com/astral-sh/uv/issues/2964, we now properly
log hardlink failures, e.g. when the cache is a docker container but the
venv is in a bind mount, e.g.:

```
DEBUG Failed to hardlink `/code/venv/uv/lib/python3.12/site-packages/asgiref-3.8.1.dist-info/WHEEL` to `/root/.cache/uv/archive-v0/nnpkKgUoM3LMxcNDmEKJQ/asgiref-3.8.1.dist-info/WHEEL`, attempting to copy files as a fallback
```
This commit is contained in:
konsti 2024-04-12 17:06:38 +02:00 • committed by GitHub
parent f61b97e6ba
commit d2da575c41
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 15 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

17
crates/install-wheel-rs/src/linker.rs
View file

@ -333,14 +333,17 @@ fn clone_recursive(
if reflink::reflink(&from, &tempfile).is_ok() { if reflink::reflink(&from, &tempfile).is_ok() {
fs::rename(&tempfile, to)?; fs::rename(&tempfile, to)?;
} else { } else {
debug!("Failed to clone {} to temporary location {} - attempting to copy files as a fallback", from.display(), tempfile.display()); debug!(
"Failed to clone `{}` to temporary location `{}`, attempting to copy files as a fallback",
from.display(),
tempfile.display());
*attempt = Attempt::UseCopyFallback; *attempt = Attempt::UseCopyFallback;
fs::copy(&from, &to)?; fs::copy(&from, &to)?;
} }
} }
} else { } else {
debug!( debug!(
"Failed to clone {} to {} - attempting to copy files as a fallback", "Failed to clone `{}` to `{}`, attempting to copy files as a fallback",
from.display(), from.display(),
to.display() to.display()
); );
@ -463,10 +466,20 @@ fn hardlink_wheel_files(
if fs::hard_link(path, &tempfile).is_ok() { if fs::hard_link(path, &tempfile).is_ok() {
fs_err::rename(&tempfile, &out_path)?; fs_err::rename(&tempfile, &out_path)?;
} else { } else {
debug!(
"Failed to hardlink `{}` to `{}`, attempting to copy files as a fallback",
out_path.display(),
path.display()
);
fs::copy(path, &out_path)?; fs::copy(path, &out_path)?;
attempt = Attempt::UseCopyFallback; attempt = Attempt::UseCopyFallback;
} }
} else { } else {
debug!(
"Failed to hardlink `{}` to `{}`, attempting to copy files as a fallback",
out_path.display(),
path.display()
);
fs::copy(path, &out_path)?; fs::copy(path, &out_path)?;
attempt = Attempt::UseCopyFallback; attempt = Attempt::UseCopyFallback;
} }