mirrors/uv
1
0
Fork 0
mirror of https://github.com/astral-sh/uv.git synced 2025-08-04 19:08:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Make GitHub fast path errors non-fatal (#10859)

Browse source 
## Summary

For example: in the linked issue, the user has a symlink at
`pyproject.toml`. The GitHub CDN doesn't give us any way to determine
whether a file is a symlink, so we should just log the error and move on
to the slow path.

Closes https://github.com/astral-sh/uv/issues/10857
This commit is contained in:
Charlie Marsh 2025-01-22 11:54:02 -05:00 • committed by GitHub
parent 62f8a483ef
commit d454f9c34b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 37 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

58
crates/uv-distribution/src/source/mod.rs
View file

@ -1499,39 +1499,55 @@ impl<'a, T: BuildContext> SourceDistributionBuilder<'a, T> {
}
// If this is GitHub URL, attempt to resolve to a precise commit using the GitHub API.
if let Some(precise) = self
match self
.build_context
.git()
.github_fast_path(
resource.git,
client.unmanaged.uncached_client(resource.url).clone(),
)
.await?
.await
{
// There's no need to check the cache, since we can't use cached metadata if there are
// sources, and we can't know if there are sources without fetching the
// `pyproject.toml`.
//
// For the same reason, there's no need to write to the cache, since we won't be able to
// use it on subsequent runs.
if let Some(metadata) = self
.github_metadata(precise, source, resource, client)
.await?
{
// Validate the metadata, but ignore it if the metadata doesn't match.
match validate_metadata(source, &metadata) {
Ok(()) => {
debug!("Found static metadata via GitHub fast path for: {source}");
return Ok(ArchiveMetadata {
metadata: Metadata::from_metadata23(metadata),
hashes: vec![],
});
Ok(Some(precise)) => {
// There's no need to check the cache, since we can't use cached metadata if there are
// sources, and we can't know if there are sources without fetching the
// `pyproject.toml`.
//
// For the same reason, there's no need to write to the cache, since we won't be able to
// use it on subsequent runs.
match self
.github_metadata(precise, source, resource, client)
.await
{
Ok(Some(metadata)) => {
// Validate the metadata, but ignore it if the metadata doesn't match.
match validate_metadata(source, &metadata) {
Ok(()) => {
debug!("Found static metadata via GitHub fast path for: {source}");
return Ok(ArchiveMetadata {
metadata: Metadata::from_metadata23(metadata),
hashes: vec![],
});
}
Err(err) => {
debug!("Ignoring `pyproject.toml` from GitHub for {source}: {err}");
}
}
}
Ok(None) => {
// Nothing to do.
}
Err(err) => {
debug!("Ignoring `pyproject.toml` from GitHub for {source}: {err}");
debug!("Failed to fetch `pyproject.toml` via GitHub fast path for: {source} ({err})");
}
}
}
Ok(None) => {
// Nothing to do.
}
Err(err) => {
debug!("Failed to resolve commit via GitHub fast path for: {source} ({err})");
}
}
// Fetch the Git repository.