mirrors/uv
1
0
Fork 0
mirror of https://github.com/astral-sh/uv.git synced 2025-08-04 02:48:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Use iterators rather than eagerly collecting tags (#10734)

Browse source
This commit is contained in:
Charlie Marsh 2025-01-18 13:11:48 -05:00 • committed by GitHub
parent 4f807473d3
commit ddff891397
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 23 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

8
crates/uv-resolver/src/pubgrub/report.rs
View file

@ -745,7 +745,7 @@ impl PubGrubReportFormatter<'_> {
IncompatibleTag::Invalid => None,
IncompatibleTag::Python => {
let best = tags.and_then(Tags::python_tag);
let tags = prioritized.python_tags();
let tags = prioritized.python_tags().collect::<BTreeSet<_>>();
if tags.is_empty() {
None
} else {
@ -761,7 +761,6 @@ impl PubGrubReportFormatter<'_> {
let best = tags.and_then(Tags::abi_tag);
let tags = prioritized
.abi_tags()
.into_iter()
// Ignore `none`, which is universally compatible.
//
// As an example, `none` can appear here if we're solving for Python 3.13, and
@ -796,9 +795,8 @@ impl PubGrubReportFormatter<'_> {
// we only show platforms for ABI-compatible wheels.
let tags = prioritized
.platform_tags(self.tags?)
.into_iter()
.cloned()
.collect::<Vec<_>>();
.collect::<BTreeSet<_>>();
if tags.is_empty() {
None
} else {
@ -1132,7 +1130,7 @@ pub(crate) enum PubGrubHint {
// excluded from `PartialEq` and `Hash`
version: Version,
// excluded from `PartialEq` and `Hash`
tags: Vec<PlatformTag>,
tags: BTreeSet<PlatformTag>,
},
}