Return Cow from UrlString::with_ methods (#14319)

A minor performance improvement as a follow-up to #14245 (and an
accompanying test).
This commit is contained in:
John Mumm 2025-06-27 19:54:52 +02:00 committed by GitHub
parent 74468dac15
commit f892b8564f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 37 additions and 24 deletions

View file

@ -1490,7 +1490,11 @@ impl Lock {
.version
.as_ref()
.expect("version for registry source");
return Ok(SatisfiesResult::MissingRemoteIndex(name, version, url));
return Ok(SatisfiesResult::MissingRemoteIndex(
name,
version,
url.into_owned(),
));
}
}
RegistrySource::Path(path) => {
@ -4692,7 +4696,7 @@ impl From<Hash> for Hashes {
/// Convert a [`FileLocation`] into a normalized [`UrlString`].
fn normalize_file_location(location: &FileLocation) -> Result<UrlString, ToUrlError> {
match location {
FileLocation::AbsoluteUrl(absolute) => Ok(absolute.without_fragment()),
FileLocation::AbsoluteUrl(absolute) => Ok(absolute.without_fragment().into_owned()),
FileLocation::RelativeUrl(_, _) => Ok(normalize_url(location.to_url()?)),
}
}