uv/crates/puffin-resolver/src/finder.rs
Charlie Marsh fd556ccd44
Model Python version as a PubGrub package (#745)
## Summary

This PR modifies the resolver to treat the Python version as a package,
which allows for better error messages (since we no longer treat
incompatible packages as if they "don't exist at all").

There are a few tricky pieces here...

First, we need to track both the interpreter's Python version and the
_target_ Python version, because we support resolving for other versions
via `--python 3.7`.

Second, we allow using incompatible wheels during resolution, as long as
there's a compatible source distribution. So we still need to test for
`requires-python` compatibility when selecting distributions.

This could use more testing, but it feels like an area where `packse`
would be more productive than writing PyPI tests.

Closes https://github.com/astral-sh/puffin/issues/406.
2024-01-03 15:20:45 +00:00

212 lines
7.6 KiB
Rust

//! Given a set of selected packages, find a compatible set of distributions to install.
//!
//! This is similar to running `pip install` with the `--no-deps` flag.
use anyhow::Result;
use futures::{stream, Stream, StreamExt, TryStreamExt};
use rustc_hash::FxHashMap;
use distribution_types::{Dist, File, Resolution};
use pep440_rs::Version;
use pep508_rs::{Requirement, VersionOrUrl};
use platform_tags::{TagPriority, Tags};
use puffin_client::{RegistryClient, SimpleMetadata};
use puffin_interpreter::Interpreter;
use puffin_normalize::PackageName;
use crate::error::ResolveError;
pub struct DistFinder<'a> {
tags: &'a Tags,
client: &'a RegistryClient,
reporter: Option<Box<dyn Reporter>>,
interpreter: &'a Interpreter,
}
impl<'a> DistFinder<'a> {
/// Initialize a new distribution finder.
pub fn new(tags: &'a Tags, client: &'a RegistryClient, interpreter: &'a Interpreter) -> Self {
Self {
tags,
client,
reporter: None,
interpreter,
}
}
/// Set the [`Reporter`] to use for this resolution.
#[must_use]
pub fn with_reporter(self, reporter: impl Reporter + 'static) -> Self {
Self {
reporter: Some(Box::new(reporter)),
..self
}
}
/// Resolve a single pinned package, either as cached network request
/// (version or no constraint) or by constructing a URL [`Dist`] from the
/// specifier URL.
async fn resolve_requirement(
&self,
requirement: &Requirement,
) -> Result<(PackageName, Dist), ResolveError> {
match requirement.version_or_url.as_ref() {
None | Some(VersionOrUrl::VersionSpecifier(_)) => {
// Query the index(es) (cached) to get the URLs for the available files.
let (index, base, metadata) = self.client.simple(&requirement.name).await?;
// Pick a version that satisfies the requirement.
let Some(ParsedFile {
name,
version,
file,
}) = self.select(requirement, metadata)
else {
return Err(ResolveError::NotFound(requirement.clone()));
};
let distribution = Dist::from_registry(name, version, file, index, base);
if let Some(reporter) = self.reporter.as_ref() {
reporter.on_progress(&distribution);
}
let normalized_name = requirement.name.clone();
Ok((normalized_name, distribution))
}
Some(VersionOrUrl::Url(url)) => {
// We have a URL; fetch the distribution directly.
let package_name = requirement.name.clone();
let package = Dist::from_url(package_name.clone(), url.clone())?;
Ok((package_name, package))
}
}
}
/// Resolve the pinned packages in parallel
pub fn resolve_stream<'data>(
&'data self,
requirements: &'data [Requirement],
) -> impl Stream<Item = Result<(PackageName, Dist), ResolveError>> + 'data {
stream::iter(requirements)
.map(move |requirement| self.resolve_requirement(requirement))
.buffer_unordered(32)
}
/// Resolve a set of pinned packages into a set of wheels.
pub async fn resolve(&self, requirements: &[Requirement]) -> Result<Resolution, ResolveError> {
if requirements.is_empty() {
return Ok(Resolution::default());
}
let resolution: FxHashMap<PackageName, Dist> =
self.resolve_stream(requirements).try_collect().await?;
if let Some(reporter) = self.reporter.as_ref() {
reporter.on_complete();
}
Ok(Resolution::new(resolution))
}
/// select a version that satisfies the requirement, preferring wheels to source distributions.
fn select(&self, requirement: &Requirement, metadata: SimpleMetadata) -> Option<ParsedFile> {
let mut best_version: Option<Version> = None;
let mut best_wheel: Option<(ParsedFile, TagPriority)> = None;
let mut best_sdist: Option<ParsedFile> = None;
for (version, files) in metadata.into_iter().rev() {
// If we iterated past the first-compatible version, break.
if best_version
.as_ref()
.is_some_and(|best_version| *best_version != version)
{
break;
}
// If the version does not satisfy the requirement, continue.
if !requirement.is_satisfied_by(&version) {
continue;
}
// Find the most-compatible wheel
for (wheel, file) in files.wheels {
// Only add dists compatible with the python version.
// This is relevant for source dists which give no other indication of their
// compatibility and wheels which may be tagged `py3-none-any` but
// have `requires-python: ">=3.9"`
if !file
.requires_python
.as_ref()
.map_or(true, |requires_python| {
requires_python.contains(self.interpreter.version())
})
{
continue;
}
best_version = Some(version.clone());
if let Some(priority) = wheel.compatibility(self.tags) {
if best_wheel
.as_ref()
.map_or(true, |(.., existing)| priority > *existing)
{
best_wheel = Some((
ParsedFile {
name: wheel.name,
version: wheel.version,
file,
},
priority,
));
}
}
}
// Find the most-compatible sdist, if no wheel was found.
if best_wheel.is_none() {
for (sdist, file) in files.source_dists {
// Only add dists compatible with the python version.
// This is relevant for source dists which give no other indication of their
// compatibility and wheels which may be tagged `py3-none-any` but
// have `requires-python: ">=3.9"`
if !file
.requires_python
.as_ref()
.map_or(true, |requires_python| {
requires_python.contains(self.interpreter.version())
})
{
continue;
}
best_version = Some(sdist.version.clone());
best_sdist = Some(ParsedFile {
name: sdist.name,
version: sdist.version,
file,
});
}
}
}
best_wheel.map_or(best_sdist, |(wheel, ..)| Some(wheel))
}
}
#[derive(Debug)]
struct ParsedFile {
/// The [`PackageName`] extracted from the [`File`].
name: PackageName,
/// The version extracted from the [`File`].
version: Version,
/// The underlying [`File`].
file: File,
}
pub trait Reporter: Send + Sync {
/// Callback to invoke when a package is resolved to a specific distribution.
fn on_progress(&self, dist: &Dist);
/// Callback to invoke when the resolution is complete.
fn on_complete(&self);
}