uv/crates
Jp 03f8808d11
Handle Windows AV/EDR file locks during script installations (#9543)
Fixes #9531


## Context

While working with [uv](https://github.com/astral-sh/uv), I encountered
issues with a python dependency, [httpx](https://www.python-httpx.org/)
unable to be installed because of a **os error 5 permission denied**.
The error occur when we try to persist a **.exe file** from a temporary
folder into a persistent one.
I only reproduce the issue in an enterprise **Windows** Jenkins Runner.
In my virtual machines, I don't have any issues. So I think this is most
probably coming from the system configuration. This windows runner
**contains an AV/EDR**. And the fact that the file locked occured only
once for an executable make me think that it's most probably the cause.

While doing some research and speaking with some colleagues (hi
@vmeurisse), it seems that the issue is a very recurrent one on Windows.
In the Javascript ecosystem, there is this package, created by the
@isaacs, `npm` inventor: https://www.npmjs.com/package/graceful-fs, used
inside `npm`, allowing its package installations to be more resilient to
filesystem errors:
> The improvements are meant to normalize behavior across different
platforms and environments, and to make filesystem access more resilient
to errors.
One of its core feature is this one:
> On Windows, it retries renaming a file for up to one second if EACCESS
or EPERM error occurs, likely because antivirus software has locked the
directory.

So I tried to implement the same algorithm on `uv`, **and it fixed my
issue**! I can finally install `httpx`.

Then, [as I mentionned in this
issue](https://github.com/astral-sh/uv/issues/9531#issuecomment-2508981316),
I saw that you already implemented exactly the same algorithm in an
asynchronous function for renames 😄

22fd9f7ff1/crates/uv-fs/src/lib.rs (L221)

## Summary of changes 
- I added a similar function for `persist` (was not easy to have the
benediction of the borrow checker 😄)
- I added a `sync` variant of `rename_with_retry`
- I edited `install_script` to use the function including retries on
Windows

Let me know if I should change anything 🙂 

Thanks!!

## Test Plan
This pull-request should be totally iso-functional, so I think it should
be covered by existing tests in case of regression.
All tests are still passing on my side.
Also, of course validated that my windows machines (windows 10 & windows
11) containing AV/EDR software are now able to install `httpx.exe`
script.
However, if you think any additional test is needed, feel free to tell
me!
2024-12-01 17:57:09 -05:00
..
uv Use SharedState for build dispatch (#9553) 2024-12-01 17:20:28 -05:00
uv-auth Publish: Warn when keyring has no password (#8827) 2024-11-27 20:54:49 +01:00
uv-bench Use SharedState for build dispatch (#9553) 2024-12-01 17:20:28 -05:00
uv-build-backend Align indoc and base64 workspace dependencies with root project (#9555) 2024-12-01 17:20:22 -05:00
uv-build-frontend Use consistent formatting for build system errors (#9340) 2024-11-27 14:22:53 +00:00
uv-cache Upgrade to Rust 1.83 (#9511) 2024-11-29 12:04:22 -05:00
uv-cache-info Improve error message for cache info serialization (#8500) 2024-10-23 13:17:31 +00:00
uv-cache-key Remove separate test files in favor of same-file mod tests (#9199) 2024-11-18 20:11:46 +00:00
uv-cli Enable constraints in uv tool upgrade CLI (#9375) 2024-11-25 22:22:30 +00:00
uv-client Upgrade to Rust 1.83 (#9511) 2024-11-29 12:04:22 -05:00
uv-configuration Make MarkerTree Copy (#9542) 2024-11-30 14:07:07 -05:00
uv-console Support interactive input in uv publish (#8158) 2024-10-15 10:00:43 +02:00
uv-dev Reorganize the project concept documentation (#9121) 2024-11-19 13:52:12 -06:00
uv-dirs Eliminate dependencies on directores and dirs-sys (#8048) 2024-11-07 14:29:54 -06:00
uv-dispatch Use SharedState for build dispatch (#9553) 2024-12-01 17:20:28 -05:00
uv-distribution Align indoc and base64 workspace dependencies with root project (#9555) 2024-12-01 17:20:22 -05:00
uv-distribution-filename Remove separate test files in favor of same-file mod tests (#9199) 2024-11-18 20:11:46 +00:00
uv-distribution-types Upgrade to Rust 1.83 (#9511) 2024-11-29 12:04:22 -05:00
uv-extract Upgrade to Rust 1.83 (#9511) 2024-11-29 12:04:22 -05:00
uv-fs Handle Windows AV/EDR file locks during script installations (#9543) 2024-12-01 17:57:09 -05:00
uv-git Remove separate test files in favor of same-file mod tests (#9199) 2024-11-18 20:11:46 +00:00
uv-globfilter Build backend: Revamp include/exclude (#9525) 2024-12-01 11:32:35 +00:00
uv-install-wheel Handle Windows AV/EDR file locks during script installations (#9543) 2024-12-01 17:57:09 -05:00
uv-installer Consistently enforce requested-vs.-built metadata when retrieving wheels (#9484) 2024-11-27 16:51:01 -05:00
uv-macros Generate environment variables doc from code (#8493) 2024-11-03 08:31:38 -06:00
uv-metadata chore: Move all integration tests to a single binary (#8093) 2024-10-11 16:41:35 +02:00
uv-normalize Remove separate test files in favor of same-file mod tests (#9199) 2024-11-18 20:11:46 +00:00
uv-once-map Use shared resolver state between add and lock (#8146) 2024-10-12 14:58:07 +00:00
uv-options-metadata Upgrade to Rust 1.83 (#9511) 2024-11-29 12:04:22 -05:00
uv-pep440 Align indoc and base64 workspace dependencies with root project (#9555) 2024-12-01 17:20:22 -05:00
uv-pep508 Make MarkerTree Copy (#9542) 2024-11-30 14:07:07 -05:00
uv-performance-flate2-backend Use zlib-rs on all platforms (#9264) 2024-11-20 00:01:58 -05:00
uv-performance-memory-allocator Run cargo update (#8703) 2024-11-01 10:26:21 -04:00
uv-platform-tags Fix Python interpreter discovery on non-glibc hosts (#9005) 2024-11-21 12:35:02 +01:00
uv-publish Upload: All metadata incl. PEP 639 (#9442) 2024-11-27 00:25:08 +01:00
uv-pypi-types Make MarkerTree Copy (#9542) 2024-11-30 14:07:07 -05:00
uv-python Align indoc and base64 workspace dependencies with root project (#9555) 2024-12-01 17:20:22 -05:00
uv-requirements Make MarkerTree Copy (#9542) 2024-11-30 14:07:07 -05:00
uv-requirements-txt Align indoc and base64 workspace dependencies with root project (#9555) 2024-12-01 17:20:22 -05:00
uv-resolver Avoid adding non-extra package with extra dependencies (#9540) 2024-12-01 08:42:27 -05:00
uv-scripts Upgrade to Rust 1.83 (#9511) 2024-11-29 12:04:22 -05:00
uv-settings Align indoc and base64 workspace dependencies with root project (#9555) 2024-12-01 17:20:22 -05:00
uv-shell Refactor shell quoting (#9055) 2024-11-15 09:06:54 +00:00
uv-state Add uv-dirs to consolidate directory lookup methods (#8453) 2024-10-22 11:33:25 -05:00
uv-static docs: reference --no-progress option in related environment variable (#9357) 2024-11-22 14:51:53 +00:00
uv-tool Eliminate dependencies on directores and dirs-sys (#8048) 2024-11-07 14:29:54 -06:00
uv-trampoline Update Rust crate fs-err to v3 (#8625) 2024-11-19 15:09:00 +00:00
uv-trampoline-builder Add support for installing versioned Python executables on Windows (#8663) 2024-10-31 15:58:35 +00:00
uv-types Use SharedState for build dispatch (#9553) 2024-12-01 17:20:28 -05:00
uv-version Bump version to 0.5.5 (#9478) 2024-11-27 11:37:39 -06:00
uv-virtualenv Allow apostrophe in venv name (#8984) 2024-11-15 10:52:10 +01:00
uv-warnings chore: Move all integration tests to a single binary (#8093) 2024-10-11 16:41:35 +02:00
uv-workspace Make MarkerTree Copy (#9542) 2024-11-30 14:07:07 -05:00
README.md Link to Dependency specifiers instead of PEP 508 (#8411) 2024-10-21 14:43:38 -04:00

Crates

uv-bench

Functionality for benchmarking uv.

uv-cache-key

Generic functionality for caching paths, URLs, and other resources across platforms.

uv-distribution-filename

Parse built distribution (wheel) and source distribution (sdist) filenames to extract structured metadata.

uv-distribution-types

Abstractions for representing built distributions (wheels) and source distributions (sdists), and the sources from which they can be downloaded.

uv-install-wheel-rs

Install built distributions (wheels) into a virtual environment.

uv-once-map

A waitmap-like concurrent hash map for executing tasks exactly once.

uv-pep440-rs

Utilities for interacting with Python version numbers and specifiers.

uv-pep508-rs

Utilities for parsing and evaluating dependency specifiers, previously known as PEP 508.

uv-platform-tags

Functionality for parsing and inferring Python platform tags as per PEP 425.

uv-cli

Command-line interface for the uv package manager.

uv-build-frontend

A PEP 517-compatible build frontend for uv.

uv-cache

Functionality for caching Python packages and associated metadata.

uv-client

Client for interacting with PyPI-compatible HTTP APIs.

uv-dev

Development utilities for uv.

uv-dispatch

A centralized struct for resolving and building source distributions in isolated environments. Implements the traits defined in uv-types.

uv-distribution

Client for interacting with built distributions (wheels) and source distributions (sdists). Capable of fetching metadata, distribution contents, etc.

uv-extract

Utilities for extracting files from archives.

uv-fs

Utilities for interacting with the filesystem.

uv-git

Functionality for interacting with Git repositories.

uv-installer

Functionality for installing Python packages into a virtual environment.

uv-python

Functionality for detecting and leveraging the current Python interpreter.

uv-normalize

Normalize package and extra names as per Python specifications.

uv-requirements

Utilities for reading package requirements from pyproject.toml and requirements.txt files.

uv-resolver

Functionality for resolving Python packages and their dependencies.

uv-shell

Utilities for detecting and manipulating shell environments.

uv-types

Shared traits for uv, to avoid circular dependencies.

uv-pypi-types

General-purpose type definitions for types used in PyPI-compatible APIs.

uv-virtualenv

A venv replacement to create virtual environments in Rust.

uv-warnings

User-facing warnings for uv.

uv-workspace

Workspace abstractions for uv.

uv-requirements-txt

Functionality for parsing requirements.txt files.