Charlie Marsh 3564e882d7 Ensure consistent indentation when adding dependencies (#14991) ... ## Summary The basic problem here is that when we had multiple items in an inline array, and that array expanded to multiple lines, we accidentally changed the indentation part-way through due to how prefixes work in the TOML. Here's Claude's explanation of the root cause, which I find pretty decent: ``` Here's what happened step by step: 1. First item ("iniconfig"): Has empty prefix "" → indentation_prefix stays None → uses default 4 spaces 2. Second item ("ruff"): Has empty prefix "" → indentation_prefix stays None → uses default 4 spaces 3. Third item ("typing-extensions"): Has prefix " " (single space from inline format) → indentation_prefix becomes Some(" ") → uses only 1 space! This produced: [dependency-groups] dev = [ "iniconfig>=2.0.0", "ruff", "typing-extensions", # ← Only 1 space instead of 4! ] Why the Third Item Had a Different Prefix In inline arrays like ["ruff", "typing-extensions"], the items are separated by commas and spaces. When parsed by the TOML library: - "ruff" has no prefix (it comes right after [) - "typing-extensions" has a single space prefix (the space after the comma) The Fix Moving the indentation calculation outside the loop ensures it's calculated only once: // Calculate indentation ONCE before the loop if let Some(first_item) = deps.iter().next() { let decor_prefix = /* get prefix from first item */ indentation_prefix = (!decor_prefix.is_empty()).then_some(decor_prefix.to_string()); } // Now use the same indentation for ALL items for item in deps.iter_mut() { // Apply consistent indentation to every item } This ensures all items get the same indentation (4 spaces by default when converting from inline arrays), producing the correct output: [dependency-groups] dev = [ "iniconfig>=2.0.0", "ruff", "typing-extensions", # ← Correct 4-space indentation ] The bug only affected arrays being converted from inline to multiline format, where different items might have different residual formatting from their inline representation. ``` Closes #14961. --------- Co-authored-by: Zanie Blue <contact@zanie.dev>		2025-07-31 11:50:05 +00:00
..
src	Ensure consistent indentation when adding dependencies (#14991)	2025-07-31 11:50:05 +00:00
Cargo.toml	Use workspace dependencies for crate dev-dependencies (#14903)	2025-07-25 13:57:49 -05:00